From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6739F1AD3E4; Tue, 16 Jul 2024 14:30:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721140205; cv=none; b=BGAnKZ8TMx44sXw3e85ZBewq7Rx4TEFKp069i47qUgVAsDrbNtl4Dr/77BEAp4kO+vBglhdubIO3SIFrQuCcvPvAhwflMI31RFg2bjsKVQSSgHObTvmlwBOxg+54IpvTSj+8E/sURbETqzVOdO1XYqrvrS2i5S6DFO5KTTLolsk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721140205; c=relaxed/simple; bh=AmpszJIZR8vkkieOvXFO51BgFwt1YOElAtnDfJdR83o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NRVLLSet4d1JkTOYdGI6rqarqWU+hd+tfSFtpH6TBCLJBc9dhl5wa49WO3tIbQXfJBmjOIZAODh0pXY/WmW1ANQOfbFZBmojySQS1gnxqg2WFSYjr270jV2he9suqkTllcrkCrESb+14TpZCXr5Tki7628UyhyTW9SIkRk6LeKE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=i8f0A7YT; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="i8f0A7YT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E35B2C4AF09; Tue, 16 Jul 2024 14:30:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721140205; bh=AmpszJIZR8vkkieOvXFO51BgFwt1YOElAtnDfJdR83o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=i8f0A7YTPy92WEANLA3pa0Zz9VXhwf5g61Q+zNlQ9APhQg1Tm+SFVm983pt6f6ZyD wrAjpApXqlr6sVLfaKDpTSdE7pEeRFxDoP45x1L2OkGwv/Cb+g8NT1GupSSVygGkSH OL9YIMTkNVdvH1yXTdeRWfaZEXUsnkX/nrDVUL2gAS9yyysIMUUpjPSZsyAf/d/dxb gvOeJZ0zBvWEDYCRwnWCy3bo7FCUEjBF/nkIwlu8ehjRzJsFW3nD0oQyJQ0Q0cAJR+ t68OVvwLvnOCycVFBSu2W9nJUUWhAA0JkyxsYjtp3Ipg0MTTML+1qmcCQK8OV8bwfq xT/L2fWCuTutQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Xingui Yang , John Garry , "Martin K . Petersen" , Sasha Levin , James.Bottomley@HansenPartnership.com, dlemoal@kernel.org, yanaijie@huawei.com, yuehaibing@huawei.com, linux-scsi@vger.kernel.org Subject: [PATCH AUTOSEL 5.10 4/7] scsi: libsas: Fix exp-attached device scan after probe failure scanned in again after probe failed Date: Tue, 16 Jul 2024 10:29:44 -0400 Message-ID: <20240716142953.2714154-4-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240716142953.2714154-1-sashal@kernel.org> References: <20240716142953.2714154-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.10.221 Content-Transfer-Encoding: 8bit From: Xingui Yang [ Upstream commit ab2068a6fb84751836a84c26ca72b3beb349619d ] The expander phy will be treated as broadcast flutter in the next revalidation after the exp-attached end device probe failed, as follows: [78779.654026] sas: broadcast received: 0 [78779.654037] sas: REVALIDATING DOMAIN on port 0, pid:10 [78779.654680] sas: ex 500e004aaaaaaa1f phy05 change count has changed [78779.662977] sas: ex 500e004aaaaaaa1f phy05 originated BROADCAST(CHANGE) [78779.662986] sas: ex 500e004aaaaaaa1f phy05 new device attached [78779.663079] sas: ex 500e004aaaaaaa1f phy05:U:8 attached: 500e004aaaaaaa05 (stp) [78779.693542] hisi_sas_v3_hw 0000:b4:02.0: dev[16:5] found [78779.701155] sas: done REVALIDATING DOMAIN on port 0, pid:10, res 0x0 [78779.707864] sas: Enter sas_scsi_recover_host busy: 0 failed: 0 ... [78835.161307] sas: --- Exit sas_scsi_recover_host: busy: 0 failed: 0 tries: 1 [78835.171344] sas: sas_probe_sata: for exp-attached device 500e004aaaaaaa05 returned -19 [78835.180879] hisi_sas_v3_hw 0000:b4:02.0: dev[16:5] is gone [78835.187487] sas: broadcast received: 0 [78835.187504] sas: REVALIDATING DOMAIN on port 0, pid:10 [78835.188263] sas: ex 500e004aaaaaaa1f phy05 change count has changed [78835.195870] sas: ex 500e004aaaaaaa1f phy05 originated BROADCAST(CHANGE) [78835.195875] sas: ex 500e004aaaaaaa1f rediscovering phy05 [78835.196022] sas: ex 500e004aaaaaaa1f phy05:U:A attached: 500e004aaaaaaa05 (stp) [78835.196026] sas: ex 500e004aaaaaaa1f phy05 broadcast flutter [78835.197615] sas: done REVALIDATING DOMAIN on port 0, pid:10, res 0x0 The cause of the problem is that the related ex_phy's attached_sas_addr was not cleared after the end device probe failed, so reset it. Signed-off-by: Xingui Yang Link: https://lore.kernel.org/r/20240619091742.25465-1-yangxingui@huawei.com Reviewed-by: John Garry Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/libsas/sas_internal.h | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/scsi/libsas/sas_internal.h b/drivers/scsi/libsas/sas_internal.h index 52e09c3e2b50d..3ef2fde28b8ed 100644 --- a/drivers/scsi/libsas/sas_internal.h +++ b/drivers/scsi/libsas/sas_internal.h @@ -114,6 +114,20 @@ static inline void sas_fail_probe(struct domain_device *dev, const char *func, i func, dev->parent ? "exp-attached" : "direct-attached", SAS_ADDR(dev->sas_addr), err); + + /* + * If the device probe failed, the expander phy attached address + * needs to be reset so that the phy will not be treated as flutter + * in the next revalidation + */ + if (dev->parent && !dev_is_expander(dev->dev_type)) { + struct sas_phy *phy = dev->phy; + struct domain_device *parent = dev->parent; + struct ex_phy *ex_phy = &parent->ex_dev.ex_phy[phy->number]; + + memset(ex_phy->attached_sas_addr, 0, SAS_ADDR_SIZE); + } + sas_unregister_dev(dev->port, dev); } -- 2.43.0