From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 539461A909D; Tue, 16 Jul 2024 18:34:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721154862; cv=none; b=YUzllpKcYv/R0XTUjWSYRFdfOQYp43Ny7qb/tIVd99NBT1zj7BMKdnaqRxKWHchDBssFyUNehdiY3SfV9uOzlIki2IVvx2WSgRflyS93BnFT71hxw01upJ8Jcxa4W7c8LSO7ZHQmO1Wj6driaKgP9942+uTdn+6VmZTDtFyHPfc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721154862; c=relaxed/simple; bh=UNqwYjlm8ilvI7QSjMxE3SYtRhmvd2tBeL4EwQ7bx8s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bOaxOK3WqCF0tz9lvD9vTKdWlsQCyBTRreQ+hksQoFR7AOpQt5HdU7HvvU4gk//EO3fX2nMpcM/civ4ZitT9KeMr8oCzfgOohdMAyotE0FtTYgGXqiQPg8VK32N7fItMd3rDaeOaO83gFhZRq1Js0FvXf+5qRxC/EBFI+B4AC0o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LN/7XnAl; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LN/7XnAl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B9F32C116B1; Tue, 16 Jul 2024 18:34:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721154861; bh=UNqwYjlm8ilvI7QSjMxE3SYtRhmvd2tBeL4EwQ7bx8s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LN/7XnAluXRDtlCqhwOnRQARiF+2bOK6o5WCF0Kg8HeBRc2hxIrOKnRBFZzEPVn6A t0M2Eae5PTC1OrtDt7F3QmoptbKDwZYAaEbHdQZxM0+wQXyopTkzz/gj987BFkcgMF 4cMpC/pel3qiL31ECBJwk/pU4hVxF2ndvvl7PtH+LkZW4qewiWrJVuc+kMOQjxK++D 42RjmvqwwLPqulOV62ScgIdNiVBj3543Xf4b4154iqKCkGmXR77sFqV80/91C4Il8O 72QdQA7UqSRDoX6tcpXCcfF5mBmiQJ32eKtVP7lqn6uvk2fxo+zxHwAS3tVigk/5vp Qu6HwPQ2wELrQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Edward Adam Davis , syzbot+efde959319469ff8d4d7@syzkaller.appspotmail.com, syzbot+01ade747b16e9c8030e0@syzkaller.appspotmail.com, Christian Brauner , Sasha Levin , walmeida@microsoft.com, linux-fsdevel@vger.kernel.org Subject: [PATCH AUTOSEL 6.1 4/5] hfsplus: fix uninit-value in copy_name Date: Tue, 16 Jul 2024 14:34:01 -0400 Message-ID: <20240716183409.2814531-4-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240716183409.2814531-1-sashal@kernel.org> References: <20240716183409.2814531-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.1.99 Content-Transfer-Encoding: 8bit From: Edward Adam Davis [ Upstream commit 0570730c16307a72f8241df12363f76600baf57d ] [syzbot reported] BUG: KMSAN: uninit-value in sized_strscpy+0xc4/0x160 sized_strscpy+0xc4/0x160 copy_name+0x2af/0x320 fs/hfsplus/xattr.c:411 hfsplus_listxattr+0x11e9/0x1a50 fs/hfsplus/xattr.c:750 vfs_listxattr fs/xattr.c:493 [inline] listxattr+0x1f3/0x6b0 fs/xattr.c:840 path_listxattr fs/xattr.c:864 [inline] __do_sys_listxattr fs/xattr.c:876 [inline] __se_sys_listxattr fs/xattr.c:873 [inline] __x64_sys_listxattr+0x16b/0x2f0 fs/xattr.c:873 x64_sys_call+0x2ba0/0x3b50 arch/x86/include/generated/asm/syscalls_64.h:195 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcf/0x1e0 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f Uninit was created at: slab_post_alloc_hook mm/slub.c:3877 [inline] slab_alloc_node mm/slub.c:3918 [inline] kmalloc_trace+0x57b/0xbe0 mm/slub.c:4065 kmalloc include/linux/slab.h:628 [inline] hfsplus_listxattr+0x4cc/0x1a50 fs/hfsplus/xattr.c:699 vfs_listxattr fs/xattr.c:493 [inline] listxattr+0x1f3/0x6b0 fs/xattr.c:840 path_listxattr fs/xattr.c:864 [inline] __do_sys_listxattr fs/xattr.c:876 [inline] __se_sys_listxattr fs/xattr.c:873 [inline] __x64_sys_listxattr+0x16b/0x2f0 fs/xattr.c:873 x64_sys_call+0x2ba0/0x3b50 arch/x86/include/generated/asm/syscalls_64.h:195 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcf/0x1e0 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f [Fix] When allocating memory to strbuf, initialize memory to 0. Reported-and-tested-by: syzbot+efde959319469ff8d4d7@syzkaller.appspotmail.com Signed-off-by: Edward Adam Davis Link: https://lore.kernel.org/r/tencent_8BBB6433BC9E1C1B7B4BDF1BF52574BA8808@qq.com Reported-and-tested-by: syzbot+01ade747b16e9c8030e0@syzkaller.appspotmail.com Signed-off-by: Christian Brauner Signed-off-by: Sasha Levin --- fs/hfsplus/xattr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/hfsplus/xattr.c b/fs/hfsplus/xattr.c index 49891b12c4156..2b0e0ba58139b 100644 --- a/fs/hfsplus/xattr.c +++ b/fs/hfsplus/xattr.c @@ -699,7 +699,7 @@ ssize_t hfsplus_listxattr(struct dentry *dentry, char *buffer, size_t size) return err; } - strbuf = kmalloc(NLS_MAX_CHARSET_SIZE * HFSPLUS_ATTR_MAX_STRLEN + + strbuf = kzalloc(NLS_MAX_CHARSET_SIZE * HFSPLUS_ATTR_MAX_STRLEN + XATTR_MAC_OSX_PREFIX_LEN + 1, GFP_KERNEL); if (!strbuf) { res = -ENOMEM; -- 2.43.0