From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF6231AC225; Tue, 16 Jul 2024 18:35:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721154923; cv=none; b=F8ImewblImZbmC6rMMAe10HJ/3A2TSK/WH5rPbkI32Rr0XnLukKCi4uhH+WxvmSHXeppjToyTB/nKNkEg8XJsUFD4DwK22iteoLMDxSnxbZ/7gnyHtINP9fikycimIugnsk+YcdYeLyYkgoyiQ18UppsZyc2NpgB8uOXER5bWt4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721154923; c=relaxed/simple; bh=UQ+pROdsszdPY7gMG8lq46WxWPu/jbbHpZmRK5WsxDg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=R67Sk6oNBuD74f31ebbBM5k3xRWD6xzMAWqgD/yWZHSrwPUHY64ismgRsaUrXjtDBO16f9UYx4MTM72UbKa2vRRcA00039Zka81lHHgRhHRi5fVsPrmoytfLcAqqtInyY0890VC6Z3RzzYA2zM0nSVuWfb0/dhH4eza78AaQuNs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=N+pk7f2Q; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="N+pk7f2Q" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 527D5C4AF0E; Tue, 16 Jul 2024 18:35:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721154922; bh=UQ+pROdsszdPY7gMG8lq46WxWPu/jbbHpZmRK5WsxDg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=N+pk7f2Q68F0j1vPdVG7sknqj3ELSCGjpUnNd/AFReYqkpJ8H9YgReLIDYz5oRlcS bo32URyV75cWrxWobPg96CW0PkZjTmheXDCqxCPM71qmjqxrSS53LZlvTPHmofAQ0A cNJGgtsEU4O44ZBdz78xeVe4Khz3LN4wfpnucnxWQ2mnDovH+AmcbT9DEvM3W+RM7j FR2f6x5kp09z6DKlrZok2v5ORuFtuzrT9QLej5nY0QFBYOUwzf6ujTDpHkzgT3Aiem ud/y0d+Md1JFBXz+umJpVUY7mPOGbvLEj6E3r2XhaA8ZomlXjK8JzfjqSZ1cEQ+vu6 yAG139uKCoonw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Edward Adam Davis , syzbot+efde959319469ff8d4d7@syzkaller.appspotmail.com, syzbot+01ade747b16e9c8030e0@syzkaller.appspotmail.com, Christian Brauner , Sasha Levin , walmeida@microsoft.com, linux-fsdevel@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 3/3] hfsplus: fix uninit-value in copy_name Date: Tue, 16 Jul 2024 14:35:09 -0400 Message-ID: <20240716183513.2814965-3-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240716183513.2814965-1-sashal@kernel.org> References: <20240716183513.2814965-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 4.19.317 Content-Transfer-Encoding: 8bit From: Edward Adam Davis [ Upstream commit 0570730c16307a72f8241df12363f76600baf57d ] [syzbot reported] BUG: KMSAN: uninit-value in sized_strscpy+0xc4/0x160 sized_strscpy+0xc4/0x160 copy_name+0x2af/0x320 fs/hfsplus/xattr.c:411 hfsplus_listxattr+0x11e9/0x1a50 fs/hfsplus/xattr.c:750 vfs_listxattr fs/xattr.c:493 [inline] listxattr+0x1f3/0x6b0 fs/xattr.c:840 path_listxattr fs/xattr.c:864 [inline] __do_sys_listxattr fs/xattr.c:876 [inline] __se_sys_listxattr fs/xattr.c:873 [inline] __x64_sys_listxattr+0x16b/0x2f0 fs/xattr.c:873 x64_sys_call+0x2ba0/0x3b50 arch/x86/include/generated/asm/syscalls_64.h:195 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcf/0x1e0 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f Uninit was created at: slab_post_alloc_hook mm/slub.c:3877 [inline] slab_alloc_node mm/slub.c:3918 [inline] kmalloc_trace+0x57b/0xbe0 mm/slub.c:4065 kmalloc include/linux/slab.h:628 [inline] hfsplus_listxattr+0x4cc/0x1a50 fs/hfsplus/xattr.c:699 vfs_listxattr fs/xattr.c:493 [inline] listxattr+0x1f3/0x6b0 fs/xattr.c:840 path_listxattr fs/xattr.c:864 [inline] __do_sys_listxattr fs/xattr.c:876 [inline] __se_sys_listxattr fs/xattr.c:873 [inline] __x64_sys_listxattr+0x16b/0x2f0 fs/xattr.c:873 x64_sys_call+0x2ba0/0x3b50 arch/x86/include/generated/asm/syscalls_64.h:195 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcf/0x1e0 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f [Fix] When allocating memory to strbuf, initialize memory to 0. Reported-and-tested-by: syzbot+efde959319469ff8d4d7@syzkaller.appspotmail.com Signed-off-by: Edward Adam Davis Link: https://lore.kernel.org/r/tencent_8BBB6433BC9E1C1B7B4BDF1BF52574BA8808@qq.com Reported-and-tested-by: syzbot+01ade747b16e9c8030e0@syzkaller.appspotmail.com Signed-off-by: Christian Brauner Signed-off-by: Sasha Levin --- fs/hfsplus/xattr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/hfsplus/xattr.c b/fs/hfsplus/xattr.c index d5403b4004c97..cf8647a4c35bd 100644 --- a/fs/hfsplus/xattr.c +++ b/fs/hfsplus/xattr.c @@ -700,7 +700,7 @@ ssize_t hfsplus_listxattr(struct dentry *dentry, char *buffer, size_t size) return err; } - strbuf = kmalloc(NLS_MAX_CHARSET_SIZE * HFSPLUS_ATTR_MAX_STRLEN + + strbuf = kzalloc(NLS_MAX_CHARSET_SIZE * HFSPLUS_ATTR_MAX_STRLEN + XATTR_MAC_OSX_PREFIX_LEN + 1, GFP_KERNEL); if (!strbuf) { res = -ENOMEM; -- 2.43.0