From: Vasileios Amoiridis <vassilisamir@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Adam Rizkalla <ajarizzo@gmail.com>,
Vasileios Amoiridis <vassilisamir@gmail.com>,
lars@metafoo.de, petre.rodan@subdimension.ro,
mazziesaccount@gmail.com, ak@it-klinger.de,
ang.iglesiasg@gmail.com, linus.walleij@linaro.org,
tgamblin@baylibre.com, phil@raspberrypi.com, 579lpy@gmail.com,
andriy.shevchenko@linux.intel.com, semen.protsenko@linaro.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 1/3] iio: pressure: bmp280: Generalize read_*() functions
Date: Tue, 16 Jul 2024 21:06:02 +0200 [thread overview]
Message-ID: <20240716190602.GA577521@vamoiridPC> (raw)
In-Reply-To: <20240716180850.7c6089f2@jic23-huawei>
On Tue, Jul 16, 2024 at 06:08:50PM +0100, Jonathan Cameron wrote:
>
> > >
> > > static const int bmp580_odr_table[][2] = {
> > > @@ -1830,6 +1848,9 @@ static int bmp580_chip_config(struct bmp280_data *data)
> > >
> > > static const int bmp580_oversampling_avail[] = { 1, 2, 4, 8, 16, 32, 64, 128 };
> > > static const u8 bmp580_chip_ids[] = { BMP580_CHIP_ID, BMP580_CHIP_ID_ALT };
> > > +/* Instead of { 1000, 16 } we do this, to avoid overflow issues */
> > > +static const int bmp580_temp_coeffs[] = { 125, 13 };
> >
> > I'm not really sure what we gain here from using 125/13 instead of
> > 250/14...but I don't think it hurts either.
> >
> > I don't have a way to test this with the latest kernel release
> > currently, but lgtm.
> >
> > Acked-by: Adam Rizkalla <ajarizzo@gmail.com>
> Series applied. Thanks
>
> Jonathan
Hi Jonathan,
Thank you very much!
Cheers,
Vasilis
next prev parent reply other threads:[~2024-07-16 19:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-28 17:17 [PATCH v9 0/3] iio: pressure: bmp280: Minor cleanup and triggered Vasileios Amoiridis
2024-06-28 17:17 ` [PATCH v9 1/3] iio: pressure: bmp280: Generalize read_*() functions Vasileios Amoiridis
2024-07-14 22:16 ` Adam Rizkalla
2024-07-16 17:08 ` Jonathan Cameron
2024-07-16 19:06 ` Vasileios Amoiridis [this message]
2024-06-28 17:17 ` [PATCH v9 2/3] iio: pressure: bmp280: Add SCALE, RAW values in channels and refactorize them Vasileios Amoiridis
2024-06-28 17:17 ` [PATCH v9 3/3] iio: pressure: bmp280: Add triggered buffer support Vasileios Amoiridis
2024-06-30 10:23 ` [PATCH v9 0/3] iio: pressure: bmp280: Minor cleanup and triggered Jonathan Cameron
2024-06-30 20:27 ` Vasileios Amoiridis
2024-07-13 10:00 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240716190602.GA577521@vamoiridPC \
--to=vassilisamir@gmail.com \
--cc=579lpy@gmail.com \
--cc=ajarizzo@gmail.com \
--cc=ak@it-klinger.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ang.iglesiasg@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=petre.rodan@subdimension.ro \
--cc=phil@raspberrypi.com \
--cc=semen.protsenko@linaro.org \
--cc=tgamblin@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox