* [PATCH 4.19 00/66] 4.19.318-rc1 review
@ 2024-07-16 15:30 Greg Kroah-Hartman
2024-07-16 20:11 ` Pavel Machek
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Greg Kroah-Hartman @ 2024-07-16 15:30 UTC (permalink / raw)
To: stable
Cc: Greg Kroah-Hartman, patches, linux-kernel, torvalds, akpm, linux,
shuah, patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml, broonie
This is the start of the stable review cycle for the 4.19.318 release.
There are 66 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.
Responses should be made by Thu, 18 Jul 2024 15:27:21 +0000.
Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.318-rc1.gz
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
and the diffstat can be found below.
thanks,
greg k-h
-------------
Pseudo-Shortlog of commits:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Linux 4.19.318-rc1
Wolfram Sang <wsa+renesas@sang-engineering.com>
i2c: rcar: bring hardware to known state when probing
Ryusuke Konishi <konishi.ryusuke@gmail.com>
nilfs2: fix kernel bug on rename operation of broken directory
felix <fuzhen5@huawei.com>
SUNRPC: Fix RPC client cleaned up the freed pipefs dentries
Eric Dumazet <edumazet@google.com>
tcp: avoid too many retransmit packets
Eric Dumazet <edumazet@google.com>
tcp: use signed arithmetic in tcp_rtx_probe0_timed_out()
Menglong Dong <imagedong@tencent.com>
net: tcp: fix unexcepted socket die when snd_wnd is 0
Eric Dumazet <edumazet@google.com>
tcp: refactor tcp_retransmit_timer()
Ilya Dryomov <idryomov@gmail.com>
libceph: fix race between delayed_work() and ceph_monc_stop()
He Zhe <zhe.he@windriver.com>
hpet: Support 32-bit userspace
Alan Stern <stern@rowland.harvard.edu>
USB: core: Fix duplicate endpoint bug by clearing reserved bits in the descriptor
Lee Jones <lee@kernel.org>
usb: gadget: configfs: Prevent OOB read/write in usb_string_copy()
WangYuli <wangyuli@uniontech.com>
USB: Add USB_QUIRK_NO_SET_INTF quirk for START BP-850k
Vanillan Wang <vanillanwang@163.com>
USB: serial: option: add Rolling RW350-GL variants
Mank Wang <mank.wang@netprisma.us>
USB: serial: option: add Netprisma LCUK54 series modules
Slark Xiao <slark_xiao@163.com>
USB: serial: option: add support for Foxconn T99W651
Bjørn Mork <bjorn@mork.no>
USB: serial: option: add Fibocom FM350-GL
Daniele Palmas <dnlplm@gmail.com>
USB: serial: option: add Telit FN912 rmnet compositions
Daniele Palmas <dnlplm@gmail.com>
USB: serial: option: add Telit generic core-dump composition
Chen Ni <nichen@iscas.ac.cn>
ARM: davinci: Convert comma to semicolon
Sven Schnelle <svens@linux.ibm.com>
s390: Mark psw in __load_psw_mask() as __unitialized
Dmitry Antipov <dmantipov@yandex.ru>
ppp: reject claimed-as-LCP but actually malformed packets
Aleksander Jan Bajkowski <olek2@wp.pl>
net: ethernet: lantiq_etop: fix double free in detach
Aleksander Jan Bajkowski <olek2@wp.pl>
net: lantiq_etop: add blank line after declaration
Neal Cardwell <ncardwell@google.com>
tcp: fix incorrect undo caused by DSACK of TLP retransmit
Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
drm/i915: make find_fw_domain work on intel_uncore
Ryusuke Konishi <konishi.ryusuke@gmail.com>
nilfs2: fix incorrect inode allocation from reserved inodes
Piotr Wojtaszczyk <piotr.wojtaszczyk@timesys.com>
i2c: pnx: Fix potential deadlock warning from del_timer_sync() call in isr
Mauro Carvalho Chehab <mchehab@kernel.org>
media: dw2102: fix a potential buffer overflow
Ghadi Elie Rahme <ghadi.rahme@canonical.com>
bnx2x: Fix multiple UBSAN array-index-out-of-bounds
Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu/atomfirmware: silence UBSAN warning
Ma Ke <make24@iscas.ac.cn>
drm/nouveau: fix null pointer dereference in nouveau_connector_get_modes
Jan Kara <jack@suse.cz>
Revert "mm/writeback: fix possible divide-by-zero in wb_dirty_limits(), again"
Jan Kara <jack@suse.cz>
fsnotify: Do not generate events for O_PATH file descriptors
Jimmy Assarsson <extja@kvaser.com>
can: kvaser_usb: Explicitly initialize family in leafimx driver_info struct
Jaganath Kanakkassery <jaganath.k.os@gmail.com>
Bluetooth: Fix incorrect pointer arithmatic in ext_adv_report_evt
Jinliang Zheng <alexjlzheng@tencent.com>
mm: optimize the redundant loop of mm_update_owner_next()
Ryusuke Konishi <konishi.ryusuke@gmail.com>
nilfs2: add missing check for inode numbers on directory entries
Ryusuke Konishi <konishi.ryusuke@gmail.com>
nilfs2: fix inode number range checks
Shigeru Yoshida <syoshida@redhat.com>
inet_diag: Initialize pad field in struct inet_diag_req_v2
Zijian Zhang <zijianzhang@bytedance.com>
selftests: make order checking verbose in msg_zerocopy selftest
Zijian Zhang <zijianzhang@bytedance.com>
selftests: fix OOM in msg_zerocopy selftest
Sam Sun <samsun1006219@gmail.com>
bonding: Fix out-of-bounds read in bond_option_arp_ip_targets_set()
Jakub Kicinski <kuba@kernel.org>
tcp_metrics: validate source addr length
Neal Cardwell <ncardwell@google.com>
UPSTREAM: tcp: fix DSACK undo in fast recovery to call tcp_try_to_open()
Yuchung Cheng <ycheng@google.com>
net: tcp better handling of reordering then loss cases
Yousuk Seung <ysseung@google.com>
tcp: add ece_ack flag to reno sack functions
zhang kai <zhangkaiheb@126.com>
tcp: tcp_mark_head_lost is only valid for sack-tcp
Eric Dumazet <edumazet@google.com>
tcp: take care of compressed acks in tcp_add_reno_sack()
Holger Dengler <dengler@linux.ibm.com>
s390/pkey: Wipe sensitive data on failure
Wang Yong <wang.yong12@zte.com.cn>
jffs2: Fix potential illegal address access in jffs2_free_inode
Greg Kurz <groug@kaod.org>
powerpc/xmon: Check cpu id in commands "c#", "dp#" and "dx#"
Mike Marshall <hubcap@omnibond.com>
orangefs: fix out-of-bounds fsid access
Michael Ellerman <mpe@ellerman.id.au>
powerpc/64: Set _IO_BASE to POISON_POINTER_DELTA not 0 for CONFIG_PCI=n
Heiner Kallweit <hkallweit1@gmail.com>
i2c: i801: Annotate apanel_addr as __ro_after_init
Ricardo Ribalda <ribalda@chromium.org>
media: dvb-frontends: tda10048: Fix integer overflow
Ricardo Ribalda <ribalda@chromium.org>
media: s2255: Use refcount_t instead of atomic_t for num_channels
Ricardo Ribalda <ribalda@chromium.org>
media: dvb-frontends: tda18271c2dd: Remove casting during div
Simon Horman <horms@kernel.org>
net: dsa: mv88e6xxx: Correct check for empty list
Erick Archer <erick.archer@outlook.com>
Input: ff-core - prefer struct_size over open coded arithmetic
Jean Delvare <jdelvare@suse.de>
firmware: dmi: Stop decoding on broken entry
Erick Archer <erick.archer@outlook.com>
sctp: prefer struct_size over open coded arithmetic
Michael Bunk <micha@freedict.org>
media: dw2102: Don't translate i2c read into write
Alex Hung <alex.hung@amd.com>
drm/amd/display: Skip finding free audio for unknown engine_id
Michael Guralnik <michaelgur@nvidia.com>
IB/core: Implement a limit on UMAD receive List
Ricardo Ribalda <ribalda@chromium.org>
media: dvb-usb: dib0700_devices: Add missing release_firmware()
Ricardo Ribalda <ribalda@chromium.org>
media: dvb: as102-fe: Fix as10x_register_addr packing
-------------
Diffstat:
Makefile | 4 +-
arch/arm/mach-davinci/pm.c | 2 +-
arch/powerpc/include/asm/io.h | 2 +-
arch/powerpc/xmon/xmon.c | 6 +-
arch/s390/include/asm/processor.h | 2 +-
drivers/char/hpet.c | 34 ++++-
drivers/firmware/dmi_scan.c | 11 ++
drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 3 +
drivers/gpu/drm/amd/include/atomfirmware.h | 2 +-
drivers/gpu/drm/i915/intel_uncore.c | 20 +--
drivers/gpu/drm/nouveau/nouveau_connector.c | 3 +
drivers/i2c/busses/i2c-i801.c | 2 +-
drivers/i2c/busses/i2c-pnx.c | 48 ++-----
drivers/i2c/busses/i2c-rcar.c | 17 ++-
drivers/infiniband/core/user_mad.c | 21 ++-
drivers/input/ff-core.c | 7 +-
drivers/media/dvb-frontends/as102_fe_types.h | 2 +-
drivers/media/dvb-frontends/tda10048.c | 9 +-
drivers/media/dvb-frontends/tda18271c2dd.c | 4 +-
drivers/media/usb/dvb-usb/dib0700_devices.c | 18 ++-
drivers/media/usb/dvb-usb/dw2102.c | 120 +++++++++-------
drivers/media/usb/s2255/s2255drv.c | 20 +--
drivers/net/bonding/bond_options.c | 6 +-
drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c | 1 +
drivers/net/dsa/mv88e6xxx/chip.c | 4 +-
drivers/net/ethernet/broadcom/bnx2x/bnx2x.h | 2 +-
drivers/net/ethernet/lantiq_etop.c | 5 +-
drivers/net/ppp/ppp_generic.c | 15 ++
drivers/s390/crypto/pkey_api.c | 4 +-
drivers/usb/core/config.c | 18 ++-
drivers/usb/core/quirks.c | 3 +
drivers/usb/gadget/configfs.c | 3 +
drivers/usb/serial/option.c | 38 ++++++
fs/jffs2/super.c | 1 +
fs/nilfs2/alloc.c | 18 ++-
fs/nilfs2/alloc.h | 4 +-
fs/nilfs2/dat.c | 2 +-
fs/nilfs2/dir.c | 38 +++++-
fs/nilfs2/ifile.c | 7 +-
fs/nilfs2/nilfs.h | 10 +-
fs/nilfs2/the_nilfs.c | 6 +
fs/nilfs2/the_nilfs.h | 2 +-
fs/orangefs/super.c | 3 +-
include/linux/fsnotify.h | 8 +-
include/linux/sunrpc/clnt.h | 1 +
kernel/exit.c | 2 +
mm/page-writeback.c | 2 +-
net/bluetooth/hci_event.c | 2 +-
net/ceph/mon_client.c | 14 +-
net/ipv4/inet_diag.c | 2 +
net/ipv4/tcp_input.c | 158 ++++++++++++----------
net/ipv4/tcp_metrics.c | 1 +
net/ipv4/tcp_timer.c | 45 +++++-
net/sctp/socket.c | 7 +-
net/sunrpc/clnt.c | 5 +-
tools/testing/selftests/net/msg_zerocopy.c | 14 +-
56 files changed, 544 insertions(+), 264 deletions(-)
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 4.19 00/66] 4.19.318-rc1 review
2024-07-16 15:30 [PATCH 4.19 00/66] 4.19.318-rc1 review Greg Kroah-Hartman
@ 2024-07-16 20:11 ` Pavel Machek
2024-07-16 21:00 ` Naresh Kamboju
` (2 subsequent siblings)
3 siblings, 0 replies; 8+ messages in thread
From: Pavel Machek @ 2024-07-16 20:11 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml, broonie
[-- Attachment #1: Type: text/plain, Size: 661 bytes --]
Hi!
> This is the start of the stable review cycle for the 4.19.318 release.
> There are 66 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
CIP testing did not find any problems here:
https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-4.19.y
Tested-by: Pavel Machek (CIP) <pavel@denx.de>
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 4.19 00/66] 4.19.318-rc1 review
2024-07-16 15:30 [PATCH 4.19 00/66] 4.19.318-rc1 review Greg Kroah-Hartman
2024-07-16 20:11 ` Pavel Machek
@ 2024-07-16 21:00 ` Naresh Kamboju
2024-07-17 6:21 ` Greg Kroah-Hartman
2024-07-17 8:54 ` Frank Scheiner
2024-07-17 15:57 ` Shuah Khan
3 siblings, 1 reply; 8+ messages in thread
From: Naresh Kamboju @ 2024-07-16 21:00 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml, broonie
On Tue, 16 Jul 2024 at 21:04, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> This is the start of the stable review cycle for the 4.19.318 release.
> There are 66 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 18 Jul 2024 15:27:21 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.318-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
The 390 builds failed on 6.6, 6.1, 5.15, 5.10, 5.4 and 4.19
* s390, build
- clang-18-allnoconfig
- clang-18-defconfig
- clang-18-tinyconfig
- clang-nightly-allnoconfig
- clang-nightly-defconfig
- clang-nightly-tinyconfig
- gcc-12-allnoconfig
- gcc-12-defconfig
- gcc-12-tinyconfig
- gcc-8-allnoconfig
- gcc-8-defconfig-fe40093d
- gcc-8-tinyconfig
Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
Build log:
-------
arch/s390/include/asm/processor.h: In function '__load_psw_mask':
arch/s390/include/asm/processor.h:292:19: error: expected '=', ',',
';', 'asm' or '__attribute__' before '__uninitialized'
292 | psw_t psw __uninitialized;
| ^~~~~~~~~~~~~~~
arch/s390/include/asm/processor.h:292:19: error: '__uninitialized'
undeclared (first use in this function); did you mean
'uninitialized_var'?
292 | psw_t psw __uninitialized;
| ^~~~~~~~~~~~~~~
| uninitialized_var
arch/s390/include/asm/processor.h:292:19: note: each undeclared
identifier is reported only once for each function it appears in
arch/s390/include/asm/processor.h:293:9: warning: ISO C90 forbids
mixed declarations and code [-Wdeclaration-after-statement]
293 | unsigned long addr;
| ^~~~~~~~
arch/s390/include/asm/processor.h:295:9: error: 'psw' undeclared
(first use in this function); did you mean 'psw_t'?
295 | psw.mask = mask;
| ^~~
| psw_t
Steps to reproduce:
----------
# tuxmake --runtime podman --target-arch s390 --toolchain gcc-12
--kconfig tinyconfig
--
Linaro LKFT
https://lkft.linaro.org
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 4.19 00/66] 4.19.318-rc1 review
2024-07-16 21:00 ` Naresh Kamboju
@ 2024-07-17 6:21 ` Greg Kroah-Hartman
0 siblings, 0 replies; 8+ messages in thread
From: Greg Kroah-Hartman @ 2024-07-17 6:21 UTC (permalink / raw)
To: Naresh Kamboju
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml, broonie
On Wed, Jul 17, 2024 at 02:30:54AM +0530, Naresh Kamboju wrote:
> On Tue, 16 Jul 2024 at 21:04, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > This is the start of the stable review cycle for the 4.19.318 release.
> > There are 66 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Thu, 18 Jul 2024 15:27:21 +0000.
> > Anything received after that time might be too late.
> >
> > The whole patch series can be found in one patch at:
> > https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.318-rc1.gz
> > or in the git tree and branch at:
> > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> > and the diffstat can be found below.
> >
> > thanks,
> >
> > greg k-h
>
>
> The 390 builds failed on 6.6, 6.1, 5.15, 5.10, 5.4 and 4.19
>
>
> * s390, build
> - clang-18-allnoconfig
> - clang-18-defconfig
> - clang-18-tinyconfig
> - clang-nightly-allnoconfig
> - clang-nightly-defconfig
> - clang-nightly-tinyconfig
> - gcc-12-allnoconfig
> - gcc-12-defconfig
> - gcc-12-tinyconfig
> - gcc-8-allnoconfig
> - gcc-8-defconfig-fe40093d
> - gcc-8-tinyconfig
>
>
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
>
> Build log:
> -------
> arch/s390/include/asm/processor.h: In function '__load_psw_mask':
> arch/s390/include/asm/processor.h:292:19: error: expected '=', ',',
> ';', 'asm' or '__attribute__' before '__uninitialized'
> 292 | psw_t psw __uninitialized;
> | ^~~~~~~~~~~~~~~
> arch/s390/include/asm/processor.h:292:19: error: '__uninitialized'
> undeclared (first use in this function); did you mean
> 'uninitialized_var'?
> 292 | psw_t psw __uninitialized;
> | ^~~~~~~~~~~~~~~
> | uninitialized_var
> arch/s390/include/asm/processor.h:292:19: note: each undeclared
> identifier is reported only once for each function it appears in
> arch/s390/include/asm/processor.h:293:9: warning: ISO C90 forbids
> mixed declarations and code [-Wdeclaration-after-statement]
> 293 | unsigned long addr;
> | ^~~~~~~~
> arch/s390/include/asm/processor.h:295:9: error: 'psw' undeclared
> (first use in this function); did you mean 'psw_t'?
> 295 | psw.mask = mask;
> | ^~~
> | psw_t
>
> Steps to reproduce:
> ----------
> # tuxmake --runtime podman --target-arch s390 --toolchain gcc-12
> --kconfig tinyconfig
Offending commit now dropped.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 4.19 00/66] 4.19.318-rc1 review
2024-07-16 15:30 [PATCH 4.19 00/66] 4.19.318-rc1 review Greg Kroah-Hartman
2024-07-16 20:11 ` Pavel Machek
2024-07-16 21:00 ` Naresh Kamboju
@ 2024-07-17 8:54 ` Frank Scheiner
2024-07-17 9:30 ` Greg KH
2024-07-17 15:57 ` Shuah Khan
3 siblings, 1 reply; 8+ messages in thread
From: Frank Scheiner @ 2024-07-17 8:54 UTC (permalink / raw)
To: gregkh
Cc: akpm, allen.lkml, broonie, conor, f.fainelli, jonathanh,
linux-kernel, linux, lkft-triage, patches, patches, pavel,
rwarsow, shuah, srw, stable, sudipm.mukherjee, torvalds,
Tomáš Glozar
Hi there,
fb3739759474d150a9927b920a80ea2afb4c2a51 (from mainline) should be
included in linux-4.19.y, if a589979f345720aca32ff43a2ccaa16a70871b9e
stays in.
****
## Long version ##
It looks like:
```
hpet: Support 32-bit userspace
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?h=linux-4.19.y&id=a589979f345720aca32ff43a2ccaa16a70871b9e
```
...breaks the non-HP-Sim ia64 build ([1]) for us since yesterday:
```
[...]
drivers/char/hpet.c: In function 'hpet_read':
drivers/char/hpet.c:311:36: error: 'compat_ulong_t' undeclared (first
use in this function)
311 | if (count < sizeof(compat_ulong_t))
| ^~~~~~~~~~~~~~
drivers/char/hpet.c:311:36: note: each undeclared identifier is reported
only once for each function it appears in
[...]
```
...as it uses a type not known to ia64 (and possibly other
architectures) w/o also including:
```
asm-generic: Move common compat types to asm-generic/compat.h
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=fb3739759474d150a9927b920a80ea2afb4c2a51
```
The latter seems to be in mainline only since v4.20-rc1 and fixes the
non-HP-Sim ia64 build ([2]) for me.
So fb3739759474d150a9927b920a80ea2afb4c2a51 should be included in
linux-4.19.y, too, if a589979f345720aca32ff43a2ccaa16a70871b9e stays in.
[1]:
https://github.com/linux-ia64/linux-stable-rc/actions/runs/9947642032#summary-27481009307
[2]:
https://github.com/linux-ia64/linux-stable-rc/actions/runs/9970651775#summary-27550542084
Cheers,
Frank
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 4.19 00/66] 4.19.318-rc1 review
2024-07-17 8:54 ` Frank Scheiner
@ 2024-07-17 9:30 ` Greg KH
2024-07-17 9:34 ` Frank Scheiner
0 siblings, 1 reply; 8+ messages in thread
From: Greg KH @ 2024-07-17 9:30 UTC (permalink / raw)
To: Frank Scheiner
Cc: akpm, allen.lkml, broonie, conor, f.fainelli, jonathanh,
linux-kernel, linux, lkft-triage, patches, patches, pavel,
rwarsow, shuah, srw, stable, sudipm.mukherjee, torvalds,
Tomáš Glozar
On Wed, Jul 17, 2024 at 10:54:40AM +0200, Frank Scheiner wrote:
> Hi there,
>
> fb3739759474d150a9927b920a80ea2afb4c2a51 (from mainline) should be
> included in linux-4.19.y, if a589979f345720aca32ff43a2ccaa16a70871b9e
> stays in.
I do not know what commit a589979f345720aca32ff43a2ccaa16a70871b9e is,
sorry. If you rea referring to commits in the -rc tree, please don't as
that tree is rebased and regenerated all the time. In fact, my scripts
don't even save a local copy when they are generated so I have no idea
how to find this :(
Please refer to the commit id in Linus's tree so I have a hint as to
what is happening here.
> ****
>
> ## Long version ##
>
> It looks like:
>
> ```
> hpet: Support 32-bit userspace
>
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?h=linux-4.19.y&id=a589979f345720aca32ff43a2ccaa16a70871b9e
> ```
Ah, you mean commit 4e60131d0d36 ("hpet: Support 32-bit userspace"),
right?
> ...breaks the non-HP-Sim ia64 build ([1]) for us since yesterday:
>
> ```
> [...]
> drivers/char/hpet.c: In function 'hpet_read':
> drivers/char/hpet.c:311:36: error: 'compat_ulong_t' undeclared (first
> use in this function)
> 311 | if (count < sizeof(compat_ulong_t))
> | ^~~~~~~~~~~~~~
> drivers/char/hpet.c:311:36: note: each undeclared identifier is reported
> only once for each function it appears in
> [...]
> ```
>
> ...as it uses a type not known to ia64 (and possibly other
> architectures) w/o also including:
>
> ```
> asm-generic: Move common compat types to asm-generic/compat.h
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=fb3739759474d150a9927b920a80ea2afb4c2a51
> ```
>
> The latter seems to be in mainline only since v4.20-rc1 and fixes the
> non-HP-Sim ia64 build ([2]) for me.
>
> So fb3739759474d150a9927b920a80ea2afb4c2a51 should be included in
> linux-4.19.y, too, if a589979f345720aca32ff43a2ccaa16a70871b9e stays in.
Ok, I'll queue this one up as well, hopefully nothing else breaks...
thanks,
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 4.19 00/66] 4.19.318-rc1 review
2024-07-17 9:30 ` Greg KH
@ 2024-07-17 9:34 ` Frank Scheiner
0 siblings, 0 replies; 8+ messages in thread
From: Frank Scheiner @ 2024-07-17 9:34 UTC (permalink / raw)
To: Greg KH
Cc: akpm, allen.lkml, broonie, conor, f.fainelli, jonathanh,
linux-kernel, linux, lkft-triage, patches, patches, pavel,
rwarsow, shuah, srw, stable, sudipm.mukherjee, torvalds,
Tomáš Glozar
On 17.07.24 11:30, Greg KH wrote:
> On Wed, Jul 17, 2024 at 10:54:40AM +0200, Frank Scheiner wrote:
>> fb3739759474d150a9927b920a80ea2afb4c2a51 (from mainline) should be
>> included in linux-4.19.y, if a589979f345720aca32ff43a2ccaa16a70871b9e
>> stays in.
>
> I do not know what commit a589979f345720aca32ff43a2ccaa16a70871b9e is,
> sorry. If you rea referring to commits in the -rc tree, please don't as
> that tree is rebased and regenerated all the time. In fact, my scripts
> don't even save a local copy when they are generated so I have no idea
> how to find this :(
I see. Makes sense.
> Please refer to the commit id in Linus's tree so I have a hint as to
> what is happening here.
Ok, will do in the future.
>> ****
>>
>> ## Long version ##
>>
>> It looks like:
>>
>> ```
>> hpet: Support 32-bit userspace
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?h=linux-4.19.y&id=a589979f345720aca32ff43a2ccaa16a70871b9e
>> ```
>
> Ah, you mean commit 4e60131d0d36 ("hpet: Support 32-bit userspace"),
> right?
Exactly.
> [...]
>> So fb3739759474d150a9927b920a80ea2afb4c2a51 should be included in
>> linux-4.19.y, too, if a589979f345720aca32ff43a2ccaa16a70871b9e stays in.
>
> Ok, I'll queue this one up as well, hopefully nothing else breaks...
+1
Cheers,
Frank
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 4.19 00/66] 4.19.318-rc1 review
2024-07-16 15:30 [PATCH 4.19 00/66] 4.19.318-rc1 review Greg Kroah-Hartman
` (2 preceding siblings ...)
2024-07-17 8:54 ` Frank Scheiner
@ 2024-07-17 15:57 ` Shuah Khan
3 siblings, 0 replies; 8+ messages in thread
From: Shuah Khan @ 2024-07-17 15:57 UTC (permalink / raw)
To: Greg Kroah-Hartman, stable
Cc: patches, linux-kernel, torvalds, akpm, linux, shuah, patches,
lkft-triage, pavel, jonathanh, f.fainelli, sudipm.mukherjee, srw,
rwarsow, conor, allen.lkml, broonie, Shuah Khan
On 7/16/24 09:30, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.19.318 release.
> There are 66 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 18 Jul 2024 15:27:21 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.318-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
>
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan <skhan@linuxfoundation.org>
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2024-07-17 15:57 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-16 15:30 [PATCH 4.19 00/66] 4.19.318-rc1 review Greg Kroah-Hartman
2024-07-16 20:11 ` Pavel Machek
2024-07-16 21:00 ` Naresh Kamboju
2024-07-17 6:21 ` Greg Kroah-Hartman
2024-07-17 8:54 ` Frank Scheiner
2024-07-17 9:30 ` Greg KH
2024-07-17 9:34 ` Frank Scheiner
2024-07-17 15:57 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox