RE: [EXTERNAL] Re: [PATCH rdma-next 1/1] RDMA/mana_ib: indicate that inline data is not supported

Konstantin Taranov
2024-07-16T17:25:27Z

>
> Yes, you are. If user asked for specific functionality (max_inline_data != 0) and
> your device doesn't support it, you should return an error.
>
> pvrdma, mlx4 and rvt are not good examples, they should return an error as
> well, but because of being legacy code, we won't change them.
>
> Thanks
>

I see. So I guess we can return a larger value, but not smaller. Right?
I will send v2 that fails QP creation then.

In this case, may I submit a patch to rdma-core that queries device caps before
trying to create a qp in rdma_client.c and rdma_server.c? As that code violates
what you described.

Thanks