From: Christoph Hellwig <hch@lst.de>
To: Leon Romanovsky <leon@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
Robin Murphy <robin.murphy@arm.com>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Leon Romanovsky <leonro@nvidia.com>,
Easwar Hariharan <eahariha@linux.microsoft.com>,
linux-kernel@vger.kernel.org, iommu@lists.linux.dev,
Jason Gunthorpe <jgg@nvidia.com>
Subject: Re: [PATCH v1 2/2] dma: Add IOMMU static calls with clear default ops
Date: Wed, 17 Jul 2024 10:21:45 +0200 [thread overview]
Message-ID: <20240717082145.GA15484@lst.de> (raw)
In-Reply-To: <7758cbe20bfd34506d943bb93097565b9c4dced4.1721041611.git.leon@kernel.org>
dma_is_default_iommu still looks a bit odd to me - basically we have
the ops structure just to say to bypass it. Why not add a single-bit
dma_iommu field to struct device next to dma_ops_bypass to skip it?
Then IOMMU_DMA also does not need to select DMA_OPS any more, which
would be kinda silly with the direct calls.
next prev parent reply other threads:[~2024-07-17 8:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-15 11:44 [PATCH v1 0/2] DMA IOMMU static calls Leon Romanovsky
2024-07-15 11:44 ` [PATCH v1 1/2] dma: call unconditionally to unmap_page and unmap_sg callbacks Leon Romanovsky
2024-07-15 11:44 ` [PATCH v1 2/2] dma: Add IOMMU static calls with clear default ops Leon Romanovsky
2024-07-17 8:21 ` Christoph Hellwig [this message]
2024-07-17 8:47 ` Leon Romanovsky
2024-07-17 8:56 ` Christoph Hellwig
2024-07-17 9:53 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240717082145.GA15484@lst.de \
--to=hch@lst.de \
--cc=eahariha@linux.microsoft.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@nvidia.com \
--cc=joro@8bytes.org \
--cc=leon@kernel.org \
--cc=leonro@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox