From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB2AE3A8D8 for ; Wed, 17 Jul 2024 08:35:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721205306; cv=none; b=WP568hMNvau8g4SY1B4LCtPkpnHeTI63CAJ7CVgDQ4M50Ut13dlDdCg2BXFeFVgonG/XBIrbRF/l91saI/h/1WfN5lzLY5zKiyZDw39Tu0PrmD9g0VlNU4iKeEsXoMMIY90VsHx7HIgQ4H0Db/G2aiM6coJ/DLZxFWFR5YE0GyU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721205306; c=relaxed/simple; bh=7yWT9wGZeLIqjFls1Qiq/gphKhA3MEBdNOj7oVHIg3Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=m4fI+beABKxT+alT5ioCSkpTbKGoMj6mtDTrzPJNaGCmSz2s0F3IUiif+jsi1ZBhhx4LfgELuSizIBtw6PdAX9s768/hV04khTrNTVm1iAHLPqIcfBAgBc2e6sOSu+G5nWqH5kNYm0CVg9W4/TRVIiQRmK3HGEpNa85EccJocEg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=bigItTj5; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bigItTj5" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-1fc566ac769so19395ad.1 for ; Wed, 17 Jul 2024 01:35:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721205304; x=1721810104; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=mNkMLlzIh0FRUMrqsEmjaMD7DKmMc/WtpJCzEXhD76s=; b=bigItTj51EMhBldwnwgIA/LvPmUqdzn3f2dkoW026ssQPtOp4obtCgW0tIilMgcsQN 6TOpZHPyyI2PyyE1nBXBoj7ZmiJLdUFprO3J1d8MDgaNTITKyF8r4d14GP02IAmTzEWu 7wGjkm8z5RLX9UWhclvPYvdwB8MqFeMlKl6d3GmvbY3WGsbHs0J1KNjS9/KIys2B3kTW NPjxrSOtIvPW3mfgZP5kjovYjPg2dpIN5A0x7uBWf6G5nTSdWJm/013uO8mv8Af4qTVc 36CmRXVNDpKoIwa1J2JrtofnT7PAEdO1xnqHv2UPBGMFWYnfDUB3/4iGDO30C8rxyCad DwBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721205304; x=1721810104; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mNkMLlzIh0FRUMrqsEmjaMD7DKmMc/WtpJCzEXhD76s=; b=Y5VQJKFa8DPJG0CIiJlpW47ub2idrUE4kcKva+Hb8Jdc+DoxPoebN0R9e5AqSYRFbh HzV5HLFIcHD+k6XUa3KnPIh52nuhxFml+Rp8rFSfUm5obixGlXj1PoNXQvENtIQXu6y1 rzs4SiBLrzFPd8vZk7MxBEa6c9EY68IqrM/Xhzz5bHNerikToXtputqO2G8/EibgVMu/ kXKsDxxKZoDKc+iZsjP84TSaIzzUO1O6NVjhJw9Vt//u6LuSBDmtJHGnXnXMk1gF/MzP stWeSsFoJtLBY2SaANlgN3EuYtke+PLV98NsM0G4Jr1paQXnCNBkbG20u3qzRm3x5lI9 raUQ== X-Forwarded-Encrypted: i=1; AJvYcCUAtXVyYZx7E//xQBeu0SFjbYJfOYBunwPURUsE2y0ilvTqcmMglNP4FVHB0WUUFgYcvT50OMwErQtScwS+ef3P+W1Iyz8G8A2iFNpQ X-Gm-Message-State: AOJu0Yyx3/KxDE5pSccq5PskxPYaKxcemgCkjsc4n4e2eOsYMOzgLzin esC0QIR4bqzGc/l359Zj7VRdlzGjCv7/g7TS3Etyb3vC9pAADtTbbHUKW78AHA== X-Google-Smtp-Source: AGHT+IGl2IJMzGLyoVjbWN3voJb+DI9d1XbG0jgZwcz3Yoiew4Ex5l2yrPzMBWFdANacOw+Nwc0rgw== X-Received: by 2002:a17:902:ce8f:b0:1fb:cf82:11b4 with SMTP id d9443c01a7336-1fc4e13590amr8333135ad.6.1721205304162; Wed, 17 Jul 2024 01:35:04 -0700 (PDT) Received: from thinkpad ([220.158.156.207]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fc0bbc25d2sm70270675ad.100.2024.07.17.01.34.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jul 2024 01:35:02 -0700 (PDT) Date: Wed, 17 Jul 2024 14:04:58 +0530 From: Manivannan Sadhasivam To: Mrinmay Sarkar Cc: fancer.lancer@gmail.com, vkoul@kernel.org, quic_shazhuss@quicinc.com, quic_nitegupt@quicinc.com, quic_ramkri@quicinc.com, quic_nayiluri@quicinc.com, quic_krichai@quicinc.com, quic_vbadigan@quicinc.com, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 2/2] dmaengine: dw-edma: Add change to remove watermark interrupt enablement Message-ID: <20240717083458.GC2574@thinkpad> References: <1720187733-5380-1-git-send-email-quic_msarkar@quicinc.com> <1720187733-5380-3-git-send-email-quic_msarkar@quicinc.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1720187733-5380-3-git-send-email-quic_msarkar@quicinc.com> On Fri, Jul 05, 2024 at 07:25:33PM +0530, Mrinmay Sarkar wrote: Subject should be: dmaengine: dw-edma: Do not enable watermark interrupts for HDMA > DW_HDMA_V0_LIE and DW_HDMA_V0_RIE are initialized as BIT(3) and BIT(4) > respectively in dw_hdma_control enum. But as per HDMA register these > bits are corresponds to LWIE and RWIE bit i.e local watermark interrupt > enable and remote watermarek interrupt enable. In linked list mode LWIE > and RWIE bits only enable the local and remote watermark interrupt. > I guess you should also rename DW_HDMA_V0_LIE -> DW_HDMA_V0_LWIE and DW_HDMA_V0_RIE -> DW_HDMA_V0_RWIE in the code, unless the register name changes with mode. > As we are not handling watermark interruprt so removing watermark > interrupt enablement logic to avoid unnecessary watermark interrupt > event. > How about, "Since the watermark interrupts are not used but enabled, this leads to spurious interrupts getting generated. So remove the code that enables them to avoid generating spurious watermark interrupts." > Signed-off-by: Mrinmay Sarkar Again, please include Fixes tag and CC stable. > --- > drivers/dma/dw-edma/dw-hdma-v0-core.c | 12 +----------- > 1 file changed, 1 insertion(+), 11 deletions(-) > > diff --git a/drivers/dma/dw-edma/dw-hdma-v0-core.c b/drivers/dma/dw-edma/dw-hdma-v0-core.c > index 88bd652f..aaf2e27 100644 > --- a/drivers/dma/dw-edma/dw-hdma-v0-core.c > +++ b/drivers/dma/dw-edma/dw-hdma-v0-core.c > @@ -197,23 +197,13 @@ static void dw_hdma_v0_core_write_chunk(struct dw_edma_chunk *chunk) > struct dw_edma_burst *child; > struct dw_edma_chan *chan = chunk->chan; This becomes unused as reported by bot. - Mani -- மணிவண்ணன் சதாசிவம்