From: "Michael Büsch" <m@bues.ch>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Kalle Valo <kvalo@kernel.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org
Subject: Re: [PATCH] wifi: b43: Constify struct lpphy_tx_gain_table_entry
Date: Wed, 17 Jul 2024 19:57:43 +0200 [thread overview]
Message-ID: <20240717195743.31bdb01d@barney> (raw)
In-Reply-To: <38528f48c8069187823b774a6b2a53088f6c9599.1721161231.git.christophe.jaillet@wanadoo.fr>
[-- Attachment #1: Type: text/plain, Size: 1196 bytes --]
On Tue, 16 Jul 2024 22:21:13 +0200
Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
> static void lpphy_rev0_1_write_gain_table(struct b43_wldev *dev, int offset,
> - struct lpphy_tx_gain_table_entry data)
> + const struct lpphy_tx_gain_table_entry data)
> {
> u32 tmp;
>
> @@ -2356,7 +2356,7 @@ static void lpphy_rev0_1_write_gain_table(struct b43_wldev *dev, int offset,
> }
>
> static void lpphy_rev2plus_write_gain_table(struct b43_wldev *dev, int offset,
> - struct lpphy_tx_gain_table_entry data)
> + const struct lpphy_tx_gain_table_entry data)
> {
> u32 tmp;
>
> @@ -2383,7 +2383,7 @@ static void lpphy_rev2plus_write_gain_table(struct b43_wldev *dev, int offset,
> }
>
> void lpphy_write_gain_table(struct b43_wldev *dev, int offset,
> - struct lpphy_tx_gain_table_entry data)
> + const struct lpphy_tx_gain_table_entry data)
> {
> if (dev->phy.rev >= 2)
> lpphy_rev2plus_write_gain_table(dev, offset, data);
> @@ -2392,7 +2392,7 @@ void lpphy_write_gain_table(struct b43_wldev *dev, int offset,
> }
These three changes look like they are not necessary.
--
Michael Büsch
https://bues.ch/
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-07-17 18:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-16 20:21 [PATCH] wifi: b43: Constify struct lpphy_tx_gain_table_entry Christophe JAILLET
2024-07-17 17:57 ` Michael Büsch [this message]
2024-08-04 6:27 ` Christophe JAILLET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240717195743.31bdb01d@barney \
--to=m@bues.ch \
--cc=b43-dev@lists.infradead.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox