From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2525C187325 for ; Wed, 17 Jul 2024 21:28:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721251729; cv=none; b=D/DzFpsLS3RPMwTfh9hdfoW3ssapOKgZEeYWsq4+TYGbJXr6/A9+a8GoYahUVCUjRNsjNpYxlBiTQGVKNyKqdK7tWh+GV+h10ztCtJgIXO3TilXIIUGH8y4sjwCE+Wk8Tk6aZajiolriGlsqrYWZ84NbwXG6re0ixdhTGjI6l7U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721251729; c=relaxed/simple; bh=hV+gOr49p4cocawq3YpFNMPhdSPOJ5ilUmbodlA9FZI=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=lRCubD1aWoddVIzbh5B1sQRz8VvjFdbgX2NaAue00dF74AOqV3MfufDXdCLGX2mHPKIzygRs8YiLgBujFzDc9lFqfOrfpdzH4+tFT5j29ZlmqAygg5HD+PAbV2lvv9v9vWQ+gE5mDK12j1ybU4Uk2GdjmyKPs0NdB2Ro4lYxDIg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--surenb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=v/WPp6RX; arc=none smtp.client-ip=209.85.128.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--surenb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="v/WPp6RX" Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-650fccfd1dfso2323857b3.0 for ; Wed, 17 Jul 2024 14:28:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1721251727; x=1721856527; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=bC1XYrE8D3FwqV+dReridNcLxNzpjkdxcOvL08MCL8A=; b=v/WPp6RXzAb8dRyANuKl13dRDZngyeiUccrWtTRzYSafen0oQTzdAP2TAAdXHXOnbS RidsXLjc3yjIJ+i9RQD2G/FRq/lDHZzlsbOfswiZAaZQy1Jtu7huWxdGocTV8N7BalFx UlNXtXLilp+PIavXdrr0S9dnP5Uz4TRbPVK0PUVhzU7ZB9wiR7USzuWYNYk/03la0F12 PBWQ0IV2EVZ/dWgnHFNFEntNTm+ya7FdyScyQv/uXPkpWQ2D5UquT6BUde9jHVNirotJ xIs48WHmKZomzs4pQgrLW1cZl847sb1fw5izjaGZ4v7eQBLZ5lwVOD39+leZlastEwgO UaGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721251727; x=1721856527; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=bC1XYrE8D3FwqV+dReridNcLxNzpjkdxcOvL08MCL8A=; b=cPBDptkWHiFvTCO3nAc0+UMi3C5qT2qCx6K3bkzf0jOnIG0hvEttg4YDvvk58DbfJI s8vUoTtmeZZ8rkkG3NRUm7BfdTlfgF9qSc6XAdMQNfL3CDP0nZaxYLccnEG/d0KIoc1Q 5x4hWHmQ94J6akaYzrAi5+Uhyr0RmGptavitpIoIVbX7ly2T28ll66SyKkMSf7DCbWeR PjQVTs3d6WIvlv0GGYExmSqPUBx2cUIbcoO6KHSk+8Ctn2zZ2VYF5AOppbwWivVF/PKt +1PxYxxMh3oKh5qtER6We/lSfFSTwRlvn1fFtNZPTK8X570NsFV1EA/TqxKFfqmDaFjR /fGg== X-Forwarded-Encrypted: i=1; AJvYcCU2Jc/YmPts7bAkJwu8YtIZhjF00dNTJ7MB9iqI6YRTvukCyaMxOmYOzAnIh/9piN8fcNsfGtrRdWjLAtLWc1gcB2nXPlu1VuaUSrzm X-Gm-Message-State: AOJu0Yyzzk24QCy+TW8Vo/ZqE4TWVM5JQxvTWtURUubTgUp/BSCk5k+T f1Z3IRQ4xnnkvLFYDISnGU4y2YcgrJMoCmP57ChT8ENqklEV3nUoco1GTo1GqbCGFG3GwVOYCw9 NmA== X-Google-Smtp-Source: AGHT+IFLgB2C6j0dFHpvLIU7N8gDZUpXVn/57H01SUptIZ7LA4eVWYxCTx/3TCCmKxlLkZBSM9SJzGCH+/E= X-Received: from surenb-desktop.mtv.corp.google.com ([2620:15c:211:201:f44b:e467:5c7c:74ab]) (user=surenb job=sendgmr) by 2002:a05:690c:d8d:b0:62f:f535:f2c with SMTP id 00721157ae682-6660248e324mr151227b3.2.1721251727081; Wed, 17 Jul 2024 14:28:47 -0700 (PDT) Date: Wed, 17 Jul 2024 14:28:44 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.45.2.993.g49e7a77208-goog Message-ID: <20240717212844.2749975-1-surenb@google.com> Subject: [PATCH v3 1/1] alloc_tag: outline and export free_reserved_page() From: Suren Baghdasaryan To: akpm@linux-foundation.org Cc: kent.overstreet@linux.dev, hch@infradead.org, vbabka@suse.cz, pasha.tatashin@soleen.com, souravpanda@google.com, keescook@chromium.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, surenb@google.com, kernel test robot , stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Outline and export free_reserved_page() because modules use it and it in turn uses page_ext_{get|put} which should not be exported. The same result could be obtained by outlining {get|put}_page_tag_ref() but that would have higher performance impact as these functions are used in more performance critical paths. Fixes: dcfe378c81f7 ("lib: introduce support for page allocation tagging") Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202407080044.DWMC9N9I-lkp@intel.com/ Suggested-by: Christoph Hellwig Suggested-by: Vlastimil Babka Signed-off-by: Suren Baghdasaryan Acked-by: Vlastimil Babka Cc: stable@vger.kernel.org # v6.10 --- Changes since v2 [1] - Dropped the first unnecessary patch from the patchset, per Vlastimil Babka - Added Acked-by, per Vlastimil Babka - CC'ed stable@, per Vlastimil Babka [1] https://lore.kernel.org/all/20240717181239.2510054-1-surenb@google.com/ include/linux/mm.h | 16 +--------------- mm/page_alloc.c | 17 +++++++++++++++++ 2 files changed, 18 insertions(+), 15 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index eb7c96d24ac0..b58bad248eef 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -3177,21 +3177,7 @@ extern void reserve_bootmem_region(phys_addr_t start, phys_addr_t end, int nid); /* Free the reserved page into the buddy system, so it gets managed. */ -static inline void free_reserved_page(struct page *page) -{ - if (mem_alloc_profiling_enabled()) { - union codetag_ref *ref = get_page_tag_ref(page); - - if (ref) { - set_codetag_empty(ref); - put_page_tag_ref(ref); - } - } - ClearPageReserved(page); - init_page_count(page); - __free_page(page); - adjust_managed_page_count(page, 1); -} +void free_reserved_page(struct page *page); #define free_highmem_page(page) free_reserved_page(page) static inline void mark_page_reserved(struct page *page) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 9ecf99190ea2..7d2fa9f5e750 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -5805,6 +5805,23 @@ unsigned long free_reserved_area(void *start, void *end, int poison, const char return pages; } +void free_reserved_page(struct page *page) +{ + if (mem_alloc_profiling_enabled()) { + union codetag_ref *ref = get_page_tag_ref(page); + + if (ref) { + set_codetag_empty(ref); + put_page_tag_ref(ref); + } + } + ClearPageReserved(page); + init_page_count(page); + __free_page(page); + adjust_managed_page_count(page, 1); +} +EXPORT_SYMBOL(free_reserved_page); + static int page_alloc_cpu_dead(unsigned int cpu) { struct zone *zone; base-commit: e2f710f97f3544df08ebe608c8157536e0ffb494 -- 2.45.2.993.g49e7a77208-goog