* Re: [PATCH 4.19 00/66] 4.19.318-rc1 review
2024-07-16 15:30 [PATCH 4.19 00/66] 4.19.318-rc1 review Greg Kroah-Hartman
@ 2024-07-16 20:11 ` Pavel Machek
2024-07-16 21:00 ` Naresh Kamboju
` (2 subsequent siblings)
3 siblings, 0 replies; 8+ messages in thread
From: Pavel Machek @ 2024-07-16 20:11 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml, broonie
[-- Attachment #1: Type: text/plain, Size: 661 bytes --]
Hi!
> This is the start of the stable review cycle for the 4.19.318 release.
> There are 66 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
CIP testing did not find any problems here:
https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-4.19.y
Tested-by: Pavel Machek (CIP) <pavel@denx.de>
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 4.19 00/66] 4.19.318-rc1 review
2024-07-16 15:30 [PATCH 4.19 00/66] 4.19.318-rc1 review Greg Kroah-Hartman
2024-07-16 20:11 ` Pavel Machek
@ 2024-07-16 21:00 ` Naresh Kamboju
2024-07-17 6:21 ` Greg Kroah-Hartman
2024-07-17 8:54 ` Frank Scheiner
2024-07-17 15:57 ` Shuah Khan
3 siblings, 1 reply; 8+ messages in thread
From: Naresh Kamboju @ 2024-07-16 21:00 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml, broonie
On Tue, 16 Jul 2024 at 21:04, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> This is the start of the stable review cycle for the 4.19.318 release.
> There are 66 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 18 Jul 2024 15:27:21 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.318-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
The 390 builds failed on 6.6, 6.1, 5.15, 5.10, 5.4 and 4.19
* s390, build
- clang-18-allnoconfig
- clang-18-defconfig
- clang-18-tinyconfig
- clang-nightly-allnoconfig
- clang-nightly-defconfig
- clang-nightly-tinyconfig
- gcc-12-allnoconfig
- gcc-12-defconfig
- gcc-12-tinyconfig
- gcc-8-allnoconfig
- gcc-8-defconfig-fe40093d
- gcc-8-tinyconfig
Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
Build log:
-------
arch/s390/include/asm/processor.h: In function '__load_psw_mask':
arch/s390/include/asm/processor.h:292:19: error: expected '=', ',',
';', 'asm' or '__attribute__' before '__uninitialized'
292 | psw_t psw __uninitialized;
| ^~~~~~~~~~~~~~~
arch/s390/include/asm/processor.h:292:19: error: '__uninitialized'
undeclared (first use in this function); did you mean
'uninitialized_var'?
292 | psw_t psw __uninitialized;
| ^~~~~~~~~~~~~~~
| uninitialized_var
arch/s390/include/asm/processor.h:292:19: note: each undeclared
identifier is reported only once for each function it appears in
arch/s390/include/asm/processor.h:293:9: warning: ISO C90 forbids
mixed declarations and code [-Wdeclaration-after-statement]
293 | unsigned long addr;
| ^~~~~~~~
arch/s390/include/asm/processor.h:295:9: error: 'psw' undeclared
(first use in this function); did you mean 'psw_t'?
295 | psw.mask = mask;
| ^~~
| psw_t
Steps to reproduce:
----------
# tuxmake --runtime podman --target-arch s390 --toolchain gcc-12
--kconfig tinyconfig
--
Linaro LKFT
https://lkft.linaro.org
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 4.19 00/66] 4.19.318-rc1 review
2024-07-16 21:00 ` Naresh Kamboju
@ 2024-07-17 6:21 ` Greg Kroah-Hartman
0 siblings, 0 replies; 8+ messages in thread
From: Greg Kroah-Hartman @ 2024-07-17 6:21 UTC (permalink / raw)
To: Naresh Kamboju
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml, broonie
On Wed, Jul 17, 2024 at 02:30:54AM +0530, Naresh Kamboju wrote:
> On Tue, 16 Jul 2024 at 21:04, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > This is the start of the stable review cycle for the 4.19.318 release.
> > There are 66 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Thu, 18 Jul 2024 15:27:21 +0000.
> > Anything received after that time might be too late.
> >
> > The whole patch series can be found in one patch at:
> > https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.318-rc1.gz
> > or in the git tree and branch at:
> > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> > and the diffstat can be found below.
> >
> > thanks,
> >
> > greg k-h
>
>
> The 390 builds failed on 6.6, 6.1, 5.15, 5.10, 5.4 and 4.19
>
>
> * s390, build
> - clang-18-allnoconfig
> - clang-18-defconfig
> - clang-18-tinyconfig
> - clang-nightly-allnoconfig
> - clang-nightly-defconfig
> - clang-nightly-tinyconfig
> - gcc-12-allnoconfig
> - gcc-12-defconfig
> - gcc-12-tinyconfig
> - gcc-8-allnoconfig
> - gcc-8-defconfig-fe40093d
> - gcc-8-tinyconfig
>
>
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
>
> Build log:
> -------
> arch/s390/include/asm/processor.h: In function '__load_psw_mask':
> arch/s390/include/asm/processor.h:292:19: error: expected '=', ',',
> ';', 'asm' or '__attribute__' before '__uninitialized'
> 292 | psw_t psw __uninitialized;
> | ^~~~~~~~~~~~~~~
> arch/s390/include/asm/processor.h:292:19: error: '__uninitialized'
> undeclared (first use in this function); did you mean
> 'uninitialized_var'?
> 292 | psw_t psw __uninitialized;
> | ^~~~~~~~~~~~~~~
> | uninitialized_var
> arch/s390/include/asm/processor.h:292:19: note: each undeclared
> identifier is reported only once for each function it appears in
> arch/s390/include/asm/processor.h:293:9: warning: ISO C90 forbids
> mixed declarations and code [-Wdeclaration-after-statement]
> 293 | unsigned long addr;
> | ^~~~~~~~
> arch/s390/include/asm/processor.h:295:9: error: 'psw' undeclared
> (first use in this function); did you mean 'psw_t'?
> 295 | psw.mask = mask;
> | ^~~
> | psw_t
>
> Steps to reproduce:
> ----------
> # tuxmake --runtime podman --target-arch s390 --toolchain gcc-12
> --kconfig tinyconfig
Offending commit now dropped.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 4.19 00/66] 4.19.318-rc1 review
2024-07-16 15:30 [PATCH 4.19 00/66] 4.19.318-rc1 review Greg Kroah-Hartman
2024-07-16 20:11 ` Pavel Machek
2024-07-16 21:00 ` Naresh Kamboju
@ 2024-07-17 8:54 ` Frank Scheiner
2024-07-17 9:30 ` Greg KH
2024-07-17 15:57 ` Shuah Khan
3 siblings, 1 reply; 8+ messages in thread
From: Frank Scheiner @ 2024-07-17 8:54 UTC (permalink / raw)
To: gregkh
Cc: akpm, allen.lkml, broonie, conor, f.fainelli, jonathanh,
linux-kernel, linux, lkft-triage, patches, patches, pavel,
rwarsow, shuah, srw, stable, sudipm.mukherjee, torvalds,
Tomáš Glozar
Hi there,
fb3739759474d150a9927b920a80ea2afb4c2a51 (from mainline) should be
included in linux-4.19.y, if a589979f345720aca32ff43a2ccaa16a70871b9e
stays in.
****
## Long version ##
It looks like:
```
hpet: Support 32-bit userspace
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?h=linux-4.19.y&id=a589979f345720aca32ff43a2ccaa16a70871b9e
```
...breaks the non-HP-Sim ia64 build ([1]) for us since yesterday:
```
[...]
drivers/char/hpet.c: In function 'hpet_read':
drivers/char/hpet.c:311:36: error: 'compat_ulong_t' undeclared (first
use in this function)
311 | if (count < sizeof(compat_ulong_t))
| ^~~~~~~~~~~~~~
drivers/char/hpet.c:311:36: note: each undeclared identifier is reported
only once for each function it appears in
[...]
```
...as it uses a type not known to ia64 (and possibly other
architectures) w/o also including:
```
asm-generic: Move common compat types to asm-generic/compat.h
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=fb3739759474d150a9927b920a80ea2afb4c2a51
```
The latter seems to be in mainline only since v4.20-rc1 and fixes the
non-HP-Sim ia64 build ([2]) for me.
So fb3739759474d150a9927b920a80ea2afb4c2a51 should be included in
linux-4.19.y, too, if a589979f345720aca32ff43a2ccaa16a70871b9e stays in.
[1]:
https://github.com/linux-ia64/linux-stable-rc/actions/runs/9947642032#summary-27481009307
[2]:
https://github.com/linux-ia64/linux-stable-rc/actions/runs/9970651775#summary-27550542084
Cheers,
Frank
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 4.19 00/66] 4.19.318-rc1 review
2024-07-17 8:54 ` Frank Scheiner
@ 2024-07-17 9:30 ` Greg KH
2024-07-17 9:34 ` Frank Scheiner
0 siblings, 1 reply; 8+ messages in thread
From: Greg KH @ 2024-07-17 9:30 UTC (permalink / raw)
To: Frank Scheiner
Cc: akpm, allen.lkml, broonie, conor, f.fainelli, jonathanh,
linux-kernel, linux, lkft-triage, patches, patches, pavel,
rwarsow, shuah, srw, stable, sudipm.mukherjee, torvalds,
Tomáš Glozar
On Wed, Jul 17, 2024 at 10:54:40AM +0200, Frank Scheiner wrote:
> Hi there,
>
> fb3739759474d150a9927b920a80ea2afb4c2a51 (from mainline) should be
> included in linux-4.19.y, if a589979f345720aca32ff43a2ccaa16a70871b9e
> stays in.
I do not know what commit a589979f345720aca32ff43a2ccaa16a70871b9e is,
sorry. If you rea referring to commits in the -rc tree, please don't as
that tree is rebased and regenerated all the time. In fact, my scripts
don't even save a local copy when they are generated so I have no idea
how to find this :(
Please refer to the commit id in Linus's tree so I have a hint as to
what is happening here.
> ****
>
> ## Long version ##
>
> It looks like:
>
> ```
> hpet: Support 32-bit userspace
>
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?h=linux-4.19.y&id=a589979f345720aca32ff43a2ccaa16a70871b9e
> ```
Ah, you mean commit 4e60131d0d36 ("hpet: Support 32-bit userspace"),
right?
> ...breaks the non-HP-Sim ia64 build ([1]) for us since yesterday:
>
> ```
> [...]
> drivers/char/hpet.c: In function 'hpet_read':
> drivers/char/hpet.c:311:36: error: 'compat_ulong_t' undeclared (first
> use in this function)
> 311 | if (count < sizeof(compat_ulong_t))
> | ^~~~~~~~~~~~~~
> drivers/char/hpet.c:311:36: note: each undeclared identifier is reported
> only once for each function it appears in
> [...]
> ```
>
> ...as it uses a type not known to ia64 (and possibly other
> architectures) w/o also including:
>
> ```
> asm-generic: Move common compat types to asm-generic/compat.h
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=fb3739759474d150a9927b920a80ea2afb4c2a51
> ```
>
> The latter seems to be in mainline only since v4.20-rc1 and fixes the
> non-HP-Sim ia64 build ([2]) for me.
>
> So fb3739759474d150a9927b920a80ea2afb4c2a51 should be included in
> linux-4.19.y, too, if a589979f345720aca32ff43a2ccaa16a70871b9e stays in.
Ok, I'll queue this one up as well, hopefully nothing else breaks...
thanks,
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 4.19 00/66] 4.19.318-rc1 review
2024-07-17 9:30 ` Greg KH
@ 2024-07-17 9:34 ` Frank Scheiner
0 siblings, 0 replies; 8+ messages in thread
From: Frank Scheiner @ 2024-07-17 9:34 UTC (permalink / raw)
To: Greg KH
Cc: akpm, allen.lkml, broonie, conor, f.fainelli, jonathanh,
linux-kernel, linux, lkft-triage, patches, patches, pavel,
rwarsow, shuah, srw, stable, sudipm.mukherjee, torvalds,
Tomáš Glozar
On 17.07.24 11:30, Greg KH wrote:
> On Wed, Jul 17, 2024 at 10:54:40AM +0200, Frank Scheiner wrote:
>> fb3739759474d150a9927b920a80ea2afb4c2a51 (from mainline) should be
>> included in linux-4.19.y, if a589979f345720aca32ff43a2ccaa16a70871b9e
>> stays in.
>
> I do not know what commit a589979f345720aca32ff43a2ccaa16a70871b9e is,
> sorry. If you rea referring to commits in the -rc tree, please don't as
> that tree is rebased and regenerated all the time. In fact, my scripts
> don't even save a local copy when they are generated so I have no idea
> how to find this :(
I see. Makes sense.
> Please refer to the commit id in Linus's tree so I have a hint as to
> what is happening here.
Ok, will do in the future.
>> ****
>>
>> ## Long version ##
>>
>> It looks like:
>>
>> ```
>> hpet: Support 32-bit userspace
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?h=linux-4.19.y&id=a589979f345720aca32ff43a2ccaa16a70871b9e
>> ```
>
> Ah, you mean commit 4e60131d0d36 ("hpet: Support 32-bit userspace"),
> right?
Exactly.
> [...]
>> So fb3739759474d150a9927b920a80ea2afb4c2a51 should be included in
>> linux-4.19.y, too, if a589979f345720aca32ff43a2ccaa16a70871b9e stays in.
>
> Ok, I'll queue this one up as well, hopefully nothing else breaks...
+1
Cheers,
Frank
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 4.19 00/66] 4.19.318-rc1 review
2024-07-16 15:30 [PATCH 4.19 00/66] 4.19.318-rc1 review Greg Kroah-Hartman
` (2 preceding siblings ...)
2024-07-17 8:54 ` Frank Scheiner
@ 2024-07-17 15:57 ` Shuah Khan
3 siblings, 0 replies; 8+ messages in thread
From: Shuah Khan @ 2024-07-17 15:57 UTC (permalink / raw)
To: Greg Kroah-Hartman, stable
Cc: patches, linux-kernel, torvalds, akpm, linux, shuah, patches,
lkft-triage, pavel, jonathanh, f.fainelli, sudipm.mukherjee, srw,
rwarsow, conor, allen.lkml, broonie, Shuah Khan
On 7/16/24 09:30, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.19.318 release.
> There are 66 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 18 Jul 2024 15:27:21 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.318-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
>
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan <skhan@linuxfoundation.org>
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 8+ messages in thread