Re: [PATCH 4.19 00/66] 4.19.318-rc1 review

Frank Scheiner
2024-07-17T08:55:12Z

Hi there,

fb3739759474d150a9927b920a80ea2afb4c2a51 (from mainline) should be
included in linux-4.19.y, if a589979f345720aca32ff43a2ccaa16a70871b9e
stays in.

****

## Long version ##

It looks like:

```
hpet: Support 32-bit userspace

https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?h=linux-4.19.y&id=a589979f345720aca32ff43a2ccaa16a70871b9e
```

...breaks the non-HP-Sim ia64 build ([1]) for us since yesterday:

```
[...]
drivers/char/hpet.c: In function 'hpet_read':
drivers/char/hpet.c:311:36: error: 'compat_ulong_t' undeclared (first
use in this function)
311 | if (count < sizeof(compat_ulong_t))
| ^~~~~~~~~~~~~~
drivers/char/hpet.c:311:36: note: each undeclared identifier is reported
only once for each function it appears in
[...]
```

...as it uses a type not known to ia64 (and possibly other
architectures) w/o also including:

```
asm-generic: Move common compat types to asm-generic/compat.h

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=fb3739759474d150a9927b920a80ea2afb4c2a51
```

The latter seems to be in mainline only since v4.20-rc1 and fixes the
non-HP-Sim ia64 build ([2]) for me.

So fb3739759474d150a9927b920a80ea2afb4c2a51 should be included in
linux-4.19.y, too, if a589979f345720aca32ff43a2ccaa16a70871b9e stays in.

[1]:
https://github.com/linux-ia64/linux-stable-rc/actions/runs/9947642032#summary-27481009307

[2]:
https://github.com/linux-ia64/linux-stable-rc/actions/runs/9970651775#summary-27550542084

Cheers,
Frank