* [PATCH] drm/omap: add CONFIG_MMU dependency
@ 2024-07-19 9:59 Arnd Bergmann
2024-08-05 12:54 ` Tomi Valkeinen
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2024-07-19 9:59 UTC (permalink / raw)
To: Tomi Valkeinen, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Daniel Vetter,
Ville Syrjälä
Cc: Arnd Bergmann, Nathan Chancellor, Helge Deller, Tony Lindgren,
dri-devel, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Compile-testing with CONFIG_MMU disabled causes a link error in omapdrm:
arm-linux-gnueabi-ld: drivers/gpu/drm/omapdrm/omap_gem.o: in function `omap_gem_fault_2d':
omap_gem.c:(.text+0x36e): undefined reference to `vmf_insert_mixed'
arm-linux-gnueabi-ld: drivers/gpu/drm/omapdrm/omap_gem.o: in function `omap_gem_fault':
omap_gem.c:(.text+0x74a): undefined reference to `vmf_insert_mixed'
Avoid this by adding a Kconfig dependency.
Fixes: dc6fcaaba5a5 ("drm/omap: Allow build with COMPILE_TEST=y")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpu/drm/omapdrm/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/omapdrm/Kconfig b/drivers/gpu/drm/omapdrm/Kconfig
index 3f7139e211d2..64e440a2649b 100644
--- a/drivers/gpu/drm/omapdrm/Kconfig
+++ b/drivers/gpu/drm/omapdrm/Kconfig
@@ -1,6 +1,7 @@
# SPDX-License-Identifier: GPL-2.0-only
config DRM_OMAP
tristate "OMAP DRM"
+ depends on MMU
depends on DRM && OF
depends on ARCH_OMAP2PLUS || (COMPILE_TEST && PAGE_SIZE_LESS_THAN_64KB)
select DRM_KMS_HELPER
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] drm/omap: add CONFIG_MMU dependency
2024-07-19 9:59 [PATCH] drm/omap: add CONFIG_MMU dependency Arnd Bergmann
@ 2024-08-05 12:54 ` Tomi Valkeinen
0 siblings, 0 replies; 2+ messages in thread
From: Tomi Valkeinen @ 2024-08-05 12:54 UTC (permalink / raw)
To: Arnd Bergmann, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Daniel Vetter,
Ville Syrjälä
Cc: Arnd Bergmann, Nathan Chancellor, Helge Deller, Tony Lindgren,
dri-devel, linux-kernel
Hi,
On 19/07/2024 12:59, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Compile-testing with CONFIG_MMU disabled causes a link error in omapdrm:
>
> arm-linux-gnueabi-ld: drivers/gpu/drm/omapdrm/omap_gem.o: in function `omap_gem_fault_2d':
> omap_gem.c:(.text+0x36e): undefined reference to `vmf_insert_mixed'
> arm-linux-gnueabi-ld: drivers/gpu/drm/omapdrm/omap_gem.o: in function `omap_gem_fault':
> omap_gem.c:(.text+0x74a): undefined reference to `vmf_insert_mixed'
>
> Avoid this by adding a Kconfig dependency.
>
> Fixes: dc6fcaaba5a5 ("drm/omap: Allow build with COMPILE_TEST=y")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks, applying to drm-misc-fixes.
Tomi
> ---
> drivers/gpu/drm/omapdrm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/omapdrm/Kconfig b/drivers/gpu/drm/omapdrm/Kconfig
> index 3f7139e211d2..64e440a2649b 100644
> --- a/drivers/gpu/drm/omapdrm/Kconfig
> +++ b/drivers/gpu/drm/omapdrm/Kconfig
> @@ -1,6 +1,7 @@
> # SPDX-License-Identifier: GPL-2.0-only
> config DRM_OMAP
> tristate "OMAP DRM"
> + depends on MMU
> depends on DRM && OF
> depends on ARCH_OMAP2PLUS || (COMPILE_TEST && PAGE_SIZE_LESS_THAN_64KB)
> select DRM_KMS_HELPER
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-05 12:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-19 9:59 [PATCH] drm/omap: add CONFIG_MMU dependency Arnd Bergmann
2024-08-05 12:54 ` Tomi Valkeinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox