From: Kees Cook <kees@kernel.org>
To: Jinjie Ruan <ruanjinjie@huawei.com>
Cc: chenhuacai@kernel.org, kernel@xen0n.name, gustavoars@kernel.org,
arnd@arndb.de, maobibo@loongson.cn, loongarch@lists.linux.dev,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH v2] loongarch: Support RANDOMIZE_KSTACK_OFFSET
Date: Sat, 20 Jul 2024 09:42:18 -0700 [thread overview]
Message-ID: <202407200940.ABE5F65@keescook> (raw)
In-Reply-To: <a654c7e2-929c-cbeb-cfd5-b8bbb00845d2@huawei.com>
On Sat, Jul 20, 2024 at 10:52:06AM +0800, Jinjie Ruan wrote:
>
>
> On 2024/7/20 0:01, Kees Cook wrote:
> > On Fri, Jul 19, 2024 at 11:14:27AM +0800, Jinjie Ruan wrote:
> >> Add support of kernel stack offset randomization while handling syscall,
> >> the offset is defaultly limited by KSTACK_OFFSET_MAX().
> >>
> >> In order to avoid trigger stack canaries (due to __builtin_alloca) and
> >> slowing down the entry path, use __no_stack_protector attribute to
> >> disable stack protector for do_syscall() at function level.
> >>
> >> With this patch, the REPORT_STACK test show that:
> >> `loongarch64 bits of stack entropy: 7`
> >
> > I suspect this will report the correct "6" after now that this commit
> > has landed:
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=872bb37f6829d4f7f3ed5afe2786add3d4384b4b
>
> Hi, Kees
>
> I noticed your patch, and I reconfirm that I have updated to the latest
> mainline and that your patch is in the code.
>
> However，the following REPORT_STACK test of your below script has the
> same result (run multiple times).
>
> And riscv64, arm64, x86 also has the 7 bit of stack entropy.
Okay, thanks for checking! I may go take a closer look if I have time.
It'd only be a problem if the distribution isn't sufficiently even.
-Kees
--
Kees Cook
prev parent reply other threads:[~2024-07-20 16:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-19 3:14 [PATCH v2] loongarch: Support RANDOMIZE_KSTACK_OFFSET Jinjie Ruan
2024-07-19 6:45 ` Huacai Chen
2024-07-19 16:01 ` Kees Cook
2024-07-20 2:52 ` Jinjie Ruan
2024-07-20 16:42 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202407200940.ABE5F65@keescook \
--to=kees@kernel.org \
--cc=arnd@arndb.de \
--cc=chenhuacai@kernel.org \
--cc=gustavoars@kernel.org \
--cc=kernel@xen0n.name \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=maobibo@loongson.cn \
--cc=ruanjinjie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox