Re: [PATCH v1 07/10] iio: pressure: bmp280: Use sleep and forced mode for oneshot captures

Jonathan Cameron
2024-07-22T19:15:57Z

> > >
> > > .trigger_handler = bmp580_trigger_handler,
> > > @@ -2503,6 +2721,16 @@ static int bmp180_read_press(struct bmp280_data *data, u32 *comp_press)
> > > return 0;
> > > }
> > >
> > > +static int bmp180_set_mode(struct bmp280_data *data, u8 mode)
> > > +{
> > > + return 0;
> > Add a comment on why these are stubs. It's in the patch description, but
> > better to have it recorded in the code.
> >
>
> I didn't add because as you can see below there is another function exactly
> like this one that doesn't have one. Should I add also to the other one?
Hmm. Maybe? :)

>
> > > +}
> > > +
> > > +static int bmp180_wait_conv(struct bmp280_data *data)
> > > +{
> > > + return 0;
> > > +}
> > > +
> > >