commit 7a5ee4aa61af causes warning on boot

commit 7a5ee4aa61af causes warning on boot

[Bert Karwatzki]

Since linux-next-20240722 the following warning is shown on boot which can
be bisected to commit 7a5ee4aa61af:

[    T1] ------------[ cut here ]------------
[    T1] WARNING: CPU: 0 PID: 1 at kernel/time/timer_migration.c:1742 tmigr_cpu_prepare+0x469/0x540
[    T1] Modules linked in:
[    T1] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 6.10.0-rc6-bisect-00002-g7a5ee4aa61af-dirty #135
[    T1] Hardware name: Micro-Star International Co., Ltd. Alpha 15 B5EEK/MS-158L, BIOS E158LAMS.107 11/10/2021
[    T1] RIP: 0010:tmigr_cpu_prepare+0x469/0x540
[    T1] Code: fc 7d 00 0f b6 43 60 48 89 de 48 89 ef 48 8d 54 24 28 88 44 24 40 e8 16 fb ff ff 84 c0 75 94 48 83 7d 08 00 74 8d 0f 0b eb 89 <0f> 0b e9 d6 fb ff ff 48 89 ef eb 08 49 8b 7d 00 41 83 ec 01 48 8b
[    T1] RSP: 0018:ffffa2e3c0107d60 EFLAGS: 00010246
[    T1] RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000
[    T1] RDX: ffff94edee61bcc0 RSI: 0000000000000040 RDI: 0000000000000000
[    T1] RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000
[    T1] R10: ffffa2e3c0107d40 R11: ffffffff90099d48 R12: 0000000000000000
[    T1] R13: 0000000000017400 R14: 0000000000000040 R15: ffff94edee61bcc0
[    T1] FS:  0000000000000000(0000) GS:ffff94edee600000(0000) knlGS:0000000000000000
[    T1] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[    T1] CR2: ffff94e666c01000 CR3: 0000000826818000 CR4: 0000000000750ef0
[    T1] PKRU: 55555554
[    T1] Call Trace:
[    T1]  <TASK>
[    T1]  ? __warn+0x6a/0xc0
[    T1]  ? tmigr_cpu_prepare+0x469/0x540
[    T1]  ? report_bug+0x142/0x180
[    T1]  ? handle_bug+0x3a/0x70
[    T1]  ? exc_invalid_op+0x17/0x70
[    T1]  ? asm_exc_invalid_op+0x1a/0x20
[    T1]  ? tmigr_cpu_prepare+0x469/0x540
[    T1]  ? srso_alias_return_thunk+0x5/0xfbef5
[    T1]  ? prb_read_valid+0x16/0x20
[    T1]  ? srso_alias_return_thunk+0x5/0xfbef5
[    T1]  ? cpuhp_issue_call+0xf7/0x170
[    T1]  ? __cpuhp_setup_state_cpuslocked+0x128/0x2c0
[    T1]  ? tmigr_trigger_active+0x30/0x30
[    T1]  ? tmigr_trigger_active+0x30/0x30
[    T1]  ? __cpuhp_setup_state+0x5e/0xe0
[    T1]  ? tick_nohz_init+0x120/0x120
[    T1]  ? tmigr_init+0xd2/0x130
[    T1]  ? tick_nohz_init+0x120/0x120
[    T1]  ? do_one_initcall+0x70/0x2c0
[    T1]  ? kernel_init_freeable+0xc5/0x260
[    T1]  ? rest_init+0xc0/0xc0
[    T1]  ? kernel_init+0x15/0x1b0
[    T1]  ? ret_from_fork+0x2f/0x50
[    T1]  ? rest_init+0xc0/0xc0
[    T1]  ? ret_from_fork_asm+0x11/0x20
[    T1]  </TASK>
[    T1] ---[ end trace 0000000000000000 ]---

Hardware: MSI Alpha 15 Notebook Ryzen 5800H (x86_64)

Bert Karwatzki

Re: commit 7a5ee4aa61af causes warning on boot

[Frederic Weisbecker]

Le Mon, Jul 22, 2024 at 02:39:11PM +0200, Bert Karwatzki a écrit :
> Since linux-next-20240722 the following warning is shown on boot which can
> be bisected to commit 7a5ee4aa61af:
> 
> [    T1] ------------[ cut here ]------------
> [    T1] WARNING: CPU: 0 PID: 1 at kernel/time/timer_migration.c:1742
> tmigr_cpu_prepare+0x469/0x540

Good catch, and here is a fix proposal (untested!):

https://lore.kernel.org/all/Zp5bpLJHlYsZinGj@localhost.localdomain/

Re: commit 7a5ee4aa61af causes warning on boot

[Bert Karwatzki]

Am Montag, dem 22.07.2024 um 15:18 +0200 schrieb Frederic Weisbecker:
> Le Mon, Jul 22, 2024 at 02:39:11PM +0200, Bert Karwatzki a écrit :
> > Since linux-next-20240722 the following warning is shown on boot which can
> > be bisected to commit 7a5ee4aa61af:
> >
> > [    T1] ------------[ cut here ]------------
> > [    T1] WARNING: CPU: 0 PID: 1 at kernel/time/timer_migration.c:1742
> > tmigr_cpu_prepare+0x469/0x540
>
> Good catch, and here is a fix proposal (untested!):
>
> https://lore.kernel.org/all/Zp5bpLJHlYsZinGj@localhost.localdomain/
Just tested the patch with linux-next-20240722, it works for me.

Bert Karwatzki