Re: [PATCH v5 13/14] staging: media: starfive: Drop read support for video capture devices

Laurent Pinchart
2024-07-22T14:54:54Z

Hi Changhuang,

Thank you for the patch.

On Tue, Jul 09, 2024 at 01:38:23AM -0700, Changhuang Liang wrote:
> StarFive video capture devices is not support VB2_READ queue access
> method. Drop the implementation of the read hook.
>
> Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> drivers/staging/media/starfive/camss/stf-video.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/media/starfive/camss/stf-video.c b/drivers/staging/media/starfive/camss/stf-video.c
> index 8c6c45d8b7a1..28e6679ee9b9 100644
> --- a/drivers/staging/media/starfive/camss/stf-video.c
> +++ b/drivers/staging/media/starfive/camss/stf-video.c
> @@ -570,7 +570,6 @@ static const struct v4l2_file_operations stf_vid_fops = {
> .release = vb2_fop_release,
> .poll = vb2_fop_poll,
> .mmap = vb2_fop_mmap,
> - .read = vb2_fop_read,
> };
>
> /* -----------------------------------------------------------------------------

--
Regards,

Laurent Pinchart