From: Jonathan Cameron <jic23@kernel.org>
To: Matteo Martelli <matteomartelli3@gmail.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Marius Cristea <marius.cristea@microchip.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] iio: ABI: generalize shunt_resistor attribute
Date: Mon, 22 Jul 2024 21:07:16 +0100 [thread overview]
Message-ID: <20240722210716.09ca4223@jic23-huawei> (raw)
In-Reply-To: <20240722-iio-pac1921-v3-2-05dc9916cb33@gmail.com>
On Mon, 22 Jul 2024 12:03:19 +0200
Matteo Martelli <matteomartelli3@gmail.com> wrote:
> Move ABI documentation for custom shunt resistor attributes into the
> generic iio documentation file. Exception for pac1934: leave it
> untouched since it does not comply with common iio ABI generalization.
>
> Signed-off-by: Matteo Martelli <matteomartelli3@gmail.com>
This stands on it's own even if the driver needs a minor tweak or two yet.
Hence in the interests of not having to remember I've read it before,
I've queued this patch up;
Applied to the testing branch of iio.git. That will be rebased on rc1 once
available and pushed out as togreg for linux-next to pick it up.
Thanks,
Jonathan
> ---
> Documentation/ABI/testing/sysfs-bus-iio | 8 ++++++++
> Documentation/ABI/testing/sysfs-bus-iio-adc-max9611 | 17 -----------------
> Documentation/ABI/testing/sysfs-bus-iio-ina2xx-adc | 9 ---------
> 3 files changed, 8 insertions(+), 26 deletions(-)
>
> diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
> index 7cee78ad4108..935d67fd1a43 100644
> --- a/Documentation/ABI/testing/sysfs-bus-iio
> +++ b/Documentation/ABI/testing/sysfs-bus-iio
> @@ -2289,3 +2289,11 @@ KernelVersion: 6.7
> Contact: linux-iio@vger.kernel.org
> Description:
> List of available timeout value for tap gesture confirmation.
> +
> +What: /sys/.../iio:deviceX/in_shunt_resistor
> +What: /sys/.../iio:deviceX/in_current_shunt_resistor
> +What: /sys/.../iio:deviceX/in_power_shunt_resistor
> +KernelVersion: 6.10
> +Contact: linux-iio@vger.kernel.org
> +Description:
> + The value of current sense resistor in Ohms.
> diff --git a/Documentation/ABI/testing/sysfs-bus-iio-adc-max9611 b/Documentation/ABI/testing/sysfs-bus-iio-adc-max9611
> deleted file mode 100644
> index 6d2d2b094941..000000000000
> --- a/Documentation/ABI/testing/sysfs-bus-iio-adc-max9611
> +++ /dev/null
> @@ -1,17 +0,0 @@
> -What: /sys/bus/iio/devices/iio:deviceX/in_power_shunt_resistor
> -Date: March 2017
> -KernelVersion: 4.12
> -Contact: linux-iio@vger.kernel.org
> -Description: The value of the shunt resistor used to compute power drain on
> - common input voltage pin (RS+). In Ohms.
> -
> -What: /sys/bus/iio/devices/iio:deviceX/in_current_shunt_resistor
> -Date: March 2017
> -KernelVersion: 4.12
> -Contact: linux-iio@vger.kernel.org
> -Description: The value of the shunt resistor used to compute current flowing
> - between RS+ and RS- voltage sense inputs. In Ohms.
> -
> -These attributes describe a single physical component, exposed as two distinct
> -attributes as it is used to calculate two different values: power load and
> -current flowing between RS+ and RS- inputs.
> diff --git a/Documentation/ABI/testing/sysfs-bus-iio-ina2xx-adc b/Documentation/ABI/testing/sysfs-bus-iio-ina2xx-adc
> index 8916f7ec6507..8dbca113112d 100644
> --- a/Documentation/ABI/testing/sysfs-bus-iio-ina2xx-adc
> +++ b/Documentation/ABI/testing/sysfs-bus-iio-ina2xx-adc
> @@ -13,12 +13,3 @@ Description:
> available for reading data. However, samples can be occasionally skipped
> or repeated, depending on the beat between the capture and conversion
> rates.
> -
> -What: /sys/bus/iio/devices/iio:deviceX/in_shunt_resistor
> -Date: December 2015
> -KernelVersion: 4.4
> -Contact: linux-iio@vger.kernel.org
> -Description:
> - The value of the shunt resistor may be known only at runtime fom an
> - eeprom content read by a client application. This attribute allows to
> - set its value in ohms.
>
next prev parent reply other threads:[~2024-07-22 20:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-22 10:03 [PATCH v3 0/3] iio: adc: add support for pac1921 Matteo Martelli
2024-07-22 10:03 ` [PATCH v3 1/3] dt-bindings: iio: adc: add binding " Matteo Martelli
2024-07-22 16:32 ` Conor Dooley
2024-07-22 20:05 ` Jonathan Cameron
2024-07-22 10:03 ` [PATCH v3 2/3] iio: ABI: generalize shunt_resistor attribute Matteo Martelli
2024-07-22 20:07 ` Jonathan Cameron [this message]
2024-07-23 9:09 ` Matteo Martelli
2024-07-27 12:28 ` Jonathan Cameron
2024-07-22 10:03 ` [PATCH v3 3/3] iio: adc: add support for pac1921 Matteo Martelli
2024-07-23 18:18 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240722210716.09ca4223@jic23-huawei \
--to=jic23@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marius.cristea@microchip.com \
--cc=matteomartelli3@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox