From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 40ABB61FE1; Tue, 23 Jul 2024 04:24:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721708663; cv=none; b=p8BZiEaDnRe+5fBhd7v9UAX0srvftzFBSlrQbgyXR0LY3cviYmRAXKIj908j425hGvdH2eE6417FrSILn2/2cpCW24+dYLsdcoZGummks0pxkEbDvC3wI6IeoqUBd2QBwpLkxP9udSG2DjFn5Gs+oDHD5bXMiZ9VEdU22yPT4B4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721708663; c=relaxed/simple; bh=b+/UhKRdO01MBVJflNIZgGIuDWT+kECWlSkFyJLs79A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NLH4H7nPLEnU5HTH5tCObLjeytT6QdxHlvzx5d39NTudlZN0Mf179HF97zhpIwEotNTahNbnf2Amu65lqngBPuj0tBdLaoPcbbzadMmC0iW63lhtmZnEO8DnxSXcDD1tAddKe1IRWsWVgF3a5ycIH68vbPRQRMoTbkpwLteCgk4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XjWadY0k; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XjWadY0k" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 859FDC4AF0C; Tue, 23 Jul 2024 04:24:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721708662; bh=b+/UhKRdO01MBVJflNIZgGIuDWT+kECWlSkFyJLs79A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XjWadY0khbOna8w6igG13xlZMKf2O7B0W8Fe5DjLqlD5gO4ZH3+Kd1UANiK5YqMC5 8n56bI2axfzSSjbRLP8pVtsJemUJW7OHvKQIFUeS0jGzS/hWrQ7yY7BedSgUNd5Z1U 4WfAIefuMGM4qqKrhiXucn0m4QETSoONnIjRVL1uBKHJFuuFae9st1buKRguaMH79X oF5KZMlJf0kSAMXOTGHBR38et6zlwU9Va/qVIJksbtPqS8aW0S4m+/GJzg+teaBPOI 4TFy/gsHfJ8G0+4k/iF4FJAza/AAHsQ7DmQNPOjQ/mlmALzkVcsx0IGXxBSTCFarrx JcPugYkkwM/Kg== Date: Mon, 22 Jul 2024 21:24:20 -0700 From: Eric Biggers To: Alex Deucher Cc: Mikhail Gavrilov , Rodrigo Siqueira Jordao , "Mahfooz, Hamza" , Linux regressions mailing list , "Deucher, Alexander" , amd-gfx list , dri-devel , Linux List Kernel Mailing Subject: Re: 6.10/bisected/regression - commits bc87d666c05 and 6d4279cb99ac cause appearing green flashing bar on top of screen on Radeon 6900XT and 120Hz Message-ID: <20240723042420.GA1455@sol.localdomain> References: <2915a8c4-ebac-4dae-8f09-32a5b4d9aeda@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Jul 16, 2024 at 01:10:37PM -0400, Alex Deucher wrote: > From 8aaf8da07a8b542c0a0f4da2601da07beddfdeb0 Mon Sep 17 00:00:00 2001 > From: Alex Deucher > Date: Tue, 16 Jul 2024 12:49:25 -0400 > Subject: [PATCH] drm/amd/display: fix corruption with high refresh rates on > DCN 3.0 > > This reverts commit bc87d666c05a13e6d4ae1ddce41fc43d2567b9a2 and the > register changes from commit 6d4279cb99ac4f51d10409501d29969f687ac8dc. > > Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3478 > Cc: mikhail.v.gavrilov@gmail.com > Cc: Rodrigo Siqueira > Signed-off-by: Alex Deucher > --- > .../drm/amd/display/dc/optc/dcn10/dcn10_optc.c | 15 +++------------ > .../drm/amd/display/dc/optc/dcn20/dcn20_optc.c | 10 ++++++++++ > 2 files changed, 13 insertions(+), 12 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/optc/dcn10/dcn10_optc.c b/drivers/gpu/drm/amd/display/dc/optc/dcn10/dcn10_optc.c > index 4f82146d94b1..f00d27b7c6fe 100644 > --- a/drivers/gpu/drm/amd/display/dc/optc/dcn10/dcn10_optc.c > +++ b/drivers/gpu/drm/amd/display/dc/optc/dcn10/dcn10_optc.c > @@ -950,19 +950,10 @@ void optc1_set_drr( > OTG_FORCE_LOCK_ON_EVENT, 0, > OTG_SET_V_TOTAL_MIN_MASK_EN, 0, > OTG_SET_V_TOTAL_MIN_MASK, 0); > - > - // Setup manual flow control for EOF via TRIG_A > - optc->funcs->setup_manual_trigger(optc); > - > - } else { > - REG_UPDATE_4(OTG_V_TOTAL_CONTROL, > - OTG_SET_V_TOTAL_MIN_MASK, 0, > - OTG_V_TOTAL_MIN_SEL, 0, > - OTG_V_TOTAL_MAX_SEL, 0, > - OTG_FORCE_LOCK_ON_EVENT, 0); > - > - optc->funcs->set_vtotal_min_max(optc, 0, 0); > } > + > + // Setup manual flow control for EOF via TRIG_A > + optc->funcs->setup_manual_trigger(optc); > } > > void optc1_set_vtotal_min_max(struct timing_generator *optc, int vtotal_min, int vtotal_max) > diff --git a/drivers/gpu/drm/amd/display/dc/optc/dcn20/dcn20_optc.c b/drivers/gpu/drm/amd/display/dc/optc/dcn20/dcn20_optc.c > index 43417cff2c9b..b4694985a40a 100644 > --- a/drivers/gpu/drm/amd/display/dc/optc/dcn20/dcn20_optc.c > +++ b/drivers/gpu/drm/amd/display/dc/optc/dcn20/dcn20_optc.c > @@ -453,6 +453,16 @@ void optc2_setup_manual_trigger(struct timing_generator *optc) > { > struct optc *optc1 = DCN10TG_FROM_TG(optc); > > + /* Set the min/max selectors unconditionally so that > + * DMCUB fw may change OTG timings when necessary > + * TODO: Remove the w/a after fixing the issue in DMCUB firmware > + */ > + REG_UPDATE_4(OTG_V_TOTAL_CONTROL, > + OTG_V_TOTAL_MIN_SEL, 1, > + OTG_V_TOTAL_MAX_SEL, 1, > + OTG_FORCE_LOCK_ON_EVENT, 0, > + OTG_SET_V_TOTAL_MIN_MASK, (1 << 1)); /* TRIGA */ > + > REG_SET_8(OTG_TRIGA_CNTL, 0, > OTG_TRIGA_SOURCE_SELECT, 21, > OTG_TRIGA_SOURCE_PIPE_SELECT, optc->inst, > -- > 2.45.2 This patch fixes the bug for me too. I am using a Radeon RX 6400, and I've been encountering the bug when using 1920x1080 resolution on a monitor whose native resolution is 2560x1440. Feel free to add: Tested-by: Eric Biggers Thanks, - Eric