Re: [PATCH v2 0/3] KVM: arm64: fix warnings in W=1 build

Marc Zyngier
2024-07-23T17:04:36Z

On Tue, 23 Jul 2024 11:12:01 +0100,
Sebastian Ott <sebott@redhat.com> wrote:
>
> Building arch/arm64/kvm/ with W=1 spills out a lot of warnings. When
> changing stuff I try to use as much tooling as possible to make sure
> that I don't screw up - having a clean baseline imho helps with that.
>
> With the first 2 patches applied make W=1 arch/arm64/kvm/ runs without
> warnings for me (fedora userspace, upstream linux after kvm merge).
> Patch 3 gets rid of sparse lock warnings in arch/arm64/kvm/vgic/.
>
> Patch 1 now just adds -Wno-override-init to the cflags of the affected
> files. Alternatives would be to add this to the whole subdir or
> reintroduce the flag for higher warn levels..
>
> Sebastian Ott (3):
> KVM: arm64: fix override-init warnings in W=1 builds
> KVM: arm64: fix kdoc warnings in W=1 builds
> KVM: arm64: vgic: fix unexpected unlock sparse warnings
>
> arch/arm64/kvm/Makefile | 3 +++
> arch/arm64/kvm/arm.c | 1 +
> arch/arm64/kvm/hyp/nvhe/Makefile | 2 ++
> arch/arm64/kvm/hyp/vhe/Makefile | 2 ++
> arch/arm64/kvm/vgic/vgic-irqfd.c | 7 ++++---
> arch/arm64/kvm/vgic/vgic-its.c | 18 +++++++++++-------
> arch/arm64/kvm/vgic/vgic-v3.c | 2 +-
> arch/arm64/kvm/vgic/vgic.c | 2 +-
> arch/arm64/kvm/vgic/vgic.h | 2 +-
> 9 files changed, 26 insertions(+), 13 deletions(-)

For the series, and assuming we take this in 6.11::

Reviewed-by: Marc Zyngier <maz@kernel.org>

M.

--
Without deviation from the norm, progress is not possible.