From: Christoph Hellwig <hch@lst.de>
To: Maurizio Lombardi <mlombard@redhat.com>
Cc: Pratyush Yadav <ptyadav@amazon.de>,
Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvme-pci: do not set the NUMA node of device if it has none
Date: Tue, 23 Jul 2024 16:39:37 +0200 [thread overview]
Message-ID: <20240723143937.GA20891@lst.de> (raw)
In-Reply-To: <CAFL455=O23ci6GCzdnJr8DmyVSXAD=ctmj4AEk=XfSSLjbUQYA@mail.gmail.com>
On Tue, Jul 23, 2024 at 11:49:24AM +0200, Maurizio Lombardi wrote:
> FYI, we have received bug reports because of this patch.
> All single numa nodes like a VMware guest or a system set to interleaved mode
> will now see -1 as the numa_node attribute.
>
> Apparently, some applications like Lightbits do not expect to see -1.
But they can see the same for all kinds of other devices. I can't see
how we could cater to this kind of behavior..
prev parent reply other threads:[~2024-07-23 14:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 11:06 [PATCH] nvme-pci: do not set the NUMA node of device if it has none Pratyush Yadav
2023-07-25 14:35 ` Keith Busch
2023-07-26 7:58 ` Sagi Grimberg
2023-07-26 13:14 ` Christoph Hellwig
2023-07-26 15:30 ` Pratyush Yadav
2023-07-26 16:17 ` Keith Busch
2023-07-26 19:32 ` Pratyush Yadav
2023-07-26 22:25 ` Keith Busch
2023-07-28 18:09 ` Pratyush Yadav
2023-07-28 19:34 ` Keith Busch
2023-08-04 14:50 ` Pratyush Yadav
2023-08-04 15:19 ` Keith Busch
2023-08-08 15:51 ` Pratyush Yadav
2023-08-08 16:35 ` Keith Busch
2024-07-23 9:49 ` Maurizio Lombardi
2024-07-23 14:39 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240723143937.GA20891@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mlombard@redhat.com \
--cc=ptyadav@amazon.de \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox