From: Greg KH <gregkh@linuxfoundation.org>
To: Steven Davis <goldside000@outlook.com>
Cc: christian.gromm@microchip.com,
parthiban.veerasooran@microchip.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] Capitalized "c" to "C" and changed "expect" to "expected"
Date: Tue, 23 Jul 2024 09:48:03 +0200 [thread overview]
Message-ID: <2024072344-ripeness-ablaze-43bf@gregkh> (raw)
In-Reply-To: <SJ2P223MB1026B72D6CED70A91E8E55CCF7A82@SJ2P223MB1026.NAMP223.PROD.OUTLOOK.COM>
On Mon, Jul 22, 2024 at 12:59:44PM -0400, Steven Davis wrote:
> This patch makes three error messages in the driver easier to read by capitalizing the first letters properly.
Please wrap your changelog text at 72 characters, checkpatch should have
caught this, right?
> For example, "channel already linked" became "Channel already linked".
> In addition, "expect" becomes "expected", as you would typically find in an error message.
When you have "in addition" that usually means you should split this up
into different changes, rigth?
> This patch is necessary for improving user experience and the kernel's quality.
This isn't a quality thing, it's a "spelling fixes are nice" thing.
Also, please fix up the subject line to match those that have been made
to this file in the past with the correct prefix.
thanks,
greg k-h
prev parent reply other threads:[~2024-07-23 7:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-22 16:59 [PATCH v3] Capitalized "c" to "C" and changed "expect" to "expected" Steven Davis
2024-07-23 7:48 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024072344-ripeness-ablaze-43bf@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=christian.gromm@microchip.com \
--cc=goldside000@outlook.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=parthiban.veerasooran@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox