[PATCH v3] Capitalized "c" to "C" and changed "expect" to "expected"

[PATCH v3] Capitalized "c" to "C" and changed "expect" to "expected"

[Steven Davis]

This patch makes three error messages in the driver easier to read by capitalizing the first letters properly.
For example, "channel already linked" became "Channel already linked".
In addition, "expect" becomes "expected", as you would typically find in an error message.
This patch is necessary for improving user experience and the kernel's quality.

Signed-off-by: Steven Davis <goldside000@outlook.com>
---
V1 -> V2: Added a patch description
V2 -> V3: Changed subject line, removed apology from patch description, added change log

 drivers/staging/most/video/video.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/most/video/video.c b/drivers/staging/most/video/video.c
index 6254a5df2502..2b3cdb1ce140 100644
--- a/drivers/staging/most/video/video.c
+++ b/drivers/staging/most/video/video.c
@@ -454,18 +454,18 @@ static int comp_probe_channel(struct most_interface *iface, int channel_idx,
 	struct most_video_dev *mdev = get_comp_dev(iface, channel_idx);
 
 	if (mdev) {
-		pr_err("channel already linked\n");
+		pr_err("Channel already linked\n");
 		return -EEXIST;
 	}
 
 	if (ccfg->direction != MOST_CH_RX) {
-		pr_err("wrong direction, expect rx\n");
+		pr_err("Wrong direction, expected rx\n");
 		return -EINVAL;
 	}
 
 	if (ccfg->data_type != MOST_CH_SYNC &&
 	    ccfg->data_type != MOST_CH_ISOC) {
-		pr_err("wrong channel type, expect sync or isoc\n");
+		pr_err("Wrong channel type, expected sync or isoc\n");
 		return -EINVAL;
 	}
 
-- 
2.45.2

Re: [PATCH v3] Capitalized "c" to "C" and changed "expect" to "expected"

[Greg KH]

On Mon, Jul 22, 2024 at 12:59:44PM -0400, Steven Davis wrote:
> This patch makes three error messages in the driver easier to read by capitalizing the first letters properly.

Please wrap your changelog text at 72 characters, checkpatch should have
caught this, right?

> For example, "channel already linked" became "Channel already linked".
> In addition, "expect" becomes "expected", as you would typically find in an error message.

When you have "in addition" that usually means you should split this up
into different changes, rigth?

> This patch is necessary for improving user experience and the kernel's quality.

This isn't a quality thing, it's a "spelling fixes are nice" thing.

Also, please fix up the subject line to match those that have been made
to this file in the past with the correct prefix.

thanks,

greg k-h