Re: [PATCH 2/2] LoongArch: KVM: Add paravirt qspinlock in guest side

maobibo
2024-07-24T01:30:12Z

On 2024/7/24 上午3:57, kernel test robot wrote:
> Hi Bibo,
>
> kernel test robot noticed the following build errors:
yes, forgot to mention, it depends on this patch
https://lore.kernel.org/lkml/20240721164552.50175-1-ubizjak@gmail.com/

Regards
Bibo Mao
>
> [auto build test ERROR on 7846b618e0a4c3e08888099d1d4512722b39ca99]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Bibo-Mao/LoongArch-KVM-Add-paravirt-qspinlock-in-kvm-side/20240723-160536
> base: 7846b618e0a4c3e08888099d1d4512722b39ca99
> patch link: https://lore.kernel.org/r/20240723073825.1811600-3-maobibo%40loongson.cn
> patch subject: [PATCH 2/2] LoongArch: KVM: Add paravirt qspinlock in guest side
> config: loongarch-allmodconfig (https://download.01.org/0day-ci/archive/20240724/202407240320.qqd1uWiE-lkp@intel.com/config)
> compiler: loongarch64-linux-gcc (GCC) 14.1.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240724/202407240320.qqd1uWiE-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202407240320.qqd1uWiE-lkp@intel.com/
>
> All error/warnings (new ones prefixed by >>):
>
>>> arch/loongarch/kernel/paravirt.c:309: warning: expecting prototype for queued_spin_unlock(). Prototype was for native_queued_spin_unlock() instead
> --
> In file included from include/linux/atomic.h:80,
> from include/asm-generic/bitops/atomic.h:5,
> from arch/loongarch/include/asm/bitops.h:27,
> from include/linux/bitops.h:63,
> from include/linux/kernel.h:23,
> from include/linux/cpumask.h:11,
> from include/linux/smp.h:13,
> from kernel/locking/qspinlock.c:16:
> kernel/locking/qspinlock_paravirt.h: In function 'pv_kick_node':
>>> include/linux/atomic/atomic-arch-fallback.h:242:34: error: initialization of 'u8 *' {aka 'unsigned char *'} from incompatible pointer type 'enum vcpu_state *' [-Wincompatible-pointer-types]
> 242 | typeof(*(_ptr)) *___op = (_oldp), ___o = *___op, ___r; \
> | ^
> include/linux/atomic/atomic-instrumented.h:4908:9: note: in expansion of macro 'raw_try_cmpxchg_relaxed'
> 4908 | raw_try_cmpxchg_relaxed(__ai_ptr, __ai_oldp, __VA_ARGS__); \
> | ^~~~~~~~~~~~~~~~~~~~~~~
> kernel/locking/qspinlock_paravirt.h:377:14: note: in expansion of macro 'try_cmpxchg_relaxed'
> 377 | if (!try_cmpxchg_relaxed(&pn->state, &old, vcpu_hashed))
> | ^~~~~~~~~~~~~~~~~~~
>
>
> vim +309 arch/loongarch/kernel/paravirt.c
>
> 303
> 304 /**
> 305 * queued_spin_unlock - release a queued spinlock
> 306 * @lock : Pointer to queued spinlock structure
> 307 */
> 308 static void native_queued_spin_unlock(struct qspinlock *lock)
> > 309 {
> 310 /*
> 311 * unlock() needs release semantics:
> 312 */
> 313 smp_store_release(&lock->locked, 0);
> 314 }
> 315
>