Re: [PATCH v2 0/2] sched/deadline: fixes and improvements

Peter Zijlstra
2024-08-07T10:59:53Z

On Thu, Jul 25, 2024 at 09:29:26AM +0200, Juri Lelli wrote:
> Hi Wander,
>
> On 24/07/24 11:22, Wander Lairson Costa wrote:
> > Hello,
> >
> > This patch series addresses specific issues and improvements within
> > the scheduler's deadline (DL) class. The patches aim to fix warnings,
> > remove redundant checks, and consolidate timer cancellation logic for
> > better consistency and code quality.
> >
> > Patch 1: Fix warning in migrate_enable for boosted tasks
> >
> > Fix a warning caused by unnecessary calls to setup_new_dl_entity for
> > boosted tasks during CPU migate_enable calls.
> >
> > Patch 2: sched/deadline: Consolidate Timer Cancellation
> >
> > Consolidate timer cancellation logic into dedicated functions,
> > ensuring consistent behavior and reducing code duplication.
> >
> > Changelog
> > ---------
> >
> > v2:
> > * Drop patch to remove the redundant WARN_ON call.
> > * Change the "Fixes" tag in the patch 1.
> > * Change function names in the patch 2.
> >
> > Wander Lairson Costa (2):
> > sched/deadline: Fix warning in migrate_enable for boosted tasks
> > sched/deadline: Consolidate Timer Cancellation
> >
> > kernel/sched/deadline.c | 45 ++++++++++++++++++++++++++---------------
> > 1 file changed, 29 insertions(+), 16 deletions(-)
>
> Looks good to me now.
>
> Acked-by: Juri Lelli <juri.lelli@redhat.com>

I stuck this in queue/sched/core, but there was some trivial rejects on
the second patch, which I stomped on. It builds, but please double check
I didn't mess it up.