public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Olivier Moysan <olivier.moysan@foss.st.com>
Cc: fabrice.gasnier@foss.st.com, Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 5/9] dt-bindings: iio: add backend support to sd modulator
Date: Thu, 25 Jul 2024 08:37:50 -0500	[thread overview]
Message-ID: <20240725133750.GA1726974-robh@kernel.org> (raw)
In-Reply-To: <20240724153639.803263-6-olivier.moysan@foss.st.com>

On Wed, Jul 24, 2024 at 05:36:33PM +0200, Olivier Moysan wrote:
> The legacy sd modulator driver registers the sigma delta modulator as
> an IIO channel provider. This implementation is not convenient when the
> SD modulator has to be cascaded with another IIO device. The scaling
> information is distributed across devices, which makes it difficult to
> report consistent scaling data on IIO devices.
> 
> The solution is to expose these cascaded IIO devices as an aggregate
> device, which report global scaling information.
> Add IIO backend support to SD modulator to allow scaling information
> management.
> 
> Signed-off-by: Olivier Moysan <olivier.moysan@foss.st.com>
> ---
>  .../bindings/iio/adc/sigma-delta-modulator.yaml | 17 +++++++++++++++--
>  1 file changed, 15 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.yaml b/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.yaml
> index cab0d425eaa4..b245971fecb0 100644
> --- a/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.yaml
> @@ -18,18 +18,31 @@ properties:
>        - sd-modulator
>        - ads1201
>  
> +  '#io-backend-cells':
> +    const: 0
> +
>    '#io-channel-cells':
>      const: 0
>  
>  required:
>    - compatible
> -  - '#io-channel-cells'
> +
> +anyOf:
> +  - required: ['#io-backend-cells']
> +  - required: ['#io-channel-cells']
>  
>  additionalProperties: false
>  
>  examples:
>    - |
> -    ads1202: adc {
> +    // Backend binding example. SD modulator configured as an IIO backend device
> +    ads1201_0 {
> +      compatible = "sd-modulator";
> +      #io-backend-cells = <0>;
> +    };
> +
> +    // Legacy binding example. SD modulator configured as an IIO channel provider
> +    ads1201_1 {

Why the node name change? 'adc' is generic and was correct.

This should be a separate example. (Add '- |').

>        compatible = "sd-modulator";
>        #io-channel-cells = <0>;
>      };
> -- 
> 2.25.1
> 

  reply	other threads:[~2024-07-25 13:37 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-24 15:36 [PATCH v5 0/9] iio: adc: dfsdm: add scaling support Olivier Moysan
2024-07-24 15:36 ` [PATCH v5 1/9] iio: add read scale and offset services to iio backend framework Olivier Moysan
2024-07-24 15:36 ` [PATCH v5 2/9] iio: add enable and disable " Olivier Moysan
2024-07-24 15:36 ` [PATCH v5 3/9] iio: add child nodes support in " Olivier Moysan
2024-07-24 15:36 ` [PATCH v5 4/9] dt-bindings: iio: dfsdm: move to " Olivier Moysan
2024-07-24 16:43   ` Rob Herring (Arm)
2024-07-25 12:23   ` Rob Herring
2024-07-24 15:36 ` [PATCH v5 5/9] dt-bindings: iio: add backend support to sd modulator Olivier Moysan
2024-07-25 13:37   ` Rob Herring [this message]
2024-07-24 15:36 ` [PATCH v5 6/9] dt-bindings: iio: add vref " Olivier Moysan
2024-07-25 13:44   ` Rob Herring
2024-07-24 15:36 ` [PATCH v5 7/9] iio: adc: stm32-dfsdm: adopt generic channels bindings Olivier Moysan
2024-07-27 15:18   ` Jonathan Cameron
2024-07-24 15:36 ` [PATCH v5 8/9] iio: add iio backend support to sd modulator Olivier Moysan
2024-07-24 15:36 ` [PATCH v5 9/9] iio: adc: stm32-dfsdm: add scaling support to dfsdm Olivier Moysan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240725133750.GA1726974-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=arnaud.pouliquen@foss.st.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=fabrice.gasnier@foss.st.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olivier.moysan@foss.st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox