[PATCH 5.10 00/59] 5.10.223-rc1 review

[PATCH 5.10 00/59] 5.10.223-rc1 review

[Greg Kroah-Hartman]

This is the start of the stable review cycle for the 5.10.223 release.
There are 59 patches in this series, all will be posted as a response
to this one.  If anyone has any issues with these being applied, please
let me know.

Responses should be made by Sat, 27 Jul 2024 14:27:16 +0000.
Anything received after that time might be too late.

The whole patch series can be found in one patch at:
	https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.223-rc1.gz
or in the git tree and branch at:
	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
and the diffstat can be found below.

thanks,

greg k-h

-------------
Pseudo-Shortlog of commits:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Linux 5.10.223-rc1

Jann Horn <jannh@google.com>
    filelock: Fix fcntl/close race recovery compat path

Shengjiu Wang <shengjiu.wang@nxp.com>
    ALSA: pcm_dmaengine: Don't synchronize DMA channel when DMA is paused

Krishna Kurapati <quic_kriskura@quicinc.com>
    arm64: dts: qcom: msm8996: Disable SS instance in Parkmode for USB

Seunghun Han <kkamagui@gmail.com>
    ALSA: hda/realtek: Fix the speaker output on Samsung Galaxy Book Pro 360

Edson Juliano Drosdeck <edson.drosdeck@gmail.com>
    ALSA: hda/realtek: Enable headset mic on Positivo SU C1400

lei lu <llfamsec@gmail.com>
    jfs: don't walk off the end of ealist

lei lu <llfamsec@gmail.com>
    ocfs2: add bounds checking to ocfs2_check_dir_entry()

Paolo Abeni <pabeni@redhat.com>
    net: relax socket state check at accept time.

Dan Carpenter <dan.carpenter@linaro.org>
    drm/amdgpu: Fix signedness bug in sdma_v4_0_process_trap_irq()

Gabriel Krisman Bertazi <krisman@collabora.com>
    ext4: Send notifications on error

Gabriel Krisman Bertazi <krisman@collabora.com>
    ext4: fix error code saved on super block during file system abort

Bart Van Assche <bvanassche@acm.org>
    scsi: core: Fix a use-after-free

Jason Xing <kernelxing@tencent.com>
    bpf, skmsg: Fix NULL pointer dereference in sk_psock_skb_ingress_enqueue

Daniel Borkmann <daniel@iogearbox.net>
    bpf: Fix overrunning reservations in ringbuf

Kuan-Wei Chiu <visitorckw@gmail.com>
    ACPI: processor_idle: Fix invalid comparison with insertion sort for latency

Masahiro Yamada <masahiroy@kernel.org>
    ARM: 9324/1: fix get_user() broken with veneer

David Lechner <dlechner@baylibre.com>
    spi: mux: set ctlr->bits_per_word_mask

Edward Adam Davis <eadavis@qq.com>
    hfsplus: fix uninit-value in copy_name

John Hubbard <jhubbard@nvidia.com>
    selftests/vDSO: fix clang build errors and warnings

Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    spi: imx: Don't expect DMA for i.MX{25,35,50,51,53} cspi devices

Christian Brauner <brauner@kernel.org>
    fs: better handle deep ancestor chains in is_subdir()

Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
    Bluetooth: hci_core: cancel all works upon hci_unregister_dev()

Xingui Yang <yangxingui@huawei.com>
    scsi: libsas: Fix exp-attached device scan after probe failure scanned in again after probe failed

Ganesh Goudar <ganeshgr@linux.ibm.com>
    powerpc/eeh: avoid possible crash when edev->pdev changes

Anjali K <anjalik@linux.ibm.com>
    powerpc/pseries: Whitelist dtl slub object for copying to userspace

Yunshui Jiang <jiangyunshui@kylinos.cn>
    net: mac802154: Fix racy device stats updates by DEV_STATS_INC() and DEV_STATS_ADD()

Daniele Palmas <dnlplm@gmail.com>
    net: usb: qmi_wwan: add Telit FN912 compositions

Shengjiu Wang <shengjiu.wang@nxp.com>
    ALSA: dmaengine_pcm: terminate dmaengine before synchronize

Aivaz Latypov <reichaivaz@gmail.com>
    ALSA: hda/relatek: Enable Mute LED on HP Laptop 15-gw0xxx

Filipe Manana <fdmanana@suse.com>
    btrfs: qgroup: fix quota root leak after quota disable failure

Heiko Carstens <hca@linux.ibm.com>
    s390/sclp: Fix sclp_init() cleanup on failure

Chen Ni <nichen@iscas.ac.cn>
    can: kvaser_usb: fix return value for hif_usb_send_regout

Primoz Fiser <primoz.fiser@norik.com>
    ASoC: ti: omap-hdmi: Fix too long driver name

Jai Luthra <j-luthra@ti.com>
    ASoC: ti: davinci-mcasp: Set min period size using FIFO config

Jai Luthra <j-luthra@ti.com>
    ALSA: dmaengine: Synchronize dma channel after drop()

Thomas GENTY <tomlohave@gmail.com>
    bytcr_rt5640 : inverse jack detect for Archos 101 cesium

Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
    Input: i8042 - add Ayaneo Kun to i8042 quirk table

Jonathan Denose <jdenose@google.com>
    Input: elantech - fix touchpad state on resume for Lenovo N24

Arnd Bergmann <arnd@arndb.de>
    mips: fix compat_sys_lseek syscall

Kailang Yang <kailang@realtek.com>
    ALSA: hda/realtek: Add more codec ID to no shutup pins list

Michael Ellerman <mpe@ellerman.id.au>
    KVM: PPC: Book3S HV: Prevent UAF in kvm_spapr_tce_attach_iommu_group()

Dmitry Antipov <dmantipov@yandex.ru>
    wifi: cfg80211: wext: add extra SIOCSIWSCAN data check

Alexander Usyskin <alexander.usyskin@intel.com>
    mei: demote client disconnect warning on suspend to debug

Yuntao Wang <yuntao.wang@linux.dev>
    fs/file: fix the check in find_next_fd()

Masahiro Yamada <masahiroy@kernel.org>
    kconfig: remove wrong expr_trans_bool()

Masahiro Yamada <masahiroy@kernel.org>
    kconfig: gconf: give a proper initial state to the Save button

Andreas Hindborg <a.hindborg@samsung.com>
    null_blk: fix validation of block size

Wei Li <liwei391@huawei.com>
    arm64: armv8_deprecated: Fix warning in isndep cpuhp starting process

Eric Dumazet <edumazet@google.com>
    ila: block BH in ila_output()

Eric Dumazet <edumazet@google.com>
    net: ipv6: rpl_iptunnel: block BH in rpl_output() and rpl_input()

Hans de Goede <hdegoede@redhat.com>
    Input: silead - Always support 10 fingers

Michael Ellerman <mpe@ellerman.id.au>
    selftests/openat2: Fix build warnings on ppc64

Dmitry Antipov <dmantipov@yandex.ru>
    wifi: mac80211: fix UBSAN noise in ieee80211_prep_hw_scan()

Nicolas Escande <nico.escande@gmail.com>
    wifi: mac80211: mesh: init nonpeer_pm to active by default in mesh sdata

Armin Wolf <W_Armin@gmx.de>
    ACPI: EC: Avoid returning AE_OK on errors in address space handler

Armin Wolf <W_Armin@gmx.de>
    ACPI: EC: Abort address space access upon error

Saurav Kashyap <skashyap@marvell.com>
    scsi: qedf: Set qed_slowpath_params to zero before use

Jann Horn <jannh@google.com>
    filelock: Remove locks reliably when fcntl/close race is detected

Kees Cook <keescook@chromium.org>
    gcc-plugins: Rename last_stmt() for GCC 14+


-------------

Diffstat:

 Makefile                                           |  4 +-
 arch/arm/include/asm/uaccess.h                     | 14 +------
 arch/arm64/boot/dts/qcom/msm8996.dtsi              |  1 +
 arch/arm64/kernel/armv8_deprecated.c               |  3 ++
 arch/mips/kernel/syscalls/syscall_o32.tbl          |  2 +-
 arch/powerpc/kernel/eeh_pe.c                       |  7 +++-
 arch/powerpc/kvm/book3s_64_vio.c                   | 18 ++++++---
 arch/powerpc/platforms/pseries/setup.c             |  4 +-
 drivers/acpi/ec.c                                  |  9 ++++-
 drivers/acpi/processor_idle.c                      | 40 ++++++++-----------
 drivers/block/null_blk/main.c                      |  4 +-
 drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c             |  2 +-
 drivers/input/mouse/elantech.c                     | 31 +++++++++++++++
 drivers/input/serio/i8042-acpipnpio.h              | 18 ++++++++-
 drivers/input/touchscreen/silead.c                 | 19 +++------
 drivers/misc/mei/main.c                            |  2 +-
 drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c   |  2 +-
 drivers/net/usb/qmi_wwan.c                         |  2 +
 drivers/s390/char/sclp.c                           |  1 +
 drivers/scsi/hosts.c                               | 16 ++++++--
 drivers/scsi/libsas/sas_internal.h                 | 14 +++++++
 drivers/scsi/qedf/qedf_main.c                      |  1 +
 drivers/scsi/scsi_lib.c                            |  6 ++-
 drivers/scsi/scsi_priv.h                           |  2 +-
 drivers/scsi/scsi_scan.c                           |  1 +
 drivers/scsi/scsi_sysfs.c                          |  1 +
 drivers/spi/spi-imx.c                              |  2 +-
 drivers/spi/spi-mux.c                              |  1 +
 fs/btrfs/qgroup.c                                  |  4 +-
 fs/dcache.c                                        | 31 +++++++--------
 fs/ext4/super.c                                    |  9 ++++-
 fs/file.c                                          |  4 +-
 fs/hfsplus/xattr.c                                 |  2 +-
 fs/jfs/xattr.c                                     | 23 +++++++++--
 fs/locks.c                                         | 18 ++++-----
 fs/ocfs2/dir.c                                     | 46 ++++++++++++++--------
 include/linux/skmsg.h                              |  2 +
 include/scsi/scsi_host.h                           |  2 +
 include/sound/dmaengine_pcm.h                      |  1 +
 kernel/bpf/ringbuf.c                               | 30 +++++++++++---
 net/bluetooth/hci_core.c                           |  4 ++
 net/ipv4/af_inet.c                                 |  4 +-
 net/ipv6/ila/ila_lwt.c                             |  7 +++-
 net/ipv6/rpl_iptunnel.c                            | 14 +++----
 net/mac80211/mesh.c                                |  1 +
 net/mac80211/scan.c                                | 14 +++++--
 net/mac802154/tx.c                                 |  8 ++--
 net/wireless/scan.c                                |  8 +++-
 scripts/gcc-plugins/gcc-common.h                   |  4 ++
 scripts/kconfig/expr.c                             | 29 --------------
 scripts/kconfig/expr.h                             |  1 -
 scripts/kconfig/gconf.c                            |  3 +-
 scripts/kconfig/menu.c                             |  2 -
 sound/core/pcm_dmaengine.c                         | 26 ++++++++++++
 sound/pci/hda/patch_realtek.c                      |  7 ++++
 sound/soc/intel/boards/bytcr_rt5640.c              | 11 ++++++
 sound/soc/soc-generic-dmaengine-pcm.c              |  8 ++++
 sound/soc/ti/davinci-mcasp.c                       |  9 ++++-
 sound/soc/ti/omap-hdmi.c                           |  6 +--
 tools/testing/selftests/openat2/openat2_test.c     |  1 +
 tools/testing/selftests/vDSO/parse_vdso.c          | 16 +++++---
 .../selftests/vDSO/vdso_standalone_test_x86.c      | 18 ++++++++-
 62 files changed, 396 insertions(+), 204 deletions(-)

Re: [PATCH 5.10 00/59] 5.10.223-rc1 review

[Dominique Martinet]

Greg Kroah-Hartman wrote on Thu, Jul 25, 2024 at 04:36:50PM +0200:
> This is the start of the stable review cycle for the 5.10.223 release.
> There are 59 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
> 
> Responses should be made by Sat, 27 Jul 2024 14:27:16 +0000.
> Anything received after that time might be too late.
> 
> The whole patch series can be found in one patch at:
> 	https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.223-rc1.gz
> or in the git tree and branch at:
> 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> and the diffstat can be found below.

Tested 0f0134bb137e ("Linux 5.10.223-rc1") on:
- arm i.MX6ULL (Armadillo 640)
- arm64 i.MX8MP (Armadillo G4)

No obvious regression in dmesg or basic tests:
Tested-by: Dominique Martinet <dominique.martinet@atmark-techno.com>
-- 
Dominique Martinet

Re: [PATCH 5.10 00/59] 5.10.223-rc1 review

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 661 bytes --]

Hi!

> This is the start of the stable review cycle for the 5.10.223 release.
> There are 59 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.

CIP testing did not find any problems here:

https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-5.10.y

Tested-by: Pavel Machek (CIP) <pavel@denx.de>

Best regards,
                                                                Pavel
-- 
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

Re: [PATCH 5.10 00/59] 5.10.223-rc1 review

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 346 bytes --]

On Thu, Jul 25, 2024 at 04:36:50PM +0200, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.10.223 release.
> There are 59 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.

Tested-by: Mark Brown <broonie@kernel.org>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH 5.10 00/59] 5.10.223-rc1 review

[Jon Hunter]

On Thu, 25 Jul 2024 16:36:50 +0200, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.10.223 release.
> There are 59 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
> 
> Responses should be made by Sat, 27 Jul 2024 14:27:16 +0000.
> Anything received after that time might be too late.
> 
> The whole patch series can be found in one patch at:
> 	https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.223-rc1.gz
> or in the git tree and branch at:
> 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> and the diffstat can be found below.
> 
> thanks,
> 
> greg k-h

All tests passing for Tegra ...

Test results for stable-v5.10:
    10 builds:	10 pass, 0 fail
    26 boots:	26 pass, 0 fail
    68 tests:	68 pass, 0 fail

Linux version:	5.10.223-rc1-g0f0134bb137e
Boards tested:	tegra124-jetson-tk1, tegra186-p2771-0000,
                tegra194-p2972-0000, tegra194-p3509-0000+p3668-0000,
                tegra20-ventana, tegra210-p2371-2180,
                tegra210-p3450-0000, tegra30-cardhu-a04

Tested-by: Jon Hunter <jonathanh@nvidia.com>

Jon

Re: [PATCH 5.10 00/59] 5.10.223-rc1 review

[Florian Fainelli]

On 7/25/24 07:36, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.10.223 release.
> There are 59 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
> 
> Responses should be made by Sat, 27 Jul 2024 14:27:16 +0000.
> Anything received after that time might be too late.
> 
> The whole patch series can be found in one patch at:
> 	https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.223-rc1.gz
> or in the git tree and branch at:
> 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> and the diffstat can be found below.
> 
> thanks,
> 
> greg k-h

On ARCH_BRCMSTB using 32-bit and 64-bit ARM kernels, build tested on 
BMIPS_GENERIC:

Tested-by: Florian Fainelli <florian.fainelli@broadcom.com>
-- 
Florian

Re: [PATCH 5.10 00/59] 5.10.223-rc1 review

[Naresh Kamboju]

On Thu, 25 Jul 2024 at 20:18, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> This is the start of the stable review cycle for the 5.10.223 release.
> There are 59 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Sat, 27 Jul 2024 14:27:16 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
>         https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.223-rc1.gz
> or in the git tree and branch at:
>         git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h


Results from Linaro’s test farm.
No regressions on arm64, arm, x86_64, and i386.

Tested-by: Linux Kernel Functional Testing <lkft@linaro.org>

## Build
* kernel: 5.10.223-rc1
* git: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
* git commit: 0f0134bb137e987ea2c432d03486a58a70840903
* git describe: v5.10.222-60-g0f0134bb137e
* test details:
https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.10.y/build/v5.10.222-60-g0f0134bb137e

## Test Regressions (compared to v5.10.221-110-g3fac7bc30eab)

## Metric Regressions (compared to v5.10.221-110-g3fac7bc30eab)

## Test Fixes (compared to v5.10.221-110-g3fac7bc30eab)

## Metric Fixes (compared to v5.10.221-110-g3fac7bc30eab)

## Test result summary
total: 90841, pass: 73287, fail: 2151, skip: 15338, xfail: 65

## Build Summary
* arc: 5 total, 5 passed, 0 failed
* arm: 102 total, 102 passed, 0 failed
* arm64: 29 total, 29 passed, 0 failed
* i386: 23 total, 23 passed, 0 failed
* mips: 22 total, 22 passed, 0 failed
* parisc: 3 total, 0 passed, 3 failed
* powerpc: 23 total, 23 passed, 0 failed
* riscv: 9 total, 9 passed, 0 failed
* s390: 9 total, 9 passed, 0 failed
* sh: 10 total, 10 passed, 0 failed
* sparc: 6 total, 6 passed, 0 failed
* x86_64: 25 total, 25 passed, 0 failed

## Test suites summary
* boot
* kselftest-arm64
* kselftest-breakpoints
* kselftest-capabilities
* kselftest-cgroup
* kselftest-clone3
* kselftest-core
* kselftest-cpu-hotplug
* kselftest-cpufreq
* kselftest-efivarfs
* kselftest-exec
* kselftest-filesystems
* kselftest-filesystems-binderfs
* kselftest-filesystems-epoll
* kselftest-firmware
* kselftest-fpu
* kselftest-ftrace
* kselftest-futex
* kselftest-gpio
* kselftest-intel_pstate
* kselftest-ipc
* kselftest-kcmp
* kselftest-livepatch
* kselftest-membarrier
* kselftest-memfd
* kselftest-mincore
* kselftest-mqueue
* kselftest-net
* kselftest-net-mptcp
* kselftest-openat2
* kselftest-ptrace
* kselftest-rseq
* kselftest-rtc
* kselftest-sigaltstack
* kselftest-size
* kselftest-tc-testing
* kselftest-timers
* kselftest-tmpfs
* kselftest-tpm2
* kselftest-user_events
* kselftest-vDSO
* kselftest-watchdog
* kselftest-x86
* kunit
* libgpiod
* libhugetlbfs
* log-parser-boot
* log-parser-test
* ltp-commands
* ltp-containers
* ltp-controllers
* ltp-cpuhotplug
* ltp-crypto
* ltp-cve
* ltp-dio
* ltp-fcntl-locktests
* ltp-fs
* ltp-fs_bind
* ltp-fs_perms_simple
* ltp-hugetlb
* ltp-ipc
* ltp-math
* ltp-mm
* ltp-nptl
* ltp-pty
* ltp-sched
* ltp-smoke
* ltp-smoketest
* ltp-syscalls
* ltp-tracing
* perf
* rcutorture

--
Linaro LKFT
https://lkft.linaro.org

Re: [PATCH 5.10 00/59] 5.10.223-rc1 review

[Jari Ruusu]

Some older systems still compile kernels with old gcc version.

$ grep -B3 "^GNU C" linux-5.10.223-rc1/Documentation/Changes 
====================== ===============  ========================================
        Program        Minimal version       Command to check the version
====================== ===============  ========================================
GNU C                  4.9              gcc --version

These warnings and errors show up when compiling with gcc 4.9.2

  UPD     include/config/kernel.release
  UPD     include/generated/uapi/linux/version.h
  UPD     include/generated/utsrelease.h
  CC      scripts/mod/empty.o
In file included from ././include/linux/compiler_types.h:65:0,
                 from <command-line>:0:
./include/linux/compiler_attributes.h:29:29: warning: "__GCC4_has_attribute___uninitialized__" is not defined [-Wundef]
 # define __has_attribute(x) __GCC4_has_attribute_##x
                             ^
./include/linux/compiler_attributes.h:278:5: note: in expansion of macro '__has_attribute'
 #if __has_attribute(__uninitialized__)
     ^
[SNIP]
  AR      arch/x86/events/built-in.a
  CC      arch/x86/kvm/../../../virt/kvm/kvm_main.o
In file included from ././include/linux/compiler_types.h:65:0,
                 from <command-line>:0:
./include/linux/compiler_attributes.h:29:29: error: "__GCC4_has_attribute___uninitialized__" is not defined [-Werror=undef]
 # define __has_attribute(x) __GCC4_has_attribute_##x
                             ^
./include/linux/compiler_attributes.h:278:5: note: in expansion of macro '__has_attribute'
 #if __has_attribute(__uninitialized__)
     ^
cc1: all warnings being treated as errors
make[2]: *** [scripts/Makefile.build:286: arch/x86/kvm/../../../virt/kvm/kvm_main.o] Error 1
make[1]: *** [scripts/Makefile.build:503: arch/x86/kvm] Error 2
make: *** [Makefile:1832: arch/x86] Error 2

Following patch fixes this. Upstream won't need this because
newer kernels are not compilable with gcc 4.9

--- ./include/linux/compiler_attributes.h.OLD
+++ ./include/linux/compiler_attributes.h
@@ -37,6 +37,7 @@
 # define __GCC4_has_attribute___nonstring__           0
 # define __GCC4_has_attribute___no_sanitize_address__ (__GNUC_MINOR__ >= 8)
 # define __GCC4_has_attribute___no_sanitize_undefined__ (__GNUC_MINOR__ >= 9)
+# define __GCC4_has_attribute___uninitialized__       0
 # define __GCC4_has_attribute___fallthrough__         0
 # define __GCC4_has_attribute___warning__             1
 #endif

Fixes: upstream fd7eea27a3ae "Compiler Attributes: Add __uninitialized macro"
Signed-off-by: Jari Ruusu <jariruusu@protonmail.com>

--
Jari Ruusu  4096R/8132F189 12D6 4C3A DCDA 0AA4 27BD  ACDF F073 3C80 8132 F189

Re: [PATCH 5.10 00/59] 5.10.223-rc1 review

[Greg Kroah-Hartman]

On Fri, Jul 26, 2024 at 07:25:21AM +0000, Jari Ruusu wrote:
> Some older systems still compile kernels with old gcc version.
> 
> $ grep -B3 "^GNU C" linux-5.10.223-rc1/Documentation/Changes 
> ====================== ===============  ========================================
>         Program        Minimal version       Command to check the version
> ====================== ===============  ========================================
> GNU C                  4.9              gcc --version
> 
> These warnings and errors show up when compiling with gcc 4.9.2
> 
>   UPD     include/config/kernel.release
>   UPD     include/generated/uapi/linux/version.h
>   UPD     include/generated/utsrelease.h
>   CC      scripts/mod/empty.o
> In file included from ././include/linux/compiler_types.h:65:0,
>                  from <command-line>:0:
> ./include/linux/compiler_attributes.h:29:29: warning: "__GCC4_has_attribute___uninitialized__" is not defined [-Wundef]
>  # define __has_attribute(x) __GCC4_has_attribute_##x
>                              ^
> ./include/linux/compiler_attributes.h:278:5: note: in expansion of macro '__has_attribute'
>  #if __has_attribute(__uninitialized__)
>      ^
> [SNIP]
>   AR      arch/x86/events/built-in.a
>   CC      arch/x86/kvm/../../../virt/kvm/kvm_main.o
> In file included from ././include/linux/compiler_types.h:65:0,
>                  from <command-line>:0:
> ./include/linux/compiler_attributes.h:29:29: error: "__GCC4_has_attribute___uninitialized__" is not defined [-Werror=undef]
>  # define __has_attribute(x) __GCC4_has_attribute_##x
>                              ^
> ./include/linux/compiler_attributes.h:278:5: note: in expansion of macro '__has_attribute'
>  #if __has_attribute(__uninitialized__)
>      ^
> cc1: all warnings being treated as errors
> make[2]: *** [scripts/Makefile.build:286: arch/x86/kvm/../../../virt/kvm/kvm_main.o] Error 1
> make[1]: *** [scripts/Makefile.build:503: arch/x86/kvm] Error 2
> make: *** [Makefile:1832: arch/x86] Error 2
> 
> Following patch fixes this. Upstream won't need this because
> newer kernels are not compilable with gcc 4.9
> 
> --- ./include/linux/compiler_attributes.h.OLD
> +++ ./include/linux/compiler_attributes.h
> @@ -37,6 +37,7 @@
>  # define __GCC4_has_attribute___nonstring__           0
>  # define __GCC4_has_attribute___no_sanitize_address__ (__GNUC_MINOR__ >= 8)
>  # define __GCC4_has_attribute___no_sanitize_undefined__ (__GNUC_MINOR__ >= 9)
> +# define __GCC4_has_attribute___uninitialized__       0
>  # define __GCC4_has_attribute___fallthrough__         0
>  # define __GCC4_has_attribute___warning__             1
>  #endif
> 
> Fixes: upstream fd7eea27a3ae "Compiler Attributes: Add __uninitialized macro"
> Signed-off-by: Jari Ruusu <jariruusu@protonmail.com>

Please submit this in a format in which we can apply it, thanks!

greg k-h

Re: [PATCH 5.10 00/59] 5.10.223-rc1 review

[Jari Ruusu]

[-- Attachment #1: Type: text/plain, Size: 632 bytes --]

On Friday, July 26th, 2024 at 10:49, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> On Fri, Jul 26, 2024 at 07:25:21AM +0000, Jari Ruusu wrote:
> > Fixes: upstream fd7eea27a3ae "Compiler Attributes: Add __uninitialized macro"
> > Signed-off-by: Jari Ruusu jariruusu@protonmail.com
> 
> Please submit this in a format in which we can apply it, thanks!

Protonmail seems to involuntarily inject mime-poop to outgoing mails.
Sorry about that. For the time being, the best I can do is to re-send
the patch as gzipped attachment.

--
Jari Ruusu  4096R/8132F189 12D6 4C3A DCDA 0AA4 27BD  ACDF F073 3C80 8132 F189

[-- Attachment #2: gcc4-fix-for-5.10.223-rc1.diff.gz --]
[-- Type: application/gzip, Size: 253 bytes --]

Re: [PATCH 5.10 00/59] 5.10.223-rc1 review

[Greg Kroah-Hartman]

On Fri, Jul 26, 2024 at 08:21:47AM +0000, Jari Ruusu wrote:
> On Friday, July 26th, 2024 at 10:49, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> > On Fri, Jul 26, 2024 at 07:25:21AM +0000, Jari Ruusu wrote:
> > > Fixes: upstream fd7eea27a3ae "Compiler Attributes: Add __uninitialized macro"
> > > Signed-off-by: Jari Ruusu jariruusu@protonmail.com
> > 
> > Please submit this in a format in which we can apply it, thanks!
> 
> Protonmail seems to involuntarily inject mime-poop to outgoing mails.
> Sorry about that. For the time being, the best I can do is to re-send
> the patch as gzipped attachment.

For obvious reasons, we can't take that either :(

Also the "Fixes:" tag is not in the correct format, please fix that up
at the very least.

thanks,

greg k-h

Re: [PATCH 5.10 00/59] 5.10.223-rc1 review

[Jari Ruusu]

On Friday, July 26th, 2024 at 11:52, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> Also the "Fixes:" tag is not in the correct format, please fix that up
> at the very least.

Some older systems still compile kernels with old gcc version.
These warnings and errors show up when compiling with gcc 4.9.2

 error: "__GCC4_has_attribute___uninitialized__" is not defined [-Werror=undef]

Following patch fixes this. Upstream won't need this because  
newer kernels are not compilable with gcc 4.9.

Subject: gcc-4.9 warning/error fix for 5.10.223-rc1
Fixes: fd7eea27a3ae ("Compiler Attributes: Add __uninitialized macro")
Signed-off-by: Jari Ruusu <jariruusu@protonmail.com>

--- ./include/linux/compiler_attributes.h.OLD
+++ ./include/linux/compiler_attributes.h
@@ -37,6 +37,7 @@
 # define __GCC4_has_attribute___nonstring__           0
 # define __GCC4_has_attribute___no_sanitize_address__ (__GNUC_MINOR__ >= 8)
 # define __GCC4_has_attribute___no_sanitize_undefined__ (__GNUC_MINOR__ >= 9)
+# define __GCC4_has_attribute___uninitialized__       0
 # define __GCC4_has_attribute___fallthrough__         0
 # define __GCC4_has_attribute___warning__             1
 #endif

--
Jari Ruusu  4096R/8132F189 12D6 4C3A DCDA 0AA4 27BD  ACDF F073 3C80 8132 F189

Re: [PATCH 5.10 00/59] 5.10.223-rc1 review

[Greg Kroah-Hartman]

On Fri, Jul 26, 2024 at 09:53:18AM +0000, Jari Ruusu wrote:
> On Friday, July 26th, 2024 at 11:52, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> > Also the "Fixes:" tag is not in the correct format, please fix that up
> > at the very least.
> 
> Some older systems still compile kernels with old gcc version.
> These warnings and errors show up when compiling with gcc 4.9.2
> 
>  error: "__GCC4_has_attribute___uninitialized__" is not defined [-Werror=undef]
> 
> Following patch fixes this. Upstream won't need this because  
> newer kernels are not compilable with gcc 4.9.
> 
> Subject: gcc-4.9 warning/error fix for 5.10.223-rc1
> Fixes: fd7eea27a3ae ("Compiler Attributes: Add __uninitialized macro")
> Signed-off-by: Jari Ruusu <jariruusu@protonmail.com>
> 
> --- ./include/linux/compiler_attributes.h.OLD
> +++ ./include/linux/compiler_attributes.h
> @@ -37,6 +37,7 @@
>  # define __GCC4_has_attribute___nonstring__           0
>  # define __GCC4_has_attribute___no_sanitize_address__ (__GNUC_MINOR__ >= 8)
>  # define __GCC4_has_attribute___no_sanitize_undefined__ (__GNUC_MINOR__ >= 9)
> +# define __GCC4_has_attribute___uninitialized__       0
>  # define __GCC4_has_attribute___fallthrough__         0
>  # define __GCC4_has_attribute___warning__             1
>  #endif
> 
> --
> Jari Ruusu  4096R/8132F189 12D6 4C3A DCDA 0AA4 27BD  ACDF F073 3C80 8132 F189
> 

Better, thanks!  I'll touch this up by hand and apply it to the relevant
branches (not just this one needs it), for the next round of stable
releases.

greg k-h

Re: [PATCH 5.10 00/59] 5.10.223-rc1 review

[Greg Kroah-Hartman]

On Fri, Jul 26, 2024 at 12:23:02PM +0200, Greg Kroah-Hartman wrote:
> On Fri, Jul 26, 2024 at 09:53:18AM +0000, Jari Ruusu wrote:
> > On Friday, July 26th, 2024 at 11:52, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> > > Also the "Fixes:" tag is not in the correct format, please fix that up
> > > at the very least.
> > 
> > Some older systems still compile kernels with old gcc version.
> > These warnings and errors show up when compiling with gcc 4.9.2
> > 
> >  error: "__GCC4_has_attribute___uninitialized__" is not defined [-Werror=undef]
> > 
> > Following patch fixes this. Upstream won't need this because  
> > newer kernels are not compilable with gcc 4.9.
> > 
> > Subject: gcc-4.9 warning/error fix for 5.10.223-rc1
> > Fixes: fd7eea27a3ae ("Compiler Attributes: Add __uninitialized macro")
> > Signed-off-by: Jari Ruusu <jariruusu@protonmail.com>
> > 
> > --- ./include/linux/compiler_attributes.h.OLD
> > +++ ./include/linux/compiler_attributes.h
> > @@ -37,6 +37,7 @@
> >  # define __GCC4_has_attribute___nonstring__           0
> >  # define __GCC4_has_attribute___no_sanitize_address__ (__GNUC_MINOR__ >= 8)
> >  # define __GCC4_has_attribute___no_sanitize_undefined__ (__GNUC_MINOR__ >= 9)
> > +# define __GCC4_has_attribute___uninitialized__       0
> >  # define __GCC4_has_attribute___fallthrough__         0
> >  # define __GCC4_has_attribute___warning__             1
> >  #endif
> > 
> > --
> > Jari Ruusu  4096R/8132F189 12D6 4C3A DCDA 0AA4 27BD  ACDF F073 3C80 8132 F189
> > 
> 
> Better, thanks!  I'll touch this up by hand and apply it to the relevant
> branches (not just this one needs it), for the next round of stable
> releases.

Now queued up.

greg k-h

Re: [PATCH 5.10 00/59] 5.10.223-rc1 review

[Shreeya Patel]

On Friday, July 26, 2024 14:22 IST, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:

> On Fri, Jul 26, 2024 at 08:21:47AM +0000, Jari Ruusu wrote:
> > On Friday, July 26th, 2024 at 10:49, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> > > On Fri, Jul 26, 2024 at 07:25:21AM +0000, Jari Ruusu wrote:
> > > > Fixes: upstream fd7eea27a3ae "Compiler Attributes: Add __uninitialized macro"
> > > > Signed-off-by: Jari Ruusu jariruusu@protonmail.com
> > > 
> > > Please submit this in a format in which we can apply it, thanks!
> > 
> > Protonmail seems to involuntarily inject mime-poop to outgoing mails.
> > Sorry about that. For the time being, the best I can do is to re-send
> > the patch as gzipped attachment.
> 
> For obvious reasons, we can't take that either :(
> 
> Also the "Fixes:" tag is not in the correct format, please fix that up
> at the very least.
> 
> thanks,
> 
> greg k-h
> 

KernelCI report for stable-rc/linux-5.10.y for this week.
Date: 2024-07-25

## Build failures:
No build failures seen for the stable-rc/linux-5.10.y commit head \o/

## Boot failures:
No **new** boot failures seen for the stable-rc/linux-5.10.y commit head \o/

Tested-by: kernelci.org bot <bot@kernelci.org>

Thanks,
Shreeya Patel