Re: [PATCH v2 1/2] platform/x86:dell-laptop: Add knobs to change battery charge settings

Sebastian Reichel
2024-08-08T00:16:29Z

[-- Attachment #1: Type: text/plain, Size: 3157 bytes --]

Hi,

On Wed, Aug 07, 2024 at 06:05:11PM GMT, Andres Salomon wrote:
> > > > [...]
> > >
> > > Do you think it's worth keeping around the sysfs-class-power-dell
> > > file? At this point it's basically just documenting the slight naming
> > > differences:
> > >
> > >
> > > Standard:
> > > Fully charge the battery at a moderate rate.
> > > Fast:
> > > Quickly charge the battery using fast-charge
> > > technology. This is harder on the battery than
> > > standard charging and may lower its lifespan.
> > > The Dell BIOS calls this ExpressCharge™.
> > > Trickle:
> > > Users who primarily operate the system while
> > > plugged into an external power source can extend
> > > battery life with this mode. The Dell BIOS calls
> > > this "Primarily AC Use".
> > > Adaptive:
> > > Automatically optimize battery charge rate based
> > > on typical usage pattern.
> > > Custom:
> > > Use the charge_control_* properties to determine
> > > when to start and stop charging. Advanced users
> > > can use this to drastically extend battery life.
> > >
> > > Access: Read, Write
> > > Valid values:
> > > "Standard", "Fast", "Trickle",
> > > "Adaptive", "Custom"
> >
> > Another option could be to extend the description in sysfs-class-power
> > file that "Trickle" covers "Dell's Primarily AC Use" and "Fast" covers
> > "Dell's ExpressCharge".
> >
> > So if somebody is going to implement charge_type for some other Laptop
> > vendor then this information can help.
>
> How's this?
>
> @@ -378,8 +378,10 @@ Date: July 2009
> Contact: linux-pm@vger.kernel.org
> Description:
> Represents the type of charging currently being applied to the
> - battery. "Trickle", "Fast", and "Standard" all mean different
> - charging speeds. "Adaptive" means that the charger uses some
> + battery. "Fast" and "Standard" mean different charging speeds.
> + "Trickle" means a slow charging speed, or (depending on the
> + hardware) charging optimized for being mostly plugged into
> + wall power. "Adaptive" means that the charger uses some
> algorithm to adjust the charge rate dynamically, without
> any user configuration required. "Custom" means that the charger

Looks good from my side. OTOH I would also be fine with using your
Dell "specific" documentation as a replacement for the generic
documentation. But then "The Dell BIOS calls this XYZ" should be
replaced with "On Dell machines this mode is called XYZ".

Greetings,

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]