Re: [PATCH] net: usb: lan78xx: add weak dependency with micrel phy module

Paolo Abeni
2024-07-25T09:54:01Z

On 7/25/24 08:50, Lucas De Marchi wrote:
> if you are saying that the build system should automatically convert
> this:
>
> config USB_LAN78XX
> tristate "Microchip LAN78XX Based USB Ethernet Adapters"
> select MII
> select PHYLIB
> select MICROCHIP_PHY
> select FIXED_PHY
> select CRC32
>
> into (for my config):
>
> MODULE_WEAKDEP("mii");
> MODULE_WEAKDEP("microchip");
>
> then humn... why is CONFIG_MICREL (being added in this patch) not there?
> It seems even if we automatically derive that information it wouldn't
> fix the problem Jose is trying to solve.

I hoped that the 'weak dependency' towards mii and microchip could be
inferred greping for 'request_module()' in the relevant code, but
apparently it's not the case.

The MODULE_WEAKDEP() construct usage makes sense to me, but this patch
will need at least for MODULE_WEAKDEP() to land into net-next, and to
grasp more consensus in the phy land.

Cheers,

Paolo