public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Hillf Danton <hdanton@sina.com>
To: syzbot <syzbot+20d7e439f76bbbd863a7@syzkaller.appspotmail.com>
Cc: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [f2fs?] WARNING in rcu_sync_dtor
Date: Sat, 27 Jul 2024 09:16:16 +0800	[thread overview]
Message-ID: <20240727011616.2144-1-hdanton@sina.com> (raw)
In-Reply-To: <000000000000b90a8e061e21d12f@google.com>

On Fri, 26 Jul 2024 00:54:21 -0700
> syzbot found the following issue on:
> 
> HEAD commit:    1722389b0d86 Merge tag 'net-6.11-rc1' of git://git.kernel...
> git tree:       upstream
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=115edac9980000

#syz test upstream  1722389b0d86

--- x/fs/f2fs/super.c
+++ y/fs/f2fs/super.c
@@ -4169,16 +4169,7 @@ void f2fs_handle_critical_error(struct f
 	 */
 	if (continue_fs || f2fs_readonly(sb) || shutdown) {
 		f2fs_warn(sbi, "Stopped filesystem due to reason: %d", reason);
-		return;
 	}
-
-	f2fs_warn(sbi, "Remounting filesystem read-only");
-	/*
-	 * Make sure updated value of ->s_mount_flags will be visible before
-	 * ->s_flags update
-	 */
-	smp_wmb();
-	sb->s_flags |= SB_RDONLY;
 }
 
 static void f2fs_record_error_work(struct work_struct *work)
--

  parent reply	other threads:[~2024-07-27  1:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-26  7:54 [syzbot] [f2fs?] WARNING in rcu_sync_dtor syzbot
2024-07-26 15:23 ` syzbot
2024-07-29  9:10   ` Christian Brauner
2024-07-29 13:27     ` Jan Kara
2024-07-29 13:58       ` Theodore Ts'o
2024-07-30 12:38         ` Jan Kara
2024-08-01 22:28       ` Dave Chinner
2024-07-27  1:16 ` Hillf Danton [this message]
2024-07-27  1:53   ` syzbot
2024-09-11  1:48 ` Chao Yu
2024-09-11  2:12   ` syzbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240727011616.2144-1-hdanton@sina.com \
    --to=hdanton@sina.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=syzbot+20d7e439f76bbbd863a7@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox