From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 609321A38EE; Sun, 28 Jul 2024 00:56:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722128175; cv=none; b=RGKxCNMiMWDGmx3xYAxonB/IQtcPnZ+VgBL1OovXxsqbz4OIaB1bMvW9JQ2X4tCiyemIccPGnrkvsBHl2D3pCtLfFtj8oghh2i7zlF1R8HEBN8gi6/C1JJaHMRI4fq++HB+SwyetnOuvG0uEtI9u4aa+wRWyzAl+3u04fbtrq7w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722128175; c=relaxed/simple; bh=kFevJLBujr1xQ5pThVVFKbQjVbolhn003MqkEybtqMY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qGH2qe22S1YrkuGHujxu1jRmDhZEjLHMvo/WixCv08MRHFcoEDFzm/TcqHDP+Q6D+u8QASscX2mzvZwGMNk7rQuw3hYG/3eI5n/tCDdpKc/9j229hMUoCaDYhbDHsdmVijRmncJT9xtNrtylnJ+YARX5K/+E8HKn7XMPxSaDsUQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ppDEAK84; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ppDEAK84" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75C12C4AF0C; Sun, 28 Jul 2024 00:56:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722128175; bh=kFevJLBujr1xQ5pThVVFKbQjVbolhn003MqkEybtqMY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ppDEAK84Ou25+gmEUBonObP4jBzJ2sNcVB4OFlbFOhheZdy9q4lyogeSWLVhfSWYI X4L5x2fsM+Nwn1Ez6cZJbxJF2+l7cCkSdFhjK+GZDYE+Ys5XDuNvKAx8x7LWOPl4T9 IYAcBbWOfzJ5U8hA6aZdL9Du3QUS7EvbZ/j3sqkm0EQY6Si6kXvTSStaIl6JD9EdM0 x0ZTMy8c/UsYhoaD3Xx0ghKFTaMBakIiujZjUqGg8HAJNvCC5mwTmQyvM88ILfF/Oy OmGbyheITk85/pKWFJgQBJVSNOHMtN54fkkJfTMff34QW+Oqqs7o16b674PMpV8nGj lnDgbFIX1uGag== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Roman Smirnov , Jan Kara , Jan Kara , Sasha Levin Subject: [PATCH AUTOSEL 5.10 4/6] udf: prevent integer overflow in udf_bitmap_free_blocks() Date: Sat, 27 Jul 2024 20:56:01 -0400 Message-ID: <20240728005606.1735387-4-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240728005606.1735387-1-sashal@kernel.org> References: <20240728005606.1735387-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.10.223 Content-Transfer-Encoding: 8bit From: Roman Smirnov [ Upstream commit 56e69e59751d20993f243fb7dd6991c4e522424c ] An overflow may occur if the function is called with the last block and an offset greater than zero. It is necessary to add a check to avoid this. Found by Linux Verification Center (linuxtesting.org) with Svace. [JK: Make test cover also unalloc table freeing] Link: https://patch.msgid.link/20240620072413.7448-1-r.smirnov@omp.ru Suggested-by: Jan Kara Signed-off-by: Roman Smirnov Signed-off-by: Jan Kara Signed-off-by: Sasha Levin --- fs/udf/balloc.c | 36 +++++++++++++----------------------- 1 file changed, 13 insertions(+), 23 deletions(-) diff --git a/fs/udf/balloc.c b/fs/udf/balloc.c index f416b7fe092fc..aeaa6d1f0e015 100644 --- a/fs/udf/balloc.c +++ b/fs/udf/balloc.c @@ -22,6 +22,7 @@ #include "udfdecl.h" #include +#include #include "udf_i.h" #include "udf_sb.h" @@ -133,7 +134,6 @@ static void udf_bitmap_free_blocks(struct super_block *sb, { struct udf_sb_info *sbi = UDF_SB(sb); struct buffer_head *bh = NULL; - struct udf_part_map *partmap; unsigned long block; unsigned long block_group; unsigned long bit; @@ -142,19 +142,9 @@ static void udf_bitmap_free_blocks(struct super_block *sb, unsigned long overflow; mutex_lock(&sbi->s_alloc_mutex); - partmap = &sbi->s_partmaps[bloc->partitionReferenceNum]; - if (bloc->logicalBlockNum + count < count || - (bloc->logicalBlockNum + count) > partmap->s_partition_len) { - udf_debug("%u < %d || %u + %u > %u\n", - bloc->logicalBlockNum, 0, - bloc->logicalBlockNum, count, - partmap->s_partition_len); - goto error_return; - } - + /* We make sure this cannot overflow when mounting the filesystem */ block = bloc->logicalBlockNum + offset + (sizeof(struct spaceBitmapDesc) << 3); - do { overflow = 0; block_group = block >> (sb->s_blocksize_bits + 3); @@ -384,7 +374,6 @@ static void udf_table_free_blocks(struct super_block *sb, uint32_t count) { struct udf_sb_info *sbi = UDF_SB(sb); - struct udf_part_map *partmap; uint32_t start, end; uint32_t elen; struct kernel_lb_addr eloc; @@ -393,16 +382,6 @@ static void udf_table_free_blocks(struct super_block *sb, struct udf_inode_info *iinfo; mutex_lock(&sbi->s_alloc_mutex); - partmap = &sbi->s_partmaps[bloc->partitionReferenceNum]; - if (bloc->logicalBlockNum + count < count || - (bloc->logicalBlockNum + count) > partmap->s_partition_len) { - udf_debug("%u < %d || %u + %u > %u\n", - bloc->logicalBlockNum, 0, - bloc->logicalBlockNum, count, - partmap->s_partition_len); - goto error_return; - } - iinfo = UDF_I(table); udf_add_free_space(sb, sbi->s_partition, count); @@ -677,6 +656,17 @@ void udf_free_blocks(struct super_block *sb, struct inode *inode, { uint16_t partition = bloc->partitionReferenceNum; struct udf_part_map *map = &UDF_SB(sb)->s_partmaps[partition]; + uint32_t blk; + + if (check_add_overflow(bloc->logicalBlockNum, offset, &blk) || + check_add_overflow(blk, count, &blk) || + bloc->logicalBlockNum + count > map->s_partition_len) { + udf_debug("Invalid request to free blocks: (%d, %u), off %u, " + "len %u, partition len %u\n", + partition, bloc->logicalBlockNum, offset, count, + map->s_partition_len); + return; + } if (map->s_partition_flags & UDF_PART_FLAG_UNALLOC_BITMAP) { udf_bitmap_free_blocks(sb, map->s_uspace.s_bitmap, -- 2.43.0