From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02F7174E09; Sun, 28 Jul 2024 15:43:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722181433; cv=none; b=EtH9eH7jwRcT4YQfMp1XZdZMb+GT56oSsjPZq8mxFQRa9m9nqRXRYqLbezizSbycydp3fvC3wpUIH//o3YEfRUiimW/0LNX81EiJn5AN6tGAzSJl0y37wpM3TFqEcdBGzJrD98dPIO2BAumgKdb4weovDKVnC+30vnS/Z6sQWBc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722181433; c=relaxed/simple; bh=4VFj1C+cmOKvrfeeMQBQMf8ONB392pwCRvakOWRT6mc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fAHFV4TNBz454KYrYhKXh+eFOJ9Z0Bb8t6sfHe1CRhLIyCrU/qsTrHLd51bV0A+Es6De6pt6+kQsRbyN8jdOh36VkwKCFN2NhCuRmtiFGfPNg0yL+pHTRpnIqZGQtIsB4+9KJ7bt3C7xVJfpeo5BeJOZWZTMs6ra3dBTOnLvAkA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CHWLKxio; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CHWLKxio" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C90A2C32782; Sun, 28 Jul 2024 15:43:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722181432; bh=4VFj1C+cmOKvrfeeMQBQMf8ONB392pwCRvakOWRT6mc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CHWLKxiov2VxaGqfBMSbsvXfQiblHJXgbftygYA55kH0AM8vx/rngjC3flHmq39HV PjDoXqtVhRGIh3Xohr+C4yhvBnPvFyuFm090hiaC8nU9HpohDfQJvlgB4/TglzNOoy 1qHOp5dWu3A5+sWyy2lrzuGvqHGwb6jq2wKN4yOOX3PGhiyhSr7xVIp47CieXbAwLm uYfdjL1UI02tb6RYyxIrFBnWjgL3cPy3NoJakVmwmVKFi39cYp2JhCMA11d2Ju6HV0 j0I/loTXfwdiUwZocHiGbb46dRI6ts++Dm2+swYP4TUUEn+wDfoDIDKh9oh6S/oMY+ YBTW5QMlZOP2Q== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Srinivasan Shanmugam , Tom Chung , Nicholas Kazlauskas , Bhawanpreet Lakha , Rodrigo Siqueira , Roman Li , Hersen Wu , Alex Hung , Aurabindo Pillai , Harry Wentland , Alex Deucher , Sasha Levin , sunpeng.li@amd.com, christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch, wayne.lin@amd.com, mwen@igalia.com, alvin.lee2@amd.com, dillon.varone@amd.com, hanghong.ma@amd.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 6.10 14/34] drm/amd/display: Add null checks for 'stream' and 'plane' before dereferencing Date: Sun, 28 Jul 2024 11:40:38 -0400 Message-ID: <20240728154230.2046786-14-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240728154230.2046786-1-sashal@kernel.org> References: <20240728154230.2046786-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.10.2 Content-Transfer-Encoding: 8bit From: Srinivasan Shanmugam [ Upstream commit 15c2990e0f0108b9c3752d7072a97d45d4283aea ] This commit adds null checks for the 'stream' and 'plane' variables in the dcn30_apply_idle_power_optimizations function. These variables were previously assumed to be null at line 922, but they were used later in the code without checking if they were null. This could potentially lead to a null pointer dereference, which would cause a crash. The null checks ensure that 'stream' and 'plane' are not null before they are used, preventing potential crashes. Fixes the below static smatch checker: drivers/gpu/drm/amd/amdgpu/../display/dc/hwss/dcn30/dcn30_hwseq.c:938 dcn30_apply_idle_power_optimizations() error: we previously assumed 'stream' could be null (see line 922) drivers/gpu/drm/amd/amdgpu/../display/dc/hwss/dcn30/dcn30_hwseq.c:940 dcn30_apply_idle_power_optimizations() error: we previously assumed 'plane' could be null (see line 922) Cc: Tom Chung Cc: Nicholas Kazlauskas Cc: Bhawanpreet Lakha Cc: Rodrigo Siqueira Cc: Roman Li Cc: Hersen Wu Cc: Alex Hung Cc: Aurabindo Pillai Cc: Harry Wentland Signed-off-by: Srinivasan Shanmugam Reviewed-by: Aurabindo Pillai Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/display/dc/hwss/dcn30/dcn30_hwseq.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/hwss/dcn30/dcn30_hwseq.c b/drivers/gpu/drm/amd/display/dc/hwss/dcn30/dcn30_hwseq.c index ed9141a67db37..5b09d95cc5b8f 100644 --- a/drivers/gpu/drm/amd/display/dc/hwss/dcn30/dcn30_hwseq.c +++ b/drivers/gpu/drm/amd/display/dc/hwss/dcn30/dcn30_hwseq.c @@ -919,6 +919,9 @@ bool dcn30_apply_idle_power_optimizations(struct dc *dc, bool enable) stream = dc->current_state->streams[0]; plane = (stream ? dc->current_state->stream_status[0].plane_states[0] : NULL); + if (!stream || !plane) + return false; + if (stream && plane) { cursor_cache_enable = stream->cursor_position.enable && plane->address.grph.cursor_cache_addr.quad_part; -- 2.43.0