From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: "Tim Huang" <Tim.Huang@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Sasha Levin" <sashal@kernel.org>,
Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch,
shashank.sharma@amd.com, rajneesh.bhardwaj@amd.com,
Felix.Kuehling@amd.com, amd-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org
Subject: [PATCH AUTOSEL 6.6 02/20] drm/amdgpu: fix potential resource leak warning
Date: Sun, 28 Jul 2024 11:45:00 -0400 [thread overview]
Message-ID: <20240728154605.2048490-2-sashal@kernel.org> (raw)
In-Reply-To: <20240728154605.2048490-1-sashal@kernel.org>
From: Tim Huang <Tim.Huang@amd.com>
[ Upstream commit 22a5daaec0660dd19740c4c6608b78f38760d1e6 ]
Clear resource leak warning that when the prepare fails,
the allocated amdgpu job object will never be released.
Signed-off-by: Tim Huang <Tim.Huang@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c
index 349416e176a12..1cf1498204678 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c
@@ -102,6 +102,11 @@ static int amdgpu_vm_sdma_prepare(struct amdgpu_vm_update_params *p,
if (!r)
r = amdgpu_sync_push_to_job(&sync, p->job);
amdgpu_sync_free(&sync);
+
+ if (r) {
+ p->num_dw_left = 0;
+ amdgpu_job_free(p->job);
+ }
return r;
}
--
2.43.0
next prev parent reply other threads:[~2024-07-28 15:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-28 15:44 [PATCH AUTOSEL 6.6 01/20] drm/amd/display: Add delay to improve LTTPR UHBR interop Sasha Levin
2024-07-28 15:45 ` Sasha Levin [this message]
2024-07-28 15:45 ` [PATCH AUTOSEL 6.6 03/20] drm/amdgpu/pm: Fix the param type of set_power_profile_mode Sasha Levin
2024-07-28 15:45 ` [PATCH AUTOSEL 6.6 04/20] drm/amdgpu/pm: Fix the null pointer dereference for smu7 Sasha Levin
2024-07-28 15:45 ` [PATCH AUTOSEL 6.6 05/20] drm/amdgpu: Fix the null pointer dereference to ras_manager Sasha Levin
2024-07-28 15:45 ` [PATCH AUTOSEL 6.6 06/20] drm/amdgpu/pm: Fix the null pointer dereference in apply_state_adjust_rules Sasha Levin
2024-07-28 15:45 ` [PATCH AUTOSEL 6.6 07/20] drm/admgpu: fix dereferencing null pointer context Sasha Levin
2024-07-28 15:45 ` [PATCH AUTOSEL 6.6 08/20] drm/amdgpu: Add lock around VF RLCG interface Sasha Levin
2024-07-28 15:45 ` [PATCH AUTOSEL 6.6 09/20] drm/amd/pm: Fix the null pointer dereference for vega10_hwmgr Sasha Levin
2024-07-28 15:45 ` [PATCH AUTOSEL 6.6 10/20] media: amphion: Remove lock in s_ctrl callback Sasha Levin
2024-07-28 15:45 ` [PATCH AUTOSEL 6.6 11/20] drm/amd/display: Add NULL check for 'afb' before dereferencing in amdgpu_dm_plane_handle_cursor_update Sasha Levin
2024-07-28 15:45 ` [PATCH AUTOSEL 6.6 12/20] drm/amd/display: Add null checker before passing variables Sasha Levin
2024-07-28 15:45 ` [PATCH AUTOSEL 6.6 13/20] media: uvcvideo: Ignore empty TS packets Sasha Levin
2024-07-28 15:45 ` [PATCH AUTOSEL 6.6 14/20] media: uvcvideo: Fix the bandwdith quirk on USB 3.x Sasha Levin
2024-07-28 15:45 ` [PATCH AUTOSEL 6.6 15/20] media: uvcvideo: Remove mappings form uvc_device_info Sasha Levin
2024-07-28 15:45 ` [PATCH AUTOSEL 6.6 16/20] media: xc2028: avoid use-after-free in load_firmware_cb() Sasha Levin
2024-07-28 15:45 ` [PATCH AUTOSEL 6.6 17/20] ext4: fix uninitialized variable in ext4_inlinedir_to_tree Sasha Levin
2024-07-28 15:45 ` [PATCH AUTOSEL 6.6 18/20] jbd2: avoid memleak in jbd2_journal_write_metadata_buffer Sasha Levin
2024-07-28 15:45 ` [PATCH AUTOSEL 6.6 19/20] s390/sclp: Prevent release of buffer in I/O Sasha Levin
2024-07-28 15:45 ` [PATCH AUTOSEL 6.6 20/20] SUNRPC: Fix a race to wake a sync task Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240728154605.2048490-2-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=Felix.Kuehling@amd.com \
--cc=Tim.Huang@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rajneesh.bhardwaj@amd.com \
--cc=shashank.sharma@amd.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox