From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82D3677F10; Sun, 28 Jul 2024 15:46:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722181604; cv=none; b=ijvkmNjSeUu/rxDQK4GZB2Qe/m0so1xYrudUBbOgJ9q+YdSSy3RTKKlO5N/0b6r7y4BgcWfyFWC79vNkordBv5yfhD6VloMgqJBfPkpnI+2vByTZudIzcoyjK2DidmJ+TMNdkc9xcSK2sFIxuwCrUAtRil/Rlh63lDekkUGdNCI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722181604; c=relaxed/simple; bh=btrlw5K7Y/17sQ+h9eMqp5vAXw/5OjknoCfIgQbwb70=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=j/BvM4EPGXXpYTTwtGU+8SXQiG4jRdzIIeTsZFMcTaiTUWuBxJADy/vX6ZYqjsDrOQ8+jMINh/MvNdTBeFZcT19ep9+q/HAUz5QkfV3CzNNDHQthL3JpjdouAsRFamShlOO6gWOCOCSMdYIrfeSFpxS/cVM74WtPFQyEXcDkFrY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TeL1bYP+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TeL1bYP+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3216DC32782; Sun, 28 Jul 2024 15:46:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722181604; bh=btrlw5K7Y/17sQ+h9eMqp5vAXw/5OjknoCfIgQbwb70=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TeL1bYP+d1drnLb+bkH+rgScJAlR3Sw8t/45tmM901jjgb+FJeL8/5/4RzPd9rWM7 SHI+VFX4OmTzb7NdTXVxKPUaGE3ql0cJ7jZ6buOrXX8FSeIe7RhBk19wosXDRCM/hp Jx8I2E94vQtSbWrnnMQ9XO8IV26uo/3vl+nTbGLQ8aWSHeNErw2wa9ouq3a9riDOB0 n/9pqY9lcURLCpy8+mnoiBBKri0ObJUo7mdwfGz6reboZSBY2bdURM5LDoH/yU+8Ne Ny7BTKpDO87+FNAieEGAFpWIvbgX8knvE3V95YokHesLPig2Gq+HaMQgoTrpbUZItg 9iJJqigSupvAQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jesse Zhang , Jesse Zhang , Tim Huang , Alex Deucher , Sasha Levin , christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch, Hawking.Zhang@amd.com, Stanley.Yang@amd.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 6.6 07/20] drm/admgpu: fix dereferencing null pointer context Date: Sun, 28 Jul 2024 11:45:05 -0400 Message-ID: <20240728154605.2048490-7-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240728154605.2048490-1-sashal@kernel.org> References: <20240728154605.2048490-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.6.43 Content-Transfer-Encoding: 8bit From: Jesse Zhang [ Upstream commit 030ffd4d43b433bc6671d9ec34fc12c59220b95d ] When user space sets an invalid ta type, the pointer context will be empty. So it need to check the pointer context before using it Signed-off-by: Jesse Zhang Suggested-by: Tim Huang Reviewed-by: Tim Huang Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp_ta.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp_ta.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp_ta.c index ca5c86e5f7cd6..8e8afbd237bcd 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp_ta.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp_ta.c @@ -334,7 +334,7 @@ static ssize_t ta_if_invoke_debugfs_write(struct file *fp, const char *buf, size set_ta_context_funcs(psp, ta_type, &context); - if (!context->initialized) { + if (!context || !context->initialized) { dev_err(adev->dev, "TA is not initialized\n"); ret = -EINVAL; goto err_free_shared_buf; -- 2.43.0