From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB70E74055 for ; Mon, 29 Jul 2024 10:33:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.92.199 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722249187; cv=none; b=iiP0APBCubz0K8RWAVynbKJyHxW4Y7n8+7neS4yS1HdaH+W/btvpx31KiOs97VV8upGMmBG5Af8S9RSQ1HXWIxluvaSuALYeQ2L0ONllwdsnvEqpXT71fCT6nwy31QPBDm7gckL3eShPG3zVIAb2Y/QoABxxcJH7esqRc66RzpQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722249187; c=relaxed/simple; bh=wrZ2Vrzz9UaSHBLjlv9LWdkH0ZoQqsXk4bH/+N/fASM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=B9LrthrUU53tcPAwdJSB6ybXJnaT5ICROwxSpgNRd6mfYOvASJCBKXopWvqLqub7WzK3pVmdHS6LHH5ViEGG8m9ftUcGL2oNfEG0DlGtfuboEac5iYCFcngJuGSIzokwJInCl8OXw+KPf28wruGrstyKFEgXwKUrwsiQdST8eBw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=p9aNlXCf; arc=none smtp.client-ip=90.155.92.199 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="p9aNlXCf" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=QsRF1lugkwcacWv3RCI2XWI1S1pdEGwNH21atCqUwcg=; b=p9aNlXCf11wWeV7eKPkx1ECOz8 9WtsdESnUUffZmW+bYRQJgLf+BT7IE9Y4JItNygx2Aq8ZGPMOwYcAK8V1ML4POwohyBu5kZDhHL5a m+YwfvI38F+DIERXvocI+5b4zqO28z5jkoay7et19ahffkXXZf2FJD/DrV+q7iZcUmhLmEoYCCITl GZcKhYuNFwwuQZL5nzg1z632fc7p51+cIUXXPOGaWtjC2ysCg/ulUMXYVpHU4VlmBlv6YlTJxnWs6 Wiuzd4kUzyfLmPu5Tmopqa8/iJ64mq8NEnvw/hEKqOCazDLkbZ6kazDJblRvzQyf+jArpD7uGN8F1 YITiF/Vw==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.97.1 #2 (Red Hat Linux)) id 1sYNgU-00000004ldT-3bIn; Mon, 29 Jul 2024 10:32:55 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 676C4300439; Mon, 29 Jul 2024 12:32:53 +0200 (CEST) Date: Mon, 29 Jul 2024 12:32:53 +0200 From: Peter Zijlstra To: Vineeth Remanan Pillai Cc: Ingo Molnar , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , linux-kernel@vger.kernel.org, Luca Abeni , Tommaso Cucinotta , Thomas Gleixner , Joel Fernandes , Shuah Khan , Phil Auld , Suleiman Souhlal , Youssef Esmat Subject: Re: [PATCH V7 0/9] SCHED_DEADLINE server infrastructure Message-ID: <20240729103253.GE37996@noisy.programming.kicks-ass.net> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Jun 21, 2024 at 10:41:35AM -0400, Vineeth Remanan Pillai wrote: > Sorry that I could not get to reviewing and testing this revision. In > v6 we had experienced a minor bug where suspend/resume had issues with > dlserver. Since suspend does not do dequeue, dlserver is not stopped > and this causes the premature wakeups. I haven't looked at v7 in > detail, but I think the issue might still be present. It is not. > We have a workaround patch for this in our 5.15 kernel That is the problem... your necro kernel doesn't yet have the freezer rewrite I imagine: f5d39b020809 ("freezer,sched: Rewrite core freezer logic") That would cause all frozen tasks to be dequeued, and once all tasks are dequeued, the deadline server stops itself too. Juri did some testing to double check and no suspend / resume issues were found. Anyway, I've merged the lot into tip/sched/core. Thanks all!