Re: [PATCH v4 18/22] mm/zsmalloc: introduce __zpdesc_clear_movable

Alex Shi
2024-07-30T11:38:45Z

On 7/30/24 5:34 PM, Sergey Senozhatsky wrote:
> On (24/07/29 19:25), alexs@kernel.org wrote:
> [..]
>> +static inline void __zpdesc_clear_movable(struct zpdesc *zpdesc)
>> +{
>> + __ClearPageMovable(zpdesc_page(zpdesc));
>> +}
>
> [..]
>
>> @@ -846,7 +846,7 @@ static void reset_zpdesc(struct zpdesc *zpdesc)
>> {
>> struct page *page = zpdesc_page(zpdesc);
>>
>> - __ClearPageMovable(page);
>> + __zpdesc_clear_movable(zpdesc);
>> ClearPagePrivate(page);
>
> Just a quick question, I see that you wrote wrappers for pretty
> much everything, including SetPagePrivate(), but not for
> ClearPagePrivate()?

Hi Sergey,

Thanks for comment!
Yes, it's better to have one for clear, I'll sent a patch soon.

Alex