Re: [PATCH v4 18/22] mm/zsmalloc: introduce __zpdesc_clear_movable

Sergey Senozhatsky
2024-07-30T09:34:25Z

On (24/07/29 19:25), alexs@kernel.org wrote:
[..]
> +static inline void __zpdesc_clear_movable(struct zpdesc *zpdesc)
> +{
> + __ClearPageMovable(zpdesc_page(zpdesc));
> +}

[..]

> @@ -846,7 +846,7 @@ static void reset_zpdesc(struct zpdesc *zpdesc)
> {
> struct page *page = zpdesc_page(zpdesc);
>
> - __ClearPageMovable(page);
> + __zpdesc_clear_movable(zpdesc);
> ClearPagePrivate(page);

Just a quick question, I see that you wrote wrappers for pretty
much everything, including SetPagePrivate(), but not for
ClearPagePrivate()?