Re: [PATCH v2 3/5] dma-buf: heaps: support alloc async read file

kernel test robot
2024-07-31T14:44:46Z

Hi Huan,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 931a3b3bccc96e7708c82b30b2b5fa82dfd04890]

url: https://github.com/intel-lab-lkp/linux/commits/Huan-Yang/dma-buf-heaps-Introduce-DMA_HEAP_ALLOC_AND_READ_FILE-heap-flag/20240730-170340
base: 931a3b3bccc96e7708c82b30b2b5fa82dfd04890
patch link: https://lore.kernel.org/r/20240730075755.10941-4-link%40vivo.com
patch subject: [PATCH v2 3/5] dma-buf: heaps: support alloc async read file
config: xtensa-allyesconfig (https://download.01.org/0day-ci/archive/20240731/202407312202.LhLTLEhX-lkp@intel.com/config)
compiler: xtensa-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240731/202407312202.LhLTLEhX-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202407312202.LhLTLEhX-lkp@intel.com/

All warnings (new ones prefixed by >>):

drivers/dma-buf/dma-heap.c:45: warning: Function parameter or struct member 'priv' not described in 'dma_heap'
drivers/dma-buf/dma-heap.c:45: warning: Function parameter or struct member 'heap_devt' not described in 'dma_heap'
drivers/dma-buf/dma-heap.c:45: warning: Function parameter or struct member 'list' not described in 'dma_heap'
drivers/dma-buf/dma-heap.c:45: warning: Function parameter or struct member 'heap_cdev' not described in 'dma_heap'
>> drivers/dma-buf/dma-heap.c:158: warning: Function parameter or struct member 'lock' not described in 'dma_heap_file_control'
drivers/dma-buf/dma-heap.c:482: warning: expecting prototype for Trigger sync file read, read into dma(). Prototype was for dma_heap_read_file_sync() instead

vim +158 drivers/dma-buf/dma-heap.c

133
134 /**
135 * struct dma_heap_file_control - global control of dma_heap file read.
136 * @works: @dma_heap_file_work's list head.
137 *
138 * @threadwq: wait queue for @work_thread, if commit work, @work_thread
139 * wakeup and read this work's file contains.
140 *
141 * @workwq: used for main thread wait for file read end, if allocation
142 * end before file read. @dma_heap_file_task ref effect this.
143 *
144 * @work_thread: file read kthread. the dma_heap_file_task work's consumer.
145 *
146 * @heap_fwork_cachep: @dma_heap_file_work's cachep, it's alloc/free frequently.
147 *
148 * @nr_work: global number of how many work committed.
149 */
150 struct dma_heap_file_control {
151 struct list_head works;
152 spinlock_t lock; // only lock for @works.
153 wait_queue_head_t threadwq;
154 wait_queue_head_t workwq;
155 struct task_struct *work_thread;
156 struct kmem_cache *heap_fwork_cachep;
157 atomic_t nr_work;
> 158 };
159

--
0-DAY CI Kernel Test Service