Re: [PATCH v2 1/5] dma-buf: heaps: Introduce DMA_HEAP_ALLOC_AND_READ_FILE heap flag

kernel test robot
2024-07-31T11:08:35Z

Hi Huan,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 931a3b3bccc96e7708c82b30b2b5fa82dfd04890]

url: https://github.com/intel-lab-lkp/linux/commits/Huan-Yang/dma-buf-heaps-Introduce-DMA_HEAP_ALLOC_AND_READ_FILE-heap-flag/20240730-170340
base: 931a3b3bccc96e7708c82b30b2b5fa82dfd04890
patch link: https://lore.kernel.org/r/20240730075755.10941-2-link%40vivo.com
patch subject: [PATCH v2 1/5] dma-buf: heaps: Introduce DMA_HEAP_ALLOC_AND_READ_FILE heap flag
config: xtensa-allyesconfig (https://download.01.org/0day-ci/archive/20240731/202407311822.ZneNMq5I-lkp@intel.com/config)
compiler: xtensa-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240731/202407311822.ZneNMq5I-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202407311822.ZneNMq5I-lkp@intel.com/

All warnings (new ones prefixed by >>):

drivers/dma-buf/dma-heap.c:44: warning: Function parameter or struct member 'priv' not described in 'dma_heap'
drivers/dma-buf/dma-heap.c:44: warning: Function parameter or struct member 'heap_devt' not described in 'dma_heap'
drivers/dma-buf/dma-heap.c:44: warning: Function parameter or struct member 'list' not described in 'dma_heap'
drivers/dma-buf/dma-heap.c:44: warning: Function parameter or struct member 'heap_cdev' not described in 'dma_heap'
>> drivers/dma-buf/dma-heap.c:104: warning: expecting prototype for Trigger sync file read, read into dma(). Prototype was for dma_heap_read_file_sync() instead

vim +104 drivers/dma-buf/dma-heap.c

86
87 /**
88 * Trigger sync file read, read into dma-buf.
89 *
90 * @dmabuf: which we done alloced and export.
91 * @heap_file: file info wrapper to read from.
92 *
93 * Whether to use buffer I/O or direct I/O depends on the mode when the
94 * file is opened.
95 * Remember, if use direct I/O, file must be page aligned.
96 * Since the buffer used for file reading is provided by dma-buf, when
97 * using direct I/O, the file content will be directly filled into
98 * dma-buf without the need for additional CPU copying.
99 *
100 * 0 on success, negative if anything wrong.
101 */
102 static int dma_heap_read_file_sync(struct dma_buf *dmabuf,
103 struct dma_heap_file *heap_file)
> 104 {
105 struct iosys_map map;
106 ssize_t bytes;
107 int ret;
108
109 ret = dma_buf_vmap(dmabuf, &map);
110 if (ret)
111 return ret;
112
113 /**
114 * The kernel_read_file function can handle file reading effectively,
115 * and if the return value does not match the file size,
116 * then it indicates an error.
117 */
118 bytes = kernel_read_file(heap_file->file, 0, &map.vaddr, dmabuf->size,
119 &heap_file->fsize, READING_POLICY);
120 if (bytes != heap_file->fsize)
121 ret = -EIO;
122
123 dma_buf_vunmap(dmabuf, &map);
124
125 return ret;
126 }
127

--
0-DAY CI Kernel Test Service