From: Greg KH <gregkh@linuxfoundation.org>
To: Benjamin Somers <benjamin.somers@resel.fr>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
~lkcamp/patches@lists.sr.ht, helen.koike@collabora.com
Subject: Re: [PATCH] staging: rtl8723bs: Fix spacing issues
Date: Tue, 30 Jul 2024 08:52:56 +0200 [thread overview]
Message-ID: <2024073011-gory-knapsack-7235@gregkh> (raw)
In-Reply-To: <20240730064745.2473-1-benjamin.somers@resel.fr>
On Tue, Jul 30, 2024 at 06:47:45AM +0000, Benjamin Somers wrote:
> This patch fixes spacing issues reported by checkpatch on lines 39-40
>
> Signed-off-by: Benjamin Somers <benjamin.somers@resel.fr>
>
> ---
> This is my first patch to the kernel
> ---
> ---
> drivers/staging/rtl8723bs/include/osdep_service_linux.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/include/osdep_service_linux.h b/drivers/staging/rtl8723bs/include/osdep_service_linux.h
> index 188ed7e26..e470abfc2 100644
> --- a/drivers/staging/rtl8723bs/include/osdep_service_linux.h
> +++ b/drivers/staging/rtl8723bs/include/osdep_service_linux.h
> @@ -36,8 +36,8 @@
> #include <linux/list.h>
> #include <linux/vmalloc.h>
>
> -/* #include <linux/ieee80211.h> */
> - #include <net/ieee80211_radiotap.h>
> + /* #include <linux/ieee80211.h> */
> + #include <net/ieee80211_radiotap.h>
Why not just remove the commented out line entirely?
And this is indented way too much, something went wrong :(
thanks,
greg k-h
next prev parent reply other threads:[~2024-07-30 6:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 6:47 [PATCH] staging: rtl8723bs: Fix spacing issues Benjamin Somers
2024-07-30 6:52 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-07-30 7:05 Benjamin Somers
2024-07-30 14:56 ` Dan Carpenter
2020-02-12 23:08 Lukasz Szczesny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024073011-gory-knapsack-7235@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=benjamin.somers@resel.fr \
--cc=helen.koike@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=~lkcamp/patches@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox