From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C76F713B2A5; Thu, 1 Aug 2024 00:10:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722471024; cv=none; b=R8FLVk4tCOki+9joA6Jqc5EUGDDLqWCqy311uO0wCZ0IdqOiUB7aGI5ZmdrlC7Q3ARsGAuSY8c1x0cqiTEhfw0eZoXJgjQZMEEmMCwnvFvMOzVBMeQjSny/MXovm0vTvTxa3T58ei4fBDX3NhGpFabNMYbFoDVGiEgQd/NOTBio= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722471024; c=relaxed/simple; bh=54RIT+Onb6an8cT92H4szPSbam51k7rmIL1nt84hD2Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CN2GHqNyw8UD24zXnPQXBRHe7/FHuvLu9MkwLyM2lJlvGQYcJt0ZcANOcY0MGLyo2o50z44GUs7upDle5n50wNtZhWEqPRyoGHqQRr8HnYPl7gdbEONmjI+q7cwEcBR7X9ffJcIS+2Qq2AS6u1xe7x0rnX+dPzUcxagqam6C2EA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=nL3qkbbT; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nL3qkbbT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 93BCEC116B1; Thu, 1 Aug 2024 00:10:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722471024; bh=54RIT+Onb6an8cT92H4szPSbam51k7rmIL1nt84hD2Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nL3qkbbTiAztJwY907NWsqUO0m9VyhslWHiotDyQBNpqQ57fCNgdgIfwZkuxniMyT Vosnnwio0R559ORTi/yQEVqbKk1DAnmQTMD2Rh5WtbhwNmeAIBGA2InmP06uMaBPx7 d78zLztTtJWd9jtRHcD+ENUB+FPEL1hZsnZoI0dY0PtCW7FB0MKVDpB3jKBVCRDIHc Q8xwx/mKimqhtdOm9NaXbnRuvnlImQQzQGpSUGQwVLbZvfkbbBPTMtWMyMusk1b9BD 3fhli+FX6N8YtreJQFJO8/JnnmndZkYc4mHAWyLkYjPz0BYVTwUQPkgUJxDH9JDH3D GO3lBWhapiipQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Alex Hung , Harry Wentland , Tom Chung , Daniel Wheeler , Alex Deucher , Sasha Levin , sunpeng.li@amd.com, Rodrigo.Siqueira@amd.com, christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 6.10 020/121] drm/amd/display: Check msg_id before processing transcation Date: Wed, 31 Jul 2024 19:59:18 -0400 Message-ID: <20240801000834.3930818-20-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240801000834.3930818-1-sashal@kernel.org> References: <20240801000834.3930818-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.10.2 Content-Transfer-Encoding: 8bit From: Alex Hung [ Upstream commit fa71face755e27dc44bc296416ebdf2c67163316 ] [WHY & HOW] HDCP_MESSAGE_ID_INVALID (-1) is not a valid msg_id nor is it a valid array index, and it needs checking before used. This fixes 4 OVERRUN issues reported by Coverity. Reviewed-by: Harry Wentland Acked-by: Tom Chung Signed-off-by: Alex Hung Tested-by: Daniel Wheeler Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/display/dc/hdcp/hdcp_msg.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/hdcp/hdcp_msg.c b/drivers/gpu/drm/amd/display/dc/hdcp/hdcp_msg.c index 99e17c164ce7b..1d3e8f0b915b6 100644 --- a/drivers/gpu/drm/amd/display/dc/hdcp/hdcp_msg.c +++ b/drivers/gpu/drm/amd/display/dc/hdcp/hdcp_msg.c @@ -128,13 +128,21 @@ static bool hdmi_14_process_transaction( const uint8_t hdcp_i2c_addr_link_primary = 0x3a; /* 0x74 >> 1*/ const uint8_t hdcp_i2c_addr_link_secondary = 0x3b; /* 0x76 >> 1*/ struct i2c_command i2c_command; - uint8_t offset = hdcp_i2c_offsets[message_info->msg_id]; + uint8_t offset; struct i2c_payload i2c_payloads[] = { - { true, 0, 1, &offset }, + { true, 0, 1, 0 }, /* actual hdcp payload, will be filled later, zeroed for now*/ { 0 } }; + if (message_info->msg_id == HDCP_MESSAGE_ID_INVALID) { + DC_LOG_ERROR("%s: Invalid message_info msg_id - %d\n", __func__, message_info->msg_id); + return false; + } + + offset = hdcp_i2c_offsets[message_info->msg_id]; + i2c_payloads[0].data = &offset; + switch (message_info->link) { case HDCP_LINK_SECONDARY: i2c_payloads[0].address = hdcp_i2c_addr_link_secondary; @@ -308,6 +316,11 @@ static bool dp_11_process_transaction( struct dc_link *link, struct hdcp_protection_message *message_info) { + if (message_info->msg_id == HDCP_MESSAGE_ID_INVALID) { + DC_LOG_ERROR("%s: Invalid message_info msg_id - %d\n", __func__, message_info->msg_id); + return false; + } + return dpcd_access_helper( link, message_info->length, -- 2.43.0