From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A26C12E1D1; Thu, 1 Aug 2024 00:21:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722471719; cv=none; b=Sz7za9prYhLsEx6Du/ROXb2ggRR7Pxw2AqqANX1xEGIvE4+cLyFO3tH3M6v/mjE8xgMPNdOu5NtEA3GBGjvFOly71DWHbscb75Z1uni4PWkh25i0hFYoeq68LFfxpgo3m+mYWW6IDBmpwIngKnxb8YW7GBm7f8aHYuq+E4Xsfdc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722471719; c=relaxed/simple; bh=cwPs0m+gOE625z9U+MG2gyHPE54rMUGLpyR1T9LRCtY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=K609HgRDm7B3QPbiK6+ehefIT7gkJI3EyLefpLFnWoj+gXK/IUe9yjlAu9HJ/XcQEHx55O7m0TJm+qKhIEUtT+vIDOlD0kqpzvKxMgXb3ykJ7slTRw/tAjOxS4uRmPRO2gxm6TSHZoxNxwZavJIfWb3z11fi7LqK3Spu1AatDk8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZInq6htM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZInq6htM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 61A0AC4AF0C; Thu, 1 Aug 2024 00:21:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722471719; bh=cwPs0m+gOE625z9U+MG2gyHPE54rMUGLpyR1T9LRCtY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZInq6htMt1Sg9vDmkZ4x5ZgoC7Ps6pbX2ThlyEuyLSPfYz5hWkmy5PlY+az9BgcjQ ztO+Gtu9RAE7W0MxWsxfs6p2+6C7Bf8KvuDuIrZRcuPgZi871IMzYh2TBV+8fyaPB8 iKPsCoBr5fTRoqBJpo5r4g/k7c7MCqq4Q5T+UcNIATwZeTnsLwuZAIePzbmvVJtoAv W4nya80THcHnjObOj9aJDA0vdbzpYI3yiaKqedKAQ3Z/96f1p2rlXQvn0C8F+3qs2b KRBHR13ELDtXPQT0y81IPfc1ggZyGO8pbnFAK0UZK5wEWNKxjwiQIDzKy8jtEXLFn9 X4rFsokcmY2NA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Alex Hung , Rodrigo Siqueira , Tom Chung , Daniel Wheeler , Alex Deucher , Sasha Levin , harry.wentland@amd.com, sunpeng.li@amd.com, Rodrigo.Siqueira@amd.com, christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch, wenjing.liu@amd.com, aurabindo.pillai@amd.com, zhikai.zhai@amd.com, ivlipski@amd.com, michael.strauss@amd.com, sungjoon.kim@amd.com, cruise.hung@amd.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 6.6 10/83] drm/amd/display: Check index for aux_rd_interval before using Date: Wed, 31 Jul 2024 20:17:25 -0400 Message-ID: <20240801002107.3934037-10-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240801002107.3934037-1-sashal@kernel.org> References: <20240801002107.3934037-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.6.43 Content-Transfer-Encoding: 8bit From: Alex Hung [ Upstream commit 9ba2ea6337b4f159aecb177555a6a81da92d302e ] aux_rd_interval has size of 7 and should be checked. This fixes 3 OVERRUN and 1 INTEGER_OVERFLOW issues reported by Coverity. Reviewed-by: Rodrigo Siqueira Acked-by: Tom Chung Signed-off-by: Alex Hung Tested-by: Daniel Wheeler Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- .../gpu/drm/amd/display/dc/link/protocols/link_dp_training.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_training.c b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_training.c index 16a62e0187122..9d1adfc09fb2a 100644 --- a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_training.c +++ b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_training.c @@ -914,10 +914,10 @@ static enum dc_status configure_lttpr_mode_non_transparent( /* Driver does not need to train the first hop. Skip DPCD read and clear * AUX_RD_INTERVAL for DPTX-to-DPIA hop. */ - if (link->ep_type == DISPLAY_ENDPOINT_USB4_DPIA) + if (link->ep_type == DISPLAY_ENDPOINT_USB4_DPIA && repeater_cnt > 0 && repeater_cnt < MAX_REPEATER_CNT) link->dpcd_caps.lttpr_caps.aux_rd_interval[--repeater_cnt] = 0; - for (repeater_id = repeater_cnt; repeater_id > 0; repeater_id--) { + for (repeater_id = repeater_cnt; repeater_id > 0 && repeater_id < MAX_REPEATER_CNT; repeater_id--) { aux_interval_address = DP_TRAINING_AUX_RD_INTERVAL_PHY_REPEATER1 + ((DP_REPEATER_CONFIGURATION_AND_STATUS_SIZE) * (repeater_id - 1)); core_link_read_dpcd( -- 2.43.0