From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Guenter Roeck <linux@roeck-us.net>,
Sasha Levin <sashal@kernel.org>,
jdelvare@suse.com, linux-hwmon@vger.kernel.org
Subject: [PATCH AUTOSEL 6.6 79/83] hwmon: (nct6775-core) Fix underflows seen when writing limit attributes
Date: Wed, 31 Jul 2024 20:18:34 -0400 [thread overview]
Message-ID: <20240801002107.3934037-79-sashal@kernel.org> (raw)
In-Reply-To: <20240801002107.3934037-1-sashal@kernel.org>
From: Guenter Roeck <linux@roeck-us.net>
[ Upstream commit 0403e10bf0824bf0ec2bb135d4cf1c0cc3bf4bf0 ]
DIV_ROUND_CLOSEST() after kstrtol() results in an underflow if a large
negative number such as -9223372036854775808 is provided by the user.
Fix it by reordering clamp_val() and DIV_ROUND_CLOSEST() operations.
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/hwmon/nct6775-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/nct6775-core.c b/drivers/hwmon/nct6775-core.c
index f3bf2e4701c38..8da7aa1614d7d 100644
--- a/drivers/hwmon/nct6775-core.c
+++ b/drivers/hwmon/nct6775-core.c
@@ -2262,7 +2262,7 @@ store_temp_offset(struct device *dev, struct device_attribute *attr,
if (err < 0)
return err;
- val = clamp_val(DIV_ROUND_CLOSEST(val, 1000), -128, 127);
+ val = DIV_ROUND_CLOSEST(clamp_val(val, -128000, 127000), 1000);
mutex_lock(&data->update_lock);
data->temp_offset[nr] = val;
--
2.43.0
next prev parent reply other threads:[~2024-08-01 0:26 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-01 0:17 [PATCH AUTOSEL 6.6 01/83] drm/amd/display: Assign linear_pitch_alignment even for VM Sasha Levin
2024-08-01 0:17 ` [PATCH AUTOSEL 6.6 02/83] drm/amdgpu: fix overflowed array index read warning Sasha Levin
2024-08-01 0:17 ` [PATCH AUTOSEL 6.6 03/83] drm/amdgpu/pm: Check the return value of smum_send_msg_to_smc Sasha Levin
2024-08-01 0:17 ` [PATCH AUTOSEL 6.6 04/83] drm/amd/pm: fix warning using uninitialized value of max_vid_step Sasha Levin
2024-08-01 0:17 ` [PATCH AUTOSEL 6.6 05/83] drm/amd/pm: Fix negative array index read Sasha Levin
2024-08-01 0:17 ` [PATCH AUTOSEL 6.6 06/83] drm/amd/pm: fix the Out-of-bounds read warning Sasha Levin
2024-08-01 0:17 ` [PATCH AUTOSEL 6.6 07/83] drm/amd/display: Check gpio_id before used as array index Sasha Levin
2024-08-01 0:17 ` [PATCH AUTOSEL 6.6 08/83] drm/amd/display: Add NULL pointer and OVERRUN check within amdgpu_dm irq register Sasha Levin
2024-08-01 0:17 ` [PATCH AUTOSEL 6.6 09/83] drm/amd/display: Stop amdgpu_dm initialize when stream nums greater than 6 Sasha Levin
2024-08-01 0:17 ` [PATCH AUTOSEL 6.6 10/83] drm/amd/display: Check index for aux_rd_interval before using Sasha Levin
2024-08-01 0:17 ` [PATCH AUTOSEL 6.6 11/83] drm/amd/display: Add array index check for hdcp ddc access Sasha Levin
2024-08-01 0:17 ` [PATCH AUTOSEL 6.6 12/83] drm/amd/display: Check num_valid_sets before accessing reader_wm_sets[] Sasha Levin
2024-08-01 0:17 ` [PATCH AUTOSEL 6.6 13/83] drm/amd/display: Skip updating link encoder for unknown eng_id Sasha Levin
2024-08-01 0:17 ` [PATCH AUTOSEL 6.6 14/83] drm/amd/display: Check msg_id before processing transcation Sasha Levin
2024-08-01 0:17 ` [PATCH AUTOSEL 6.6 15/83] drm/amd/display: Fix Coverity INTERGER_OVERFLOW within construct_integrated_info Sasha Levin
2024-08-01 0:17 ` [PATCH AUTOSEL 6.6 16/83] drm/amd/display: Fix Coverity INTEGER_OVERFLOW within dal_gpio_service_create Sasha Levin
2024-08-01 0:17 ` [PATCH AUTOSEL 6.6 17/83] drm/amd/display: Spinlock before reading event Sasha Levin
2024-08-01 0:17 ` [PATCH AUTOSEL 6.6 18/83] drm/amd/display: Fix Coverity INTEGER_OVERFLOW within decide_fallback_link_setting_max_bw_policy Sasha Levin
2024-08-01 0:17 ` [PATCH AUTOSEL 6.6 19/83] drm/amd/display: Skip inactive planes within ModeSupportAndSystemConfiguration Sasha Levin
2024-08-01 0:17 ` [PATCH AUTOSEL 6.6 20/83] drm/amd/display: Fix index may exceed array range within fpu_update_bw_bounding_box Sasha Levin
2024-08-01 0:17 ` [PATCH AUTOSEL 6.6 21/83] drm/amd/amdgpu: Check tbo resource pointer Sasha Levin
2024-08-01 0:17 ` [PATCH AUTOSEL 6.6 22/83] drm/amdgpu: Fix out-of-bounds write warning Sasha Levin
2024-08-01 0:17 ` [PATCH AUTOSEL 6.6 23/83] drm/amdkfd: Check debug trap enable before write dbg_ev_file Sasha Levin
2024-08-01 0:17 ` [PATCH AUTOSEL 6.6 24/83] drm/amdgpu: Fix out-of-bounds read of df_v1_7_channel_number Sasha Levin
2024-08-01 0:17 ` [PATCH AUTOSEL 6.6 25/83] drm/amdgpu: fix ucode out-of-bounds read warning Sasha Levin
2024-08-01 0:17 ` [PATCH AUTOSEL 6.6 26/83] drm/amdgpu: fix mc_data " Sasha Levin
2024-08-01 0:17 ` [PATCH AUTOSEL 6.6 27/83] drm/amdkfd: Reconcile the definition and use of oem_id in struct kfd_topology_device Sasha Levin
2024-08-01 0:17 ` [PATCH AUTOSEL 6.6 28/83] wifi: ath12k: initialize 'ret' in ath12k_qmi_load_file_target_mem() Sasha Levin
2024-08-01 0:17 ` [PATCH AUTOSEL 6.6 29/83] wifi: ath11k: initialize 'ret' in ath11k_qmi_load_file_target_mem() Sasha Levin
2024-08-01 0:17 ` [PATCH AUTOSEL 6.6 30/83] drm/amdgpu/pm: Check input value for CUSTOM profile mode setting on legacy SOCs Sasha Levin
2024-08-01 0:17 ` [PATCH AUTOSEL 6.6 31/83] drm/amdgpu: Fix the warning division or modulo by zero Sasha Levin
2024-08-01 0:17 ` [PATCH AUTOSEL 6.6 32/83] drm/amdgpu: fix dereference after null check Sasha Levin
2024-08-01 0:17 ` [PATCH AUTOSEL 6.6 33/83] drm/amdgpu: fix the waring dereferencing hive Sasha Levin
2024-08-01 0:17 ` [PATCH AUTOSEL 6.6 34/83] drm/amdgpu: the warning dereferencing obj for nbio_v7_4 Sasha Levin
2024-08-01 0:17 ` [PATCH AUTOSEL 6.6 35/83] drm/amdgpu: update type of buf size to u32 for eeprom functions Sasha Levin
2024-08-01 0:17 ` [PATCH AUTOSEL 6.6 36/83] wifi: iwlwifi: fw: avoid bad FW config on RXQ DMA failure Sasha Levin
2024-08-01 0:17 ` [PATCH AUTOSEL 6.6 37/83] cpufreq: scmi: Avoid overflow of target_freq in fast switch Sasha Levin
2024-08-01 0:17 ` [PATCH AUTOSEL 6.6 38/83] bpf, net: Use DEV_STAT_INC() Sasha Levin
2024-08-01 0:17 ` [PATCH AUTOSEL 6.6 39/83] PCI: al: Check IORESOURCE_BUS existence during probe Sasha Levin
2024-08-01 0:17 ` [PATCH AUTOSEL 6.6 40/83] hwspinlock: Introduce hwspin_lock_bust() Sasha Levin
2024-08-01 0:17 ` [PATCH AUTOSEL 6.6 41/83] soc: qcom: smem: Add qcom_smem_bust_hwspin_lock_by_host() Sasha Levin
2024-08-01 0:17 ` [PATCH AUTOSEL 6.6 42/83] gpiolib: cdev: Add INIT_KFIFO() for linereq events Sasha Levin
2024-08-01 0:17 ` [PATCH AUTOSEL 6.6 43/83] pwm: xilinx: Fix u32 overflow issue in 32-bit width PWM mode Sasha Levin
2024-08-01 0:17 ` [PATCH AUTOSEL 6.6 44/83] drm/amdgu: fix Unintentional integer overflow for mall size Sasha Levin
2024-08-01 0:18 ` [PATCH AUTOSEL 6.6 45/83] smack: tcp: ipv4, fix incorrect labeling Sasha Levin
2024-08-01 0:18 ` [PATCH AUTOSEL 6.6 46/83] drm/bridge: tc358767: Check if fully initialized before signalling HPD event via IRQ Sasha Levin
2024-08-01 0:18 ` [PATCH AUTOSEL 6.6 47/83] EDAC/amd64: Check return value of amd_smn_read() Sasha Levin
2024-08-01 0:18 ` [PATCH AUTOSEL 6.6 48/83] hwmon: (k10temp) " Sasha Levin
2024-08-01 0:18 ` [PATCH AUTOSEL 6.6 49/83] wifi: cfg80211: make hash table duplicates more survivable Sasha Levin
2024-08-01 0:18 ` [PATCH AUTOSEL 6.6 50/83] driver: iio: add missing checks on iio_info's callback access Sasha Levin
2024-08-01 0:18 ` [PATCH AUTOSEL 6.6 51/83] drm/amd/display: added NULL check at start of dc_validate_stream Sasha Levin
2024-08-01 0:18 ` [PATCH AUTOSEL 6.6 52/83] drm/amd/display: Correct the defined value for AMDGPU_DMUB_NOTIFICATION_MAX Sasha Levin
2024-08-01 0:18 ` [PATCH AUTOSEL 6.6 53/83] drm/amd/display: use preferred link settings for dp signal only Sasha Levin
2024-08-01 0:18 ` [PATCH AUTOSEL 6.6 54/83] drm/amd/display: Check BIOS images before it is used Sasha Levin
2024-08-01 0:18 ` [PATCH AUTOSEL 6.6 55/83] drm/amd/display: Skip wbscl_set_scaler_filter if filter is null Sasha Levin
2024-08-01 0:18 ` [PATCH AUTOSEL 6.6 56/83] fou: remove warn in gue_gro_receive on unsupported protocol Sasha Levin
2024-08-01 0:18 ` [PATCH AUTOSEL 6.6 57/83] ALSA: vmaster: Return error for invalid input values Sasha Levin
2024-08-01 0:18 ` [PATCH AUTOSEL 6.6 58/83] ALSA: control: Apply sanity check of input values for user elements Sasha Levin
2024-08-01 0:18 ` [PATCH AUTOSEL 6.6 59/83] wifi: ath12k: fix uninitialize symbol error on ath12k_peer_assoc_h_he() Sasha Levin
2024-08-01 0:18 ` [PATCH AUTOSEL 6.6 60/83] wifi: ath12k: fix firmware crash due to invalid peer nss Sasha Levin
2024-08-01 0:18 ` [PATCH AUTOSEL 6.6 61/83] ELF: fix kernel.randomize_va_space double read Sasha Levin
2024-08-01 0:18 ` [PATCH AUTOSEL 6.6 62/83] accel/habanalabs/gaudi2: unsecure edma max outstanding register Sasha Levin
2024-08-01 0:18 ` [PATCH AUTOSEL 6.6 63/83] x86/kmsan: Fix hook for unaligned accesses Sasha Levin
2024-08-01 0:18 ` [PATCH AUTOSEL 6.6 64/83] udf: Avoid excessive partition lengths Sasha Levin
2024-08-01 0:18 ` [PATCH AUTOSEL 6.6 65/83] riscv: mm: Take memory hotplug read-lock during kernel page table dump Sasha Levin
2024-08-01 0:18 ` [PATCH AUTOSEL 6.6 66/83] usb: uas: set host status byte on data completion error Sasha Levin
2024-08-01 0:18 ` [PATCH AUTOSEL 6.6 67/83] drm/amd/display: Run DC_LOG_DC after checking link->link_enc Sasha Levin
2024-08-01 0:18 ` [PATCH AUTOSEL 6.6 68/83] drm/amd/display: Check HDCP returned status Sasha Levin
2024-08-01 0:18 ` [PATCH AUTOSEL 6.6 69/83] drm/amd/display: Check denominator pbn_div before used Sasha Levin
2024-08-01 0:18 ` [PATCH AUTOSEL 6.6 70/83] phy: zynqmp: Take the phy mutex in xlate Sasha Levin
2024-08-01 0:18 ` [PATCH AUTOSEL 6.6 71/83] cgroup: Protect css->cgroup write under css_set_lock Sasha Levin
2024-08-01 0:18 ` [PATCH AUTOSEL 6.6 72/83] um: line: always fill *error_out in setup_one_line() Sasha Levin
2024-08-01 0:18 ` [PATCH AUTOSEL 6.6 73/83] devres: Initialize an uninitialized struct member Sasha Levin
2024-08-01 0:18 ` [PATCH AUTOSEL 6.6 74/83] pci/hotplug/pnv_php: Fix hotplug driver crash on Powernv Sasha Levin
2024-08-01 0:18 ` [PATCH AUTOSEL 6.6 75/83] virtio_ring: fix KMSAN error for premapped mode Sasha Levin
2024-08-01 0:18 ` [PATCH AUTOSEL 6.6 76/83] wifi: rtw88: usb: schedule rx work after everything is set up Sasha Levin
2024-08-01 0:18 ` [PATCH AUTOSEL 6.6 77/83] scsi: pm80xx: Set phy->enable_completion only when we wait for it Sasha Levin
2024-08-01 0:18 ` [PATCH AUTOSEL 6.6 78/83] hwmon: (lm95234) Fix underflows seen when writing limit attributes Sasha Levin
2024-08-01 0:18 ` Sasha Levin [this message]
2024-08-01 0:18 ` [PATCH AUTOSEL 6.6 80/83] hwmon: (w83627ehf) " Sasha Levin
2024-08-01 0:18 ` [PATCH AUTOSEL 6.6 81/83] libbpf: Add NULL checks to bpf_object__{prev_map,next_map} Sasha Levin
2024-08-01 0:18 ` [PATCH AUTOSEL 6.6 82/83] wifi: mwifiex: Do not return unused priv in mwifiex_get_priv_by_id() Sasha Levin
2024-08-01 0:18 ` [PATCH AUTOSEL 6.6 83/83] i3c: mipi-i3c-hci: Error out instead on BUG_ON() in IBI DMA setup Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240801002107.3934037-79-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox