From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CF5614AD1B; Thu, 1 Aug 2024 00:33:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722472432; cv=none; b=ewtIpctAyZJXQ728wBPjgo8qqi+PSoa1di4lPce/44LwQq7QYKb/Z2nkdX4KLvE4tMp4g+gy8pUIK9CiIa/2H+mZOKe1JzuKSj7tlrvdqtNvy74SpF2zPLdcUlW/6CNEJlR1u/klVdLMlJGH1jJotBHSywtuHNRR4CrTULsreG0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722472432; c=relaxed/simple; bh=0e3kUQWfO5rovM/j7DUwV+br2dxpTo2g/vOKB6meS0c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=b+90lusCB+dRGEV9B0W5UecNAh62pmTjZO74cBlwrjMBriR+tpCOXg8mh/u4aLjc4NkgRkvwJXPigFQg2FjL7Lj9up1OjKN2RAlh1Y5MXYrrGPCi2xJN2hwOSkTGAK3ja1fMgHxy8nJeeYTi1U8/5H/kTccKMY5MVly3jX3agjk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QvUKcjtK; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QvUKcjtK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F3E8CC116B1; Thu, 1 Aug 2024 00:33:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722472431; bh=0e3kUQWfO5rovM/j7DUwV+br2dxpTo2g/vOKB6meS0c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QvUKcjtK82O/cFC0o9kBs6/Mf0S2qSl0tId0VEE/mk1q9drsD4GKCuE+yCxNrilsD GDhbxoyGL9yNlLXzEheawRhayLouTXp0+MjadVT4IZGrTHsGl6RLdVYfM6bfHGYHwT wy0hudlZG93/Welum3UZoDfwfbW5faWXT28gbKKtDHqN9kHKlfCbr+sj2a0a/QqMv/ rm7J/ldwx3FqNsVKrUC67dKjwEsDRgGuM2s8cPONszvsgAWWBEwRtZ30R+NJAez65g 9N1Fu/5gnCnymbC/eCPIQ6jF/SGKL/zjkUh+7piTq0JgD5M71AKCkzhRZvpU1PDZgk RogP90Syh/1YQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Hersen Wu , Harry Wentland , Tom Chung , Daniel Wheeler , Alex Deucher , Sasha Levin , sunpeng.li@amd.com, Rodrigo.Siqueira@amd.com, christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch, alex.hung@amd.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 5.15 12/47] drm/amd/display: Fix Coverity INTEGER_OVERFLOW within dal_gpio_service_create Date: Wed, 31 Jul 2024 20:31:02 -0400 Message-ID: <20240801003256.3937416-12-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240801003256.3937416-1-sashal@kernel.org> References: <20240801003256.3937416-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.15.164 Content-Transfer-Encoding: 8bit From: Hersen Wu [ Upstream commit c6077aa66fa230d12f37fef01161ef080d13b726 ] [Why] For subtraction, coverity reports integer overflow warning message when variable type is uint32_t. [How] Change variable type to int32_t. Reviewed-by: Harry Wentland Acked-by: Tom Chung Signed-off-by: Hersen Wu Tested-by: Daniel Wheeler Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/display/dc/gpio/gpio_service.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/gpio/gpio_service.c b/drivers/gpu/drm/amd/display/dc/gpio/gpio_service.c index a7c92c64490c5..a5de27908914c 100644 --- a/drivers/gpu/drm/amd/display/dc/gpio/gpio_service.c +++ b/drivers/gpu/drm/amd/display/dc/gpio/gpio_service.c @@ -58,7 +58,7 @@ struct gpio_service *dal_gpio_service_create( struct dc_context *ctx) { struct gpio_service *service; - uint32_t index_of_id; + int32_t index_of_id; service = kzalloc(sizeof(struct gpio_service), GFP_KERNEL); @@ -114,7 +114,7 @@ struct gpio_service *dal_gpio_service_create( return service; failure_2: - while (index_of_id) { + while (index_of_id > 0) { --index_of_id; kfree(service->busyness[index_of_id]); } -- 2.43.0