From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E19721DE0FF; Thu, 1 Aug 2024 00:35:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722472532; cv=none; b=lgHwu5Y+2KyGRdewM0C9d44t+gnC7Rbq9fgjXW+JgLh0PbUIUu9vDlKbFo9c/mNOs/2ppQ9+pxZQvx5VNlHNnFmLfJ6yvuApqPM9va7JkDAHdLWSQgc1bialMxOvU6LTV5veRlm2WUBzKVaxfyitoIYzLD6XD+l35YgQdd40vvE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722472532; c=relaxed/simple; bh=O2BLuasox0+3fbluWb/+lkR7LS/BWyUFFsFtM6gtuC0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bUdfOT4dzsgq35jeu/P9UWDIk0uElH6QehdWOc9RR2re4zUHFdMwLG2YBbzOR8DgrbhXQNbVy7abE1WnZL3Ff3E+F8QnDKMbMeiH6aJYh9olSp+7NYZ8dGNGfRDSKHYzFD212juZEIk8DKUayWWrSUJO3mdqMbqWYhYqVdTOYe4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bfWLhB6F; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bfWLhB6F" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B1B3CC4AF0F; Thu, 1 Aug 2024 00:35:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722472531; bh=O2BLuasox0+3fbluWb/+lkR7LS/BWyUFFsFtM6gtuC0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bfWLhB6F/V98G0h3nQFsJx9XPcF4lVNDV5zECJsMRvWCBi/ODZPJr/x5pPXkwPPRN fD1ebau2vjZOlyD6mPZEDqlcJLm+4z1Ub1OlvAYXeGktbPmwm14kwZWyVeLDHGnLmt wrPOEzn9NCRdC7aVPu30BvgBFe02S0dalr8NFkBOt1wHBh5mGDMZUPxX0Stm+YW6xx pOavMFGWlSjxk0xMe3WJeTNEkAn28o6X+UK/xus3dwXYh5Qh7d7dMMEFFAb9yspZTW rdp6RS/x3QrGpRmELggkI8OMN9N7SrNU2I27vgkuXRLqcaPrYX+7nqyOneWJPDCA5r aGixmOo+T07Uw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Guenter Roeck , Sasha Levin , jdelvare@suse.com, linux-hwmon@vger.kernel.org Subject: [PATCH AUTOSEL 5.15 43/47] hwmon: (lm95234) Fix underflows seen when writing limit attributes Date: Wed, 31 Jul 2024 20:31:33 -0400 Message-ID: <20240801003256.3937416-43-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240801003256.3937416-1-sashal@kernel.org> References: <20240801003256.3937416-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.15.164 Content-Transfer-Encoding: 8bit From: Guenter Roeck [ Upstream commit af64e3e1537896337405f880c1e9ac1f8c0c6198 ] DIV_ROUND_CLOSEST() after kstrtol() results in an underflow if a large negative number such as -9223372036854775808 is provided by the user. Fix it by reordering clamp_val() and DIV_ROUND_CLOSEST() operations. Signed-off-by: Guenter Roeck Signed-off-by: Sasha Levin --- drivers/hwmon/lm95234.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/hwmon/lm95234.c b/drivers/hwmon/lm95234.c index ac169a994ae00..db2aecdfbd17c 100644 --- a/drivers/hwmon/lm95234.c +++ b/drivers/hwmon/lm95234.c @@ -301,7 +301,8 @@ static ssize_t tcrit2_store(struct device *dev, struct device_attribute *attr, if (ret < 0) return ret; - val = clamp_val(DIV_ROUND_CLOSEST(val, 1000), 0, index ? 255 : 127); + val = DIV_ROUND_CLOSEST(clamp_val(val, 0, (index ? 255 : 127) * 1000), + 1000); mutex_lock(&data->update_lock); data->tcrit2[index] = val; @@ -350,7 +351,7 @@ static ssize_t tcrit1_store(struct device *dev, struct device_attribute *attr, if (ret < 0) return ret; - val = clamp_val(DIV_ROUND_CLOSEST(val, 1000), 0, 255); + val = DIV_ROUND_CLOSEST(clamp_val(val, 0, 255000), 1000); mutex_lock(&data->update_lock); data->tcrit1[index] = val; @@ -391,7 +392,7 @@ static ssize_t tcrit1_hyst_store(struct device *dev, if (ret < 0) return ret; - val = DIV_ROUND_CLOSEST(val, 1000); + val = DIV_ROUND_CLOSEST(clamp_val(val, -255000, 255000), 1000); val = clamp_val((int)data->tcrit1[index] - val, 0, 31); mutex_lock(&data->update_lock); @@ -431,7 +432,7 @@ static ssize_t offset_store(struct device *dev, struct device_attribute *attr, return ret; /* Accuracy is 1/2 degrees C */ - val = clamp_val(DIV_ROUND_CLOSEST(val, 500), -128, 127); + val = DIV_ROUND_CLOSEST(clamp_val(val, -64000, 63500), 500); mutex_lock(&data->update_lock); data->toffset[index] = val; -- 2.43.0