From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7372F1E1292; Thu, 1 Aug 2024 00:38:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722472682; cv=none; b=I18ziZvxHrD7q+hxokU1dB29rhAUNziTAJWz7FVMuKrmBZq1J+Y0CEBAEZVjIWP6ad5nM6wlmrleczq92gFjIhFmsEEZY4WNAY1yS35z2tawtDCaLtiTmU9PLhwRjR7z1KTtY3IL4TEA5cKRh4+Ettq+tKvjfZiQIycV0xTup/8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722472682; c=relaxed/simple; bh=vfg3LIfjr9vJg/PUieupy+OhvyWJAJ0LSR0P7NVNnYQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Km7HBh21q3757lmal2WTVWmJ2k1MQmm7LBpOu8rZh2cBUl/LfEZGeaIO175bG7YUFEjNQke/5qqE7hl242lZmblIuL9FVfjE+b2ksBDZVfpC3VvBNHw3sltCPgoq5LFW4cfw5VNBfJ38H/QtGZf9hAEqeuAWqq5ma4quGk9UjNI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Ys9rayaS; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Ys9rayaS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 01FEFC116B1; Thu, 1 Aug 2024 00:37:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722472682; bh=vfg3LIfjr9vJg/PUieupy+OhvyWJAJ0LSR0P7NVNnYQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ys9rayaS6HXbvkGSe2SqGXRIYGi0Ij2MbQnA2DyyVc8Pr1SkPgSYgkdVmIkAEsLpa 66kQ2ggAqd0OUC75vEG+Jt08oTGnHnWeseTD+EBGjrXfTS5pjTE9EriHs+Lo0QOHw8 k1tL8+0wJZ8CSHkEb9vzvHy941ookzUxeYqUG2cokZ7KM8ST82uz1ONOpjbMnmTP+1 GY5wTYp55ZKUi1hnVmDULyzGoeehmKGLDKw2DEzy4C+qRjXQj8RHr/GiWVUAtYS+8B /W6IVxbA0fpcN2dh+TYxhZViekyJB9tuhXpFLCQ9dgKAMQ28AkzwCEaJMTqCB+xcQc YKjxkdLOi6RbQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jesse Zhang , Jesse Zhang , Tim Huang , Alex Deucher , Sasha Levin , christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch, Hawking.Zhang@amd.com, tao.zhou1@amd.com, felix.kuehling@amd.com, kevinyang.wang@amd.com, lijo.lazar@amd.com, candice.li@amd.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 5.10 17/38] drm/amdgpu: the warning dereferencing obj for nbio_v7_4 Date: Wed, 31 Jul 2024 20:35:23 -0400 Message-ID: <20240801003643.3938534-17-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240801003643.3938534-1-sashal@kernel.org> References: <20240801003643.3938534-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.10.223 Content-Transfer-Encoding: 8bit From: Jesse Zhang [ Upstream commit d190b459b2a4304307c3468ed97477b808381011 ] if ras_manager obj null, don't print NBIO err data Signed-off-by: Jesse Zhang Suggested-by: Tim Huang Reviewed-by: Tim Huang Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c b/drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c index eadc9526d33fe..b81572dc115f7 100644 --- a/drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c +++ b/drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c @@ -313,7 +313,7 @@ static void nbio_v7_4_handle_ras_controller_intr_no_bifring(struct amdgpu_device RAS_CNTLR_INTERRUPT_CLEAR, 1); WREG32_SOC15(NBIO, 0, mmBIF_DOORBELL_INT_CNTL, bif_doorbell_intr_cntl); - if (!ras->disable_ras_err_cnt_harvest) { + if (ras && !ras->disable_ras_err_cnt_harvest && obj) { /* * clear error status after ras_controller_intr * according to hw team and count ue number -- 2.43.0