From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32CA714C592; Thu, 1 Aug 2024 00:37:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722472646; cv=none; b=Cw5z7ClX47ml2GnB4gCTao8aDVpnDV3z2ajEcByZ2iZL0fLkBO/4+3eUaYZRdVH5gW9c4v/XwzQY7b9gi/rHCsusNCjMQz9732CynDH9vA5V2kkzxBzREBrzzcEufpSy85MSXV8gqgi+elby+CjQ5qhxfG4kHZcannSbJB+ZFGs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722472646; c=relaxed/simple; bh=Cprr7vR9Z+EV80ZeTr3QpFys157E35gzydOAX9Cg+NQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sZ/CjSM5opm2SkIQ64No4stm8y2bMnL91gJFmzFLlSF0ITAgcW3M+0+KMdOCGCRhGFbeWvEe3Eo46+mjAe+lQJy91LxtqouM2sPBeX4fiL6O6VybGn01O9QZ7LBTViRTv4FdSVSI6G6S4pCE17CJ7K4Vpcu//BSZgm1hbIhltDw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Hp/1zalI; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Hp/1zalI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 361DCC32786; Thu, 1 Aug 2024 00:37:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722472646; bh=Cprr7vR9Z+EV80ZeTr3QpFys157E35gzydOAX9Cg+NQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Hp/1zalIBypwifAN5WepCoEzT1ac68OG0QfK5e8GokjfuQBIRRJ8UqtadMzZIwHyb ocamed+qiJH+qq/dpHPwTJom37Zw+CHpnaAMse0UfsxQ6VqOn82CnGGWW6WsF26hOt Yg86A38le81YZMCruQRi9H5KYiaUSp6vqFAJsSq8CXnCFCK23/E7qU0neVq9LJRl8G EF9Ng3oCvLno9937GJHgcEBmgb8DbNX1dAtdABwujmu42DKeaHNBWnIF7aod1ZTgu6 Xm6Pgdz9fC9aq2xciL5jRgJRjEvT8K3UXqgW31RN9ijwdx9ozR6WibuB7NvK1bm9wE a4Vbmah9GLLaw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Alex Hung , Harry Wentland , Tom Chung , Daniel Wheeler , Alex Deucher , Sasha Levin , sunpeng.li@amd.com, Rodrigo.Siqueira@amd.com, christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch, hamza.mahfooz@amd.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 5.10 09/38] drm/amd/display: Check msg_id before processing transcation Date: Wed, 31 Jul 2024 20:35:15 -0400 Message-ID: <20240801003643.3938534-9-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240801003643.3938534-1-sashal@kernel.org> References: <20240801003643.3938534-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.10.223 Content-Transfer-Encoding: 8bit From: Alex Hung [ Upstream commit fa71face755e27dc44bc296416ebdf2c67163316 ] [WHY & HOW] HDCP_MESSAGE_ID_INVALID (-1) is not a valid msg_id nor is it a valid array index, and it needs checking before used. This fixes 4 OVERRUN issues reported by Coverity. Reviewed-by: Harry Wentland Acked-by: Tom Chung Signed-off-by: Alex Hung Tested-by: Daniel Wheeler Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/display/dc/hdcp/hdcp_msg.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/hdcp/hdcp_msg.c b/drivers/gpu/drm/amd/display/dc/hdcp/hdcp_msg.c index 51855a2624cf4..b1d5387195054 100644 --- a/drivers/gpu/drm/amd/display/dc/hdcp/hdcp_msg.c +++ b/drivers/gpu/drm/amd/display/dc/hdcp/hdcp_msg.c @@ -130,13 +130,21 @@ static bool hdmi_14_process_transaction( const uint8_t hdcp_i2c_addr_link_primary = 0x3a; /* 0x74 >> 1*/ const uint8_t hdcp_i2c_addr_link_secondary = 0x3b; /* 0x76 >> 1*/ struct i2c_command i2c_command; - uint8_t offset = hdcp_i2c_offsets[message_info->msg_id]; + uint8_t offset; struct i2c_payload i2c_payloads[] = { - { true, 0, 1, &offset }, + { true, 0, 1, 0 }, /* actual hdcp payload, will be filled later, zeroed for now*/ { 0 } }; + if (message_info->msg_id == HDCP_MESSAGE_ID_INVALID) { + DC_LOG_ERROR("%s: Invalid message_info msg_id - %d\n", __func__, message_info->msg_id); + return false; + } + + offset = hdcp_i2c_offsets[message_info->msg_id]; + i2c_payloads[0].data = &offset; + switch (message_info->link) { case HDCP_LINK_SECONDARY: i2c_payloads[0].address = hdcp_i2c_addr_link_secondary; @@ -310,6 +318,11 @@ static bool dp_11_process_transaction( struct dc_link *link, struct hdcp_protection_message *message_info) { + if (message_info->msg_id == HDCP_MESSAGE_ID_INVALID) { + DC_LOG_ERROR("%s: Invalid message_info msg_id - %d\n", __func__, message_info->msg_id); + return false; + } + return dpcd_access_helper( link, message_info->length, -- 2.43.0