From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 080F8137742; Thu, 1 Aug 2024 00:40:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722472815; cv=none; b=geRKRMBtEy/iUqQi6FiYagm2xUZ8RleLt2diFT2mktX2M/Q4YIEYitV1m443kkc1ZTOtIE7VQyCkYXhHAG0U9a3WIovIqLGTxJHWJzvb668mAW977uaIjsdQKc2JvYXRLEiC1FeI5fHD30rRBTRxNxLMQEjQCLqXbsaFNdIytNM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722472815; c=relaxed/simple; bh=eOZVrvFPTYTPuURL5sg7khtZoVA9aAvK6w8nSHMmKUc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ORUPAQ534DrzBVETldndv3QnXDUERaMn4xmBgaZk8rc3R38Jqr4fLy8nRmqclGycgEn+7rW4T4PLfGz7j03ydBVNCvxACmHrvq1vRGslvA1tWtIcY3sdHKrro6Hbnp6KiAEV4Erf4DI6hWanY0shoEElkfs0XfwaEEVe8MwNjis= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=R8myNCNW; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="R8myNCNW" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BC33AC116B1; Thu, 1 Aug 2024 00:40:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722472814; bh=eOZVrvFPTYTPuURL5sg7khtZoVA9aAvK6w8nSHMmKUc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=R8myNCNWuONfAidBmJZJXo+XLlbof1nDHXvdbVK/qkAYCS8fPdA0+O/uwiz72C68K cPzKdALQq1HUs1tH7jHn4oskqeBbc9YqYPtwxOYe/stiQbTdrDaLEOIo61E5w+Qjxt tpIsFlOss57IZ2YQgU2iOKnl0McRBYI4VDReJ4qQ97+KJx6n9CmZ+gLEBmQNYOuzsT ZZB9cgT4S+ksSa+skwNZW90xtnhQPC7HThDJd7hVM6Je3ZPdWAnjDcZXKsCycIAIwI zzoKeQRtFpGHx9UqMi6FpTHf3SXAHtuYi6kRNek/4vRlX8OVT99OZYhsvjuMyCSMrI AgFMYPYMJX1pw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Guenter Roeck , Sasha Levin , jdelvare@suse.com, linux-hwmon@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 19/22] hwmon: (lm95234) Fix underflows seen when writing limit attributes Date: Wed, 31 Jul 2024 20:38:48 -0400 Message-ID: <20240801003918.3939431-19-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240801003918.3939431-1-sashal@kernel.org> References: <20240801003918.3939431-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.4.281 Content-Transfer-Encoding: 8bit From: Guenter Roeck [ Upstream commit af64e3e1537896337405f880c1e9ac1f8c0c6198 ] DIV_ROUND_CLOSEST() after kstrtol() results in an underflow if a large negative number such as -9223372036854775808 is provided by the user. Fix it by reordering clamp_val() and DIV_ROUND_CLOSEST() operations. Signed-off-by: Guenter Roeck Signed-off-by: Sasha Levin --- drivers/hwmon/lm95234.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/hwmon/lm95234.c b/drivers/hwmon/lm95234.c index 8a2a2a4904969..c49aaf0d710fa 100644 --- a/drivers/hwmon/lm95234.c +++ b/drivers/hwmon/lm95234.c @@ -301,7 +301,8 @@ static ssize_t tcrit2_store(struct device *dev, struct device_attribute *attr, if (ret < 0) return ret; - val = clamp_val(DIV_ROUND_CLOSEST(val, 1000), 0, index ? 255 : 127); + val = DIV_ROUND_CLOSEST(clamp_val(val, 0, (index ? 255 : 127) * 1000), + 1000); mutex_lock(&data->update_lock); data->tcrit2[index] = val; @@ -350,7 +351,7 @@ static ssize_t tcrit1_store(struct device *dev, struct device_attribute *attr, if (ret < 0) return ret; - val = clamp_val(DIV_ROUND_CLOSEST(val, 1000), 0, 255); + val = DIV_ROUND_CLOSEST(clamp_val(val, 0, 255000), 1000); mutex_lock(&data->update_lock); data->tcrit1[index] = val; @@ -391,7 +392,7 @@ static ssize_t tcrit1_hyst_store(struct device *dev, if (ret < 0) return ret; - val = DIV_ROUND_CLOSEST(val, 1000); + val = DIV_ROUND_CLOSEST(clamp_val(val, -255000, 255000), 1000); val = clamp_val((int)data->tcrit1[index] - val, 0, 31); mutex_lock(&data->update_lock); @@ -431,7 +432,7 @@ static ssize_t offset_store(struct device *dev, struct device_attribute *attr, return ret; /* Accuracy is 1/2 degrees C */ - val = clamp_val(DIV_ROUND_CLOSEST(val, 500), -128, 127); + val = DIV_ROUND_CLOSEST(clamp_val(val, -64000, 63500), 500); mutex_lock(&data->update_lock); data->toffset[index] = val; -- 2.43.0