From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B22B1C688A; Thu, 1 Aug 2024 00:39:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722472781; cv=none; b=fZZ2aM4/3wt2q6xECwBKr2cdLndu+XIpkZzGvbk6tL9dCyylDHJ7ib70AVUmbhVHDTUCZpi6TTGjNIhru8Rs+kinKlapvwcfM385Kf5tXbC/yGacd3ZmcFwKhcSSfugvvMweEXK5V4inqRe1OtCx9Z+zGEsyVG7Ch673oYyvZ2k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722472781; c=relaxed/simple; bh=4sDPqhpHBCTkewJpiitY68SCKePEiala8EEaBh2uTqs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QXUE3CJA6gxEaiVTASpEV6zk5EaTH8rp9FuXXR8bsJTckArxL6fKsqAzJ0suEjvAXpGZvMuaRbGsHjzBygkWMza5VfPnaSgCV5/qyNsDr/ywLeVdDxaXFRpja4yDFd9uOQKBJrgrq8xeGiahv6zKz8340r9L+oSUsjZ1uUL0iRU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PE1mBHeu; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PE1mBHeu" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 96290C116B1; Thu, 1 Aug 2024 00:39:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722472780; bh=4sDPqhpHBCTkewJpiitY68SCKePEiala8EEaBh2uTqs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PE1mBHeu3DY/LY+f9qOktWD511tI3R34c1U0j8xsl8vvS9EX4MQaksbSFeCDMdBuI 3UNkeyVEangtFyVOAIjgtA0x401MTu3nKLCplOsEalrsZf5ERgvRkYCaF7B13XyPZ2 Kvd4X7QbXCkAQt3qceVG6Gc1nMEP/t6BIe3/3ZU9qhf0/3xWeDXnlDLiKcNK4YBs89 IADOwu4LCMlp8/BicoC9FGq8Rb7QuJTFluaVQyYmQuu9rR91DgVcOuuZuGhxYRDqin 3qLwV8keu6/jMY9jVhymNiPass9cUdfm5B1YaJVuEaLc9GAOZ/fMbjUwJsFdPc+Q1H RV9tPdJkbP0Cg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Hersen Wu , Harry Wentland , Tom Chung , Daniel Wheeler , Alex Deucher , Sasha Levin , sunpeng.li@amd.com, Rodrigo.Siqueira@amd.com, christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch, alex.hung@amd.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 5.4 05/22] drm/amd/display: Fix Coverity INTEGER_OVERFLOW within dal_gpio_service_create Date: Wed, 31 Jul 2024 20:38:34 -0400 Message-ID: <20240801003918.3939431-5-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240801003918.3939431-1-sashal@kernel.org> References: <20240801003918.3939431-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.4.281 Content-Transfer-Encoding: 8bit From: Hersen Wu [ Upstream commit c6077aa66fa230d12f37fef01161ef080d13b726 ] [Why] For subtraction, coverity reports integer overflow warning message when variable type is uint32_t. [How] Change variable type to int32_t. Reviewed-by: Harry Wentland Acked-by: Tom Chung Signed-off-by: Hersen Wu Tested-by: Daniel Wheeler Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/display/dc/gpio/gpio_service.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/gpio/gpio_service.c b/drivers/gpu/drm/amd/display/dc/gpio/gpio_service.c index f76ec0dd29e7b..a61cec470d28c 100644 --- a/drivers/gpu/drm/amd/display/dc/gpio/gpio_service.c +++ b/drivers/gpu/drm/amd/display/dc/gpio/gpio_service.c @@ -58,7 +58,7 @@ struct gpio_service *dal_gpio_service_create( struct dc_context *ctx) { struct gpio_service *service; - uint32_t index_of_id; + int32_t index_of_id; service = kzalloc(sizeof(struct gpio_service), GFP_KERNEL); @@ -114,7 +114,7 @@ struct gpio_service *dal_gpio_service_create( return service; failure_2: - while (index_of_id) { + while (index_of_id > 0) { --index_of_id; kfree(service->busyness[index_of_id]); } -- 2.43.0