From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B4761E6125; Thu, 1 Aug 2024 00:39:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722472789; cv=none; b=NiNhIHXoRHPC5150iJNpoAB8AiGk3wxHTr1IJJtvOJxK1Al0qQkuhtWSnDpHyaGuknfnIdKxG6x0bOLmAEkfTE4XZhcpFC3lLin8WDJ74ZqgzR/JEBj0fxtRRalYX2hEKLJPxExzANv3KHjeaZWvl/nHlzRcQ/u43TNN/1Uh828= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722472789; c=relaxed/simple; bh=5yGZSrxg4usMQXPApzHxmpF4vhWBZgASAssMvBKLfzg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=vDSj50vEb7B9J+YU+HeCHKtvMkqjanbfljun8IuiNh2l7hAO+L5+W2CLq5xf0oNVzoWWkCNGlL1Boxcpa1PgzKOEWASt7e8MNP57ovCA1GpfSNZXdbiSBQjV4oebGizVsEww+jEkvZDGgC6lwX8nDlgk9nvvb9ESYT0rqVWPnMc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=JA3hqgc7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JA3hqgc7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2665CC32786; Thu, 1 Aug 2024 00:39:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722472789; bh=5yGZSrxg4usMQXPApzHxmpF4vhWBZgASAssMvBKLfzg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JA3hqgc7W8n6HUWamUaW+RWHnF+XsI3ItWuFMfaEKMpdz62JIsTqAukekbqogCILJ +8f6DR7spf152V+mk1Ud4Oi0B1qqDCZUomxE4v+7cUbvknmTAJQC1/L8SYp3Pb4aEd wMoL20Wm36AeKLYdmvNQ9JBxO7uipup/SqWSyu6nwpryGtFDepCwuazJVkLAVO1lSA dI+Mi5qU+X1rIMITjKyHHLjju3tAH81FtExuT1FOuhr7QiXOA77hhsbP8Ta+APvHSp tHrcrvMzj6PWyYJTmDToci1bAlDIfFFvnSaCDvQrZ/EOveGgrNkTUjuWdVooBv8kaO 9Grt8TL5cs0vg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Tim Huang , Alex Deucher , Sasha Levin , christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch, lijo.lazar@amd.com, Hawking.Zhang@amd.com, electrodeyt@gmail.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 5.4 07/22] drm/amdgpu: fix mc_data out-of-bounds read warning Date: Wed, 31 Jul 2024 20:38:36 -0400 Message-ID: <20240801003918.3939431-7-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240801003918.3939431-1-sashal@kernel.org> References: <20240801003918.3939431-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.4.281 Content-Transfer-Encoding: 8bit From: Tim Huang [ Upstream commit 51dfc0a4d609fe700750a62f41447f01b8c9ea50 ] Clear warning that read mc_data[i-1] may out-of-bounds. Signed-off-by: Tim Huang Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c index c687432da4262..89930a38b63eb 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c @@ -1626,6 +1626,8 @@ int amdgpu_atombios_init_mc_reg_table(struct amdgpu_device *adev, (u32)le32_to_cpu(*((u32 *)reg_data + j)); j++; } else if ((reg_table->mc_reg_address[i].pre_reg_data & LOW_NIBBLE_MASK) == DATA_EQU_PREV) { + if (i == 0) + continue; reg_table->mc_reg_table_entry[num_ranges].mc_data[i] = reg_table->mc_reg_table_entry[num_ranges].mc_data[i - 1]; } -- 2.43.0