From: Florian Westphal <fw@strlen.de>
To: "Wojciech Gładysz" <wojciech.gladysz@infogain.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com,
jiri@resnulli.us, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel/net: missused TCQ_F_NOLOCK flag
Date: Thu, 1 Aug 2024 14:58:56 +0200 [thread overview]
Message-ID: <20240801125856.GC10274@breakpoint.cc> (raw)
In-Reply-To: <20240801105707.30021-1-wojciech.gladysz@infogain.com>
Wojciech Gładysz <wojciech.gladysz@infogain.com> wrote:
> TCQ_F_NOLOCK yields no locking option for a qdisc. At some places in the
> code the testing for the flag seems logically reverted. The change fixes
> the following lockdep issue.
>
> ======================================================
> WARNING: possible circular locking dependency detected
> 5.10.0-syzkaller #0 Not tainted
This kernel is over 3 years old. Please either only fuzz
on net or net-next and keep them up-to-date, or wait for
the fuzzer to get a reproducer and then verify that reproducer
still triggers on current kernels.
> static inline bool qdisc_is_running(struct Qdisc *qdisc)
> {
> - if (qdisc->flags & TCQ_F_NOLOCK)
> + if (!(qdisc->flags & TCQ_F_NOLOCK))
> return spin_is_locked(&qdisc->seqlock);
Are you absolutely sure? I find it hard to believe something
like this would go unnoticed for years.
Curious glance tells me seqlock is used to sync nolock qdiscs vs.
qdisc reset, i.e. exiting code is correct.
prev parent reply other threads:[~2024-08-01 12:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-01 10:57 [PATCH] kernel/net: missused TCQ_F_NOLOCK flag Wojciech Gładysz
2024-08-01 12:58 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240801125856.GC10274@breakpoint.cc \
--to=fw@strlen.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wojciech.gladysz@infogain.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox