public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Rob Clark <robdclark@gmail.com>,
	 Abhinav Kumar <quic_abhinavk@quicinc.com>,
	Sean Paul <sean@poorly.run>,
	 Marijn Suijten <marijn.suijten@somainline.org>,
	 David Airlie <airlied@gmail.com>,
	Daniel Vetter <daniel@ffwll.ch>
Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
	 freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	 Jeykumar Sankaran <jsanka@codeaurora.org>,
	stable@vger.kernel.org,  Leonard Lausen <leonard@lausen.nl>
Subject: [PATCH v2 1/2] drm/msm/dpu1: don't choke on disabling the writeback connector
Date: Fri, 02 Aug 2024 22:47:33 +0300	[thread overview]
Message-ID: <20240802-dpu-fix-wb-v2-1-7eac9eb8e895@linaro.org> (raw)
In-Reply-To: <20240802-dpu-fix-wb-v2-0-7eac9eb8e895@linaro.org>

During suspend/resume process all connectors are explicitly disabled and
then reenabled. However resume fails because of the connector_status check:

[ 1185.831970] [dpu error]connector not connected 3

It doesn't make sense to check for the Writeback connected status (and
other drivers don't perform such check), so drop the check.

Fixes: 71174f362d67 ("drm/msm/dpu: move writeback's atomic_check to dpu_writeback.c")
Cc: stable@vger.kernel.org
Reported-by: Leonard Lausen <leonard@lausen.nl>
Closes: https://gitlab.freedesktop.org/drm/msm/-/issues/57
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c
index 16f144cbc0c9..8ff496082902 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c
@@ -42,9 +42,6 @@ static int dpu_wb_conn_atomic_check(struct drm_connector *connector,
 	if (!conn_state || !conn_state->connector) {
 		DPU_ERROR("invalid connector state\n");
 		return -EINVAL;
-	} else if (conn_state->connector->status != connector_status_connected) {
-		DPU_ERROR("connector not connected %d\n", conn_state->connector->status);
-		return -EINVAL;
 	}
 
 	crtc = conn_state->crtc;

-- 
2.39.2


  reply	other threads:[~2024-08-02 19:47 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-02 19:47 [PATCH v2 0/2] drm/msm/dpu: two fixes targeting 6.11 Dmitry Baryshkov
2024-08-02 19:47 ` Dmitry Baryshkov [this message]
2024-08-05  2:27   ` [PATCH v2 1/2] drm/msm/dpu1: don't choke on disabling the writeback connector Leonard Lausen
2024-08-07 10:44     ` Dmitry Baryshkov
2024-08-07 15:41       ` Leonard Lausen
2024-08-05 19:19   ` Abhinav Kumar
2024-08-07 10:46     ` Dmitry Baryshkov
2024-08-30 17:36   ` [v2,1/2] " György Kurucz
2024-08-31 14:53     ` Leonard Lausen
2024-08-31 15:47     ` Leonard Lausen
2024-08-31 18:46       ` György Kurucz
2024-08-31 19:00         ` Leonard Lausen
2024-08-31 21:50           ` György Kurucz
2024-11-19 13:52     ` Johan Hovold
2024-11-19 14:33       ` Leonard Lausen
2024-11-19 15:11         ` Johan Hovold
2024-11-20  3:02           ` Leonard Lausen
2024-11-20  8:32             ` Johan Hovold
2024-11-20  8:39   ` [PATCH v2 1/2] " Johan Hovold
2024-08-02 19:47 ` [PATCH v2 2/2] drm/msm/dpu: don't play tricks with debug macros Dmitry Baryshkov
2024-08-05 19:25   ` Abhinav Kumar
2024-08-27  9:39   ` Konrad Dybcio
2024-08-28 19:38     ` Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240802-dpu-fix-wb-v2-1-7eac9eb8e895@linaro.org \
    --to=dmitry.baryshkov@linaro.org \
    --cc=airlied@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=jsanka@codeaurora.org \
    --cc=leonard@lausen.nl \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marijn.suijten@somainline.org \
    --cc=quic_abhinavk@quicinc.com \
    --cc=robdclark@gmail.com \
    --cc=sean@poorly.run \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox